krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

challenges: pass down if user is member of group (group._isMember) for

Browse Source 
performance. some bug fixes
This commit is contained in:
Tyler Renelle
2013-10-29 12:26:13 -07:00
parent 219318b405
commit be657a76e0
5 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/controllers/groups.js
View File

@@ -52,7 +52,6 @@ api.getGroups = function(req, res, next) {
var fields = req.query.fields && req.query.fields.replace(/\,/g, ' ')
var challengeFields = 'name description'; // public challenge fields, request specific challenge for more details
// First get all groups
async.parallel({
party: function(cb) {
@@ -64,6 +63,8 @@ api.getGroups = function(req, res, next) {
query.populate('members', sanitizeMemberFields(req.query['fields.members'], partyFields));
if (~fields.indexOf('challenges'))
query.populate('challenges', challengeFields);
} else {
query.populate('members', partyFields);
}
query.exec(function(err, group){
if (err) return cb(err);
@@ -82,6 +83,8 @@ api.getGroups = function(req, res, next) {
query.populate('members', sanitizeMemberFields(req.query['fields.members'], 'profile.name'));
if (~fields.indexOf('challenges'))
query.populate('challenges', challengeFields);
} else {
query.populate('members', 'profile.name');
}
query.exec(cb);
},
@@ -100,9 +103,17 @@ api.getGroups = function(req, res, next) {
"public": function(cb) {
if (type && !~type.indexOf('public')) return cb(null, []);
Group.find({privacy: 'public'})
.select('name description memberCount')
.select('name description memberCount members')
.sort('-memberCount')
.exec(cb);
.exec(function(err, groups){
if (err) return cb(err);
_.each(groups, function(g){
// To save some client-side performance, don't send down the full members arr, just send down temp var _isMember
if (~g.members.indexOf(user._id)) g._isMember = true;
g.members = undefined;
});
cb(null, groups);
});
}
}, function(err, results){