krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 07:07:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(client): Correct behavior for editting new tasks

Browse Source
This commit is contained in:
Blade Barringer
2016-09-13 12:11:56 -05:00
parent cbefc13e25
commit bbe4759691
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/script/ops/addTask.js
View File

@@ -1,4 +1,5 @@
import taskDefaults from '../libs/taskDefaults'; import taskDefaults from '../libs/taskDefaults';
import clone from 'lodash/lang/clone';
// TODO move to client since it's only used there? // TODO move to client since it's only used there?
@@ -8,6 +9,9 @@ module.exports = function addTask (user, req = {body: {}}) {
user[`${task.type}s`].unshift(task); user[`${task.type}s`].unshift(task);
task._editing = user.preferences.newTaskEdit; task._editing = user.preferences.newTaskEdit;
if (task._editing) {
task._edit = clone(task);
}
task._tags = !user.preferences.tagsCollapsed; task._tags = !user.preferences.tagsCollapsed;
task._advanced = !user.preferences.advancedCollapsed; task._advanced = !user.preferences.advancedCollapsed;

2
test/common/ops/addTask.js
View File

@@ -117,9 +117,11 @@ describe('shared.ops.addTask', () => {
it('respects newTaskEdit preference', () => { it('respects newTaskEdit preference', () => {
user.preferences.newTaskEdit = true; user.preferences.newTaskEdit = true;
expect(addTask(user)._editing).to.be.ok; expect(addTask(user)._editing).to.be.ok;
expect(addTask(user)._edit).to.be.ok;
user.preferences.newTaskEdit = false; user.preferences.newTaskEdit = false;
expect(addTask(user)._editing).not.be.ok; expect(addTask(user)._editing).not.be.ok;
expect(addTask(user)._edit).to.not.be.ok;
}); });
it('respects tagsCollapsed preference', () => { it('respects tagsCollapsed preference', () => {