krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 22:57:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Prevent user from inivting self to group

Browse Source 
fixes #7491
This commit is contained in:
Blade Barringer
2016-05-29 10:09:02 -05:00
parent d23f79d001
commit bbafe3d52d
3 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
common/locales/en/groups.json
View File

@@ -177,6 +177,7 @@
"inviteMissingEmail": "Missing email address in invite.", "inviteMissingEmail": "Missing email address in invite.",
"partyMustbePrivate": "Parties must be private", "partyMustbePrivate": "Parties must be private",
"userAlreadyInGroup": "User already in that group.", "userAlreadyInGroup": "User already in that group.",
"cannotInviteSelfToGroup": "You cannot invite yourself to a group.",
"userAlreadyInvitedToGroup": "User already invited to that group.", "userAlreadyInvitedToGroup": "User already invited to that group.",
"userAlreadyPendingInvitation": "User already pending invitation.", "userAlreadyPendingInvitation": "User already pending invitation.",
"userAlreadyInAParty": "User already in a party.", "userAlreadyInAParty": "User already in a party.",

11
test/api/v3/integration/groups/POST-groups_invite.test.js
View File

@@ -33,6 +33,17 @@ describe('Post /groups/:groupId/invite', () => {
}); });
}); });
it('returns an error when inviting yourself to a group', async () => {
await expect(inviter.post(`/groups/${group._id}/invite`, {
uuids: [inviter._id],
}))
.to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
message: t('cannotInviteSelfToGroup'),
});
});
it('returns an error when uuids is not an array', async () => { it('returns an error when uuids is not an array', async () => {
let fakeID = generateUUID(); let fakeID = generateUUID();

2
website/server/controllers/api-v3/groups.js
View File

@@ -487,6 +487,8 @@ async function _inviteByUUID (uuid, group, inviter, req, res) {
if (!userToInvite) { if (!userToInvite) {
throw new NotFound(res.t('userWithIDNotFound', {userId: uuid})); throw new NotFound(res.t('userWithIDNotFound', {userId: uuid}));
} else if (inviter._id === userToInvite._id) {
throw new BadRequest(res.t('cannotInviteSelfToGroup'));
} }
if (group.type === 'guild') { if (group.type === 'guild') {