krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

use $elemMatch for better performance on fetching challenge participants

Browse Source
This commit is contained in:
Tyler Renelle
2013-11-04 00:27:44 -08:00
parent 0d6d20b939
commit b7479e7839
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/controllers/challenges.js
View File

@@ -52,7 +52,10 @@ api.list = function(req, res) {
// GET // GET
api.get = function(req, res) { api.get = function(req, res) {
var user = res.locals.user; // TODO use mapReduce() or aggregate() here to
// 1) Find the sum of users.tasks.values within the challnege (eg, {'profile.name':'tyler', 'sum': 100})
// 2) Sort by the sum
// 3) Limit 30 (only show the 30 users currently in the lead)
Challenge.findById(req.params.cid) Challenge.findById(req.params.cid)
.populate('members', 'profile.name _id') .populate('members', 'profile.name _id')
.exec(function(err, challenge){ .exec(function(err, challenge){
@@ -64,16 +67,12 @@ api.get = function(req, res) {
api.getMember = function(req, res) { api.getMember = function(req, res) {
var cid = req.params.cid, uid = req.params.uid; var cid = req.params.cid, uid = req.params.uid;
User.findById(uid).select('profile.name habits dailys rewards todos') var elMatch = {$elemMatch:{'challenge.id':cid}};
User.findById(uid)
.select({'profile.name':1, habits:elMatch, dailys:elMatch, rewards:elMatch, todos:elMatch})
.exec(function(err, member){ .exec(function(err, member){
if(err) return res.json(500, {err:err}); if(err) return res.json(500, {err:err});
if (!member) return res.json(404, {err: 'Member '+uid+' for challenge '+cid+' not found'}); if (!member) return res.json(404, {err: 'Member '+uid+' for challenge '+cid+' not found'});
// slim down the return members' tasks to only the ones in the challenge
_.each(['habits', 'dailys', 'todos', 'rewards'], function(type){
member[type] = _.where(member[type], function(task){
return task.challenge && task.challenge.id == cid;
})
});
res.json(member); res.json(member);
}) })
} }