krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 07:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use res and req generators in error handler test

Browse Source
This commit is contained in:
Blade Barringer
2015-11-07 09:26:13 -06:00
parent 1eadceea3d
commit b323c3b5e9
1 changed files with 14 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/api/v3/unit/middlewares/errorHandler.test.js
View File

@@ -1,33 +1,29 @@
import {
generateRes,
generateReq,
generateNext,
} from '../../../../helpers/api-unit.helper';
import errorHandler from '../../../../../website/src/middlewares/api-v3/errorHandler'; import errorHandler from '../../../../../website/src/middlewares/api-v3/errorHandler';
import { BadRequest } from '../../../../../website/src/libs/api-v3/errors'; import { BadRequest } from '../../../../../website/src/libs/api-v3/errors';
import logger from '../../../../../website/src/libs/api-v3/logger'; import logger from '../../../../../website/src/libs/api-v3/logger';
describe('errorHandler', () => { describe('errorHandler', () => {
let res, req; let res, req, next;
beforeEach(() => { beforeEach(() => {
res = { res = generateRes();
status: sinon.stub().returnsThis(), req = generateReq();
json: sinon.stub(), next = generateNext();
};
req = {
originalUrl: 'foo',
headers: {},
body: {},
};
sinon.stub(logger, 'error'); sandbox.stub(logger, 'error');
});
afterEach(() => {
logger.error.restore();
}); });
it('sends internal server error if error is not a CustomError', () => { it('sends internal server error if error is not a CustomError', () => {
let error = new Error(); let error = new Error();
errorHandler(error, req, res); errorHandler(error, req, res, next);
expect(res.status).to.be.calledOnce; expect(res.status).to.be.calledOnce;
expect(res.json).to.be.calledOnce; expect(res.json).to.be.calledOnce;
@@ -42,7 +38,7 @@ describe('errorHandler', () => {
it('sends CustomError', () => { it('sends CustomError', () => {
let error = new BadRequest(); let error = new BadRequest();
errorHandler(error, req, res); errorHandler(error, req, res, next);
expect(res.status).to.be.calledOnce; expect(res.status).to.be.calledOnce;
expect(res.json).to.be.calledOnce; expect(res.json).to.be.calledOnce;
@@ -57,7 +53,7 @@ describe('errorHandler', () => {
it('logs error', () => { it('logs error', () => {
let error = new BadRequest(); let error = new BadRequest();
errorHandler(error, req, res); errorHandler(error, req, res, next);
expect(logger.error).to.be.calledOnce; expect(logger.error).to.be.calledOnce;
expect(logger.error).to.be.calledWith(error.stack, { expect(logger.error).to.be.calledWith(error.stack, {
@@ -68,7 +64,6 @@ describe('errorHandler', () => {
}); });
it('does not send error if error is not defined', () => { it('does not send error if error is not defined', () => {
let next = sinon.stub();
errorHandler(null, req, res, next); errorHandler(null, req, res, next);
expect(next).to.be.calledOnce; expect(next).to.be.calledOnce;