From ab4009bd32b11402ab7aa1a8759c176d2cad8386 Mon Sep 17 00:00:00 2001 From: alexthomson1 Date: Sat, 25 Jan 2020 18:28:26 -0700 Subject: [PATCH] Refactoring dropdown.vue so that dropdownMobile calls openDropdown and closeDropdown --- website/client/src/components/header/menu.vue | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/website/client/src/components/header/menu.vue b/website/client/src/components/header/menu.vue index d1a26d3e23..5d27050b3e 100644 --- a/website/client/src/components/header/menu.vue +++ b/website/client/src/components/header/menu.vue @@ -811,9 +811,7 @@ export default { } }, dropdownMobile (click) { - this.dropdown(click.currentTarget.parentElement); - }, - dropdown (element) { + const element = click.currentTarget.parentElement; const droppedElement = document.getElementsByClassName('down')[0]; if (droppedElement && droppedElement !== element) { droppedElement.classList.remove('down'); @@ -821,9 +819,11 @@ export default { droppedElement.lastChild.style.maxHeight = 0; } } - - element.classList.toggle('down'); - element.lastChild.style.maxHeight = element.classList.contains('down') ? `${element.lastChild.scrollHeight}px` : 0; + if (element.classList.contains('down')) { + this.closeDropdown(element); + } else { + this.openDropdown(element); + } }, closeDropdown (element) { element.classList.remove('down');