krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: Add quest details to group in quest invite route

Browse Source
This commit is contained in:
Blade Barringer
2016-02-01 18:02:32 -06:00
parent c699874e36
commit a7486821e5
2 changed files with 70 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
test/api/v3/integration/groups/POST-groups_groupId_quests_invite.test.js
View File

@@ -111,33 +111,67 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
}); });
}); });
context.skip('successfully issuing a quest invitation', () => { context('successfully issuing a quest invitation', () => {
let inviteResponse; beforeEach(async () => {
const memberUpdate = {};
memberUpdate[`items.quests.${PET_QUEST}`] = 1;
beforeEach(() => { await Promise.all([
inviteResponse = { leader.update(memberUpdate),
key: PET_QUEST, member.update(memberUpdate),
active: false, ]);
leader: leader._id,
members: {},
progress: {
collect: {},
},
};
inviteResponse.members[member._id] = null;
inviteResponse.members[leader._id] = null;
}); });
it('sends an invite to all party members', async () => { xit('adds quest details to group object', async () => {
leader.items.quests[PET_QUEST] = 1; await leader.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
await expect(leader.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`)).to.eventually.deep.equal(inviteResponse); await questingGroup.sync();
let quest = questingGroup.quest;
expect(quest.key).to.eql(PET_QUEST);
expect(quest.active).to.eql(false);
expect(quest.leader).to.eql(false);
expect(quest.members).to.have.property(leader._id, null);
expect(quest.members).to.have.property(member._id, null);
expect(quest).to.have.property('progress');
}); });
it('allows non-leader party members to send invites', async () => { xit('adds quest details to user objects', async () => {
member.items.quests[PET_QUEST] = 1; await leader.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
await expect(member.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`)).to.eventually.deep.equal(inviteResponse); await Promise.all([
leader.sync(),
member.sync(),
]);
[leader, member].forEach((user) => {
let quest = user.party.quest;
expect(quest.key).to.eql(PET_QUEST);
expect(quest.active).to.eql(false);
expect(quest.leader).to.eql(false);
expect(quest.members).to.have.property(leader._id, null);
expect(quest.members).to.have.property(member._id, null);
expect(quest).to.have.property('progress');
});
});
xit('sends back the quest object', async () => {
let inviteResponse = await leader.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
expect(inviteResponse.key).to.eql(PET_QUEST);
expect(inviteResponse.active).to.eql(false);
expect(inviteResponse.leader).to.eql(false);
expect(inviteResponse.members).to.have.property(leader._id, null);
expect(inviteResponse.members).to.have.property(member._id, null);
expect(inviteResponse).to.have.property('progress');
});
xit('allows non-leader party members to send invites', async () => {
let inviteResponse = await member.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
expect(inviteResponse.key).to.eql(PET_QUEST);
}); });
}); });
}); });

16
website/src/controllers/api-v3/groups.js
View File

@@ -650,7 +650,23 @@ api.inviteToQuest = {
if (user.stats.lvl < quest.lvl) throw new NotAuthorized(res.t('questLevelTooHigh', { level: quest.lvl })); if (user.stats.lvl < quest.lvl) throw new NotAuthorized(res.t('questLevelTooHigh', { level: quest.lvl }));
if (group.quest.key) throw new NotAuthorized(res.t('questAlreadyUnderway')); if (group.quest.key) throw new NotAuthorized(res.t('questAlreadyUnderway'));
group.markModified('quest');
group.quest.key = questKey;
group.quest.leader = user._id;
group.quest.members = {};
// let memberUpdate = {
// '$set': {
// 'party.quest.key': questKey,
// 'party.quest.progress.down': 0,
// 'party.quest.completed': null,
// },
// };
// TODO collect members of party
// TODO Logic for quest invite and send back quest object // TODO Logic for quest invite and send back quest object
await group.save();
res.respond(200, {}); res.respond(200, {});
}, },
}; };