krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-14 13:17:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Group category update issue (#14186)

Browse Source 
* Overwrite arrays instead of merging

* Test removing a category

* Fix previous duplicated categories on group edit
This commit is contained in:
Anton de Regt
2022-10-12 22:51:56 +02:00
committed by GitHub
parent 8f26a22bd4
commit a4326498d1
2 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
website/server/controllers/api-v3/groups.js
View File

@@ -492,7 +492,17 @@ api.updateGroup = {
if (req.body.leader !== user._id && group.hasNotCancelled()) throw new NotAuthorized(res.t('cannotChangeLeaderWithActiveGroupPlan'));
_.assign(group, _.merge(group.toObject(), Group.sanitizeUpdate(req.body)));
const handleArrays = (currentValue, updatedValue) => {
if (!_.isArray(currentValue)) {
return undefined;
}
// Previously, categories could get duplicated. By making the updated category list unique,
// the duplication issue is fixed on every group edit
return _.uniqBy(updatedValue, 'slug');
};
_.assign(group, _.mergeWith(group.toObject(), Group.sanitizeUpdate(req.body), handleArrays));
const savedGroup = await group.save();
const response = await Group.toJSONCleanChat(savedGroup, user);