diff --git a/package.json b/package.json index a14173614d..56fa6cdd6c 100644 --- a/package.json +++ b/package.json @@ -128,7 +128,7 @@ "shelljs": "^0.4.0", "sinon": "1.15.4", "sinon-chai": "^2.7.0", - "superagent-defaults": "~0.1.5", + "superagent-defaults": "^0.1.13", "uuid": "^2.0.1", "vinyl-source-stream": "^1.0.0", "vinyl-transform": "^1.0.0" diff --git a/tasks/gulp-tests.js b/tasks/gulp-tests.js index 3cada7842a..091c5fd5bd 100644 --- a/tasks/gulp-tests.js +++ b/tasks/gulp-tests.js @@ -339,7 +339,7 @@ gulp.task('test', [ // 'test:content:safe', 'test:server_side:safe', 'test:karma:safe', - // 'test:api-legacy:safe', + 'test:api-legacy:safe', 'test:api:safe', 'test:e2e:safe' ], () => { diff --git a/test/api-legacy/anonymized.coffee b/test/api-legacy/anonymized.coffee index 5532a8c472..c570229069 100644 --- a/test/api-legacy/anonymized.coffee +++ b/test/api-legacy/anonymized.coffee @@ -10,7 +10,7 @@ describe "GET /api/v2/user/anonymized", -> # TODO: Seed user with messages, rewards, dailys, checklists, webhooks, etc registerNewUser -> request.get(baseURL + "/user/anonymized") - .end (res) -> + .end (err, res) -> anon = res.body done() , true diff --git a/test/api-legacy/api-helper.coffee b/test/api-legacy/api-helper.coffee index 0c3ae7b580..3c4ed36df2 100644 --- a/test/api-legacy/api-helper.coffee +++ b/test/api-legacy/api-helper.coffee @@ -26,7 +26,7 @@ conf.set "PORT", "1337" ############################## # Node ENV and global variables ############################## -process.env.NODE_DB_URI = "mongodb://localhost/habitrpg_test" +process.env.NODE_DB_URI = "mongodb://localhost/habitrpg_test_api_legacy" global.baseURL = "http://localhost:" + conf.get("PORT") + "/api/v2" global.user = undefined @@ -51,7 +51,7 @@ global.registerNewUser = (cb, main) -> password: randomID confirmPassword: randomID email: randomID + "@gmail.com" - .end (res) -> + .end (err, res) -> return cb(null, res.body) unless main _id = res.body._id apiToken = res.body.apiToken diff --git a/test/api-legacy/challenges.coffee b/test/api-legacy/challenges.coffee index ad4172c30a..8fa3afe9ce 100644 --- a/test/api-legacy/challenges.coffee +++ b/test/api-legacy/challenges.coffee @@ -18,7 +18,7 @@ describe "Challenges", -> request.post(baseURL + "/groups").send( name: "TestGroup" type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 group = res.body expect(group.members.length).to.equal 1 @@ -38,7 +38,7 @@ describe "Challenges", -> }] rewards: [] habits: [] - ).end (res) -> + ).end (err, res) -> challenge = res.body done() ] @@ -64,7 +64,7 @@ describe "Challenges", -> rewards: [] habits: [] official: true - ).end (res) -> + ).end (err, res) -> expectCode res, 200 async.parallel [ (cb) -> @@ -84,7 +84,7 @@ describe "Challenges", -> updateTodo.notes = "User overriden notes" async.waterfall [ (cb) -> - request.put(baseURL + "/user/tasks/" + updateTodo.id).send(updateTodo).end (res) -> + request.put(baseURL + "/user/tasks/" + updateTodo.id).send(updateTodo).end (err, res) -> cb() , (cb) -> Challenge.findById challenge._id, cb @@ -93,7 +93,7 @@ describe "Challenges", -> cb() , (cb) -> request.get(baseURL + "/user/tasks/" + updateTodo.id) - .end (res) -> + .end (err, res) -> expect(res.body.notes).to.eql("User overriden notes") done() ] @@ -102,7 +102,7 @@ describe "Challenges", -> challenge.dailys[0].text = "Updated Daily" request.post(baseURL + "/challenges/" + challenge._id) .send(challenge) - .end (res) -> + .end (err, res) -> challenge = res.body expect(challenge.dailys[0].text).to.equal "Updated Daily" User.findById user._id, (err, _user) -> @@ -114,7 +114,7 @@ describe "Challenges", -> challenge.todos[0].notes = "Challenge Updated Todo Notes" request.post(baseURL + "/challenges/" + challenge._id) .send(challenge) - .end (res) -> + .end (err, res) -> challenge = res.body expect(challenge.todos[0].notes).to.equal "Challenge Updated Todo Notes" User.findById user._id, (err, _user) -> @@ -128,7 +128,7 @@ describe "Challenges", -> updateTodo.notes = "User overriden notes" async.waterfall [ (cb) -> - request.put(baseURL + "/user/tasks/" + updateTodo.id).send(updateTodo).end (res) -> + request.put(baseURL + "/user/tasks/" + updateTodo.id).send(updateTodo).end (err, res) -> cb() , (cb) -> Challenge.findById challenge._id, cb @@ -136,7 +136,7 @@ describe "Challenges", -> expect(chal.todos[0].notes).to.eql("Challenge Notes") cb() , (cb) -> - request.get(baseURL + "/challenges/" + challenge._id + "/member/" + user._id).end (res) -> + request.get(baseURL + "/challenges/" + challenge._id + "/member/" + user._id).end (err, res) -> expect(res.body.todos[res.body.todos.length - 1].notes).to.equal "User overriden notes" done() ] @@ -145,14 +145,14 @@ describe "Challenges", -> User.findById user._id, (err, _user) -> u = _user numTasks = (_.size(u.todos)) - request.post(baseURL + "/user/tasks/" + u.todos[0].id + "/up").end (res) -> - request.post(baseURL + "/user/tasks/clear-completed").end (res) -> + request.post(baseURL + "/user/tasks/" + u.todos[0].id + "/up").end (err, res) -> + request.post(baseURL + "/user/tasks/clear-completed").end (err, res) -> expect(_.size(res.body)).to.equal numTasks - 1 done() it "Challenge deleted, breaks task link", (done) -> itThis = this - request.del(baseURL + "/challenges/" + challenge._id).end (res) -> + request.del(baseURL + "/challenges/" + challenge._id).end (err, res) -> User.findById user._id, (err, user) -> len = user.dailys.length - 1 daily = user.dailys[user.dailys.length - 1] @@ -164,7 +164,7 @@ describe "Challenges", -> User.findByIdAndUpdate user._id, unset, (err, user) -> expect(err).to.not.exist expect(user.dailys[len].challenge.broken).to.not.exist - request.post(baseURL + "/user/tasks/" + daily.id + "/up").end (res) -> + request.post(baseURL + "/user/tasks/" + daily.id + "/up").end (err, res) -> setTimeout (-> User.findById user._id, (err, user) -> expect(user.dailys[len].challenge.broken).to.equal "CHALLENGE_DELETED" @@ -186,7 +186,7 @@ describe "Challenges", -> rewards: [] habits: [] official: false - ).end (res) -> + ).end (err, res) -> expect(res.body.official).to.equal false cb() (cb) -> @@ -197,7 +197,7 @@ describe "Challenges", -> rewards: [] habits: [] official: true - ).end (res) -> + ).end (err, res) -> expect(res.body.official).to.equal true cb() ], done @@ -215,7 +215,7 @@ describe "Challenges", -> rewards: [] habits: [] prize: 10 - ).end (res) -> + ).end (err, res) -> expect(res.body.prize).to.equal 10 async.parallel [ (cb) -> @@ -226,7 +226,7 @@ describe "Challenges", -> user = results[0] challenge = results[1] expect(user.balance).to.equal 5.5 - request.del(baseURL + "/challenges/" + challenge._id).end (res) -> + request.del(baseURL + "/challenges/" + challenge._id).end (err, res) -> User.findById user._id, (err, _user) -> expect(_user.balance).to.equal 8 done() @@ -244,7 +244,7 @@ describe "Challenges", -> rewards: [] habits: [] prize: 10 - ).end (res) -> + ).end (err, res) -> expect(res.body.prize).to.equal 10 async.parallel [ (cb) -> @@ -255,7 +255,7 @@ describe "Challenges", -> user = results[0] challenge = results[1] expect(user.balance).to.equal 5.5 - request.del(baseURL + "/challenges/" + challenge._id).end (res) -> + request.del(baseURL + "/challenges/" + challenge._id).end (err, res) -> User.findById user._id, (err, _user) -> expect(_user.balance).to.equal 5.5 done() @@ -273,7 +273,7 @@ describe "Challenges", -> type: "daily" text: "Challenge Daily" ] - ).end (res) -> + ).end (err, res) -> challenge = res.body cb() @@ -287,7 +287,7 @@ describe "Challenges", -> challenge.name = 'foobar' request.post(baseURL + "/challenges/" + challenge._id) .send(challenge) - .end (res) -> + .end (err, res) -> error = res.body.err expect(error).to.eql("You don't have permissions to edit this challenge") @@ -295,7 +295,7 @@ describe "Challenges", -> it 'can not close challenge', (done) -> request.post(baseURL + "/challenges/" + challenge._id + "/close?uid=" + user._id) - .end (res) -> + .end (err, res) -> error = res.body.err expect(error).to.eql("You don't have permissions to close this challenge") @@ -303,7 +303,7 @@ describe "Challenges", -> it 'can not delete challenge', (done) -> request.del(baseURL + "/challenges/" + challenge._id) - .end (res) -> + .end (err, res) -> error = res.body.err expect(error).to.eql("You don't have permissions to delete this challenge") @@ -318,7 +318,7 @@ describe "Challenges", -> challenge.name = 'foobar' request.post(baseURL + "/challenges/" + challenge._id) .send(challenge) - .end (res) -> + .end (err, res) -> expect(res.body.err).to.not.exist Challenge.findById challenge._id, (err, chal) -> expect(chal.name).to.eql('foobar') @@ -326,7 +326,7 @@ describe "Challenges", -> it 'can close challenge', (done) -> request.post(baseURL + "/challenges/" + challenge._id + "/close?uid=" + user._id) - .end (res) -> + .end (err, res) -> expect(res.body.err).to.not.exist User.findById user._id, (err, usr) -> expect(usr.achievements.challenges[0]).to.eql(challenge.name) @@ -334,10 +334,10 @@ describe "Challenges", -> it 'can delete challenge', (done) -> request.del(baseURL + "/challenges/" + challenge._id) - .end (res) -> + .end (err, res) -> expect(res.body.err).to.not.exist request.get(baseURL + "/challenges/" + challenge._id) - .end (res) -> + .end (err, res) -> error = res.body.err expect(error).to.eql("Challenge #{challenge._id} not found") done() diff --git a/test/api-legacy/chat.coffee b/test/api-legacy/chat.coffee index 38c1254a00..d480f75c6d 100644 --- a/test/api-legacy/chat.coffee +++ b/test/api-legacy/chat.coffee @@ -16,7 +16,7 @@ describe "Chat", -> request.post(baseURL + "/groups").send( name: "TestGroup" type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 group = res.body expect(group.members.length).to.equal 1 @@ -28,7 +28,7 @@ describe "Chat", -> chat = undefined it "posts a message to party chat", (done) -> msg = "TestMsg" - request.post(baseURL + "/groups/" + group._id + "/chat?message=" + msg).end (res) -> + request.post(baseURL + "/groups/" + group._id + "/chat?message=" + msg).end (err, res) -> expectCode res, 200 chat = res.body.message expect(chat.id).to.be.ok @@ -47,14 +47,14 @@ describe "Chat", -> it "does not post an empty message", (done) -> msg = "" request.post(baseURL + "/groups/" + group._id + "/chat?message=" + msg).send( - ).end (res) -> + ).end (err, res) -> expectCode res, 400 expect(res.body.err).to.equal 'You cannot send a blank message' done() it "can not like own chat message", (done) -> request.post(baseURL + "/groups/" + group._id + "/chat/" + chat.id + "/like").send( - ).end (res) -> + ).end (err, res) -> expectCode res, 401 body = res.body expect(body.err).to.equal "Can't like your own message. Don't be that person." @@ -62,7 +62,7 @@ describe "Chat", -> it "can not flag own message", (done) -> request.post(baseURL + "/groups/" + group._id + "/chat/" + chat.id + "/flag").send( - ).end (res) -> + ).end (err, res) -> expectCode res, 401 body = res.body expect(body.err).to.equal "Can't report your own message." @@ -70,7 +70,7 @@ describe "Chat", -> it "gets chat messages from party chat", (done) -> request.get(baseURL + "/groups/" + group._id + "/chat").send( - ).end (res) -> + ).end (err, res) -> expectCode res, 200 message = res.body[0] expect(message.id).to.equal chat.id @@ -86,14 +86,14 @@ describe "Chat", -> it "deletes a chat messages from party chat", (done) -> request.del(baseURL + "/groups/" + group._id + "/chat/" + chat.id).send( - ).end (res) -> + ).end (err, res) -> expectCode res, 204 expect(res.body).to.be.empty done() it "can not delete already deleted message", (done) -> request.del(baseURL + "/groups/" + group._id + "/chat/" + chat.id).send( - ).end (res) -> + ).end (err, res) -> expectCode res, 404 body = res.body expect(body.err).to.equal "Message not found!" @@ -116,30 +116,30 @@ describe "Chat", -> request.post(baseURL + "/groups/" + group._id + "/join") .set("X-API-User", userToRemove._id) .set("X-API-Key", userToRemove.apiToken) - .end (res) -> cb() + .end (err, res) -> cb() (cb) -> msg = "TestMsg" request.post(baseURL + "/groups/" + group._id + "/chat?message=" + msg) - .end (res) -> cb() + .end (err, res) -> cb() (cb) -> request.get(baseURL + "/user") .set("X-API-User", userToRemove._id) .set("X-API-Key", userToRemove.apiToken) - .end (res) -> + .end (err, res) -> expect(res.body.newMessages[group._id]).to.exist cb() (cb) -> request.post(baseURL + "/groups/" + group._id + "/removeMember?uuid=" + userToRemove._id) - .end (res) -> cb() + .end (err, res) -> cb() (cb) -> request.get(baseURL + "/user") .set("X-API-User", userToRemove._id) .set("X-API-Key", userToRemove.apiToken) - .end (res) -> + .end (err, res) -> expect(res.body.newMessages[group._id]).to.not.exist cb() ], done diff --git a/test/api-legacy/coupons.coffee b/test/api-legacy/coupons.coffee index 4a0635aa9c..c6fb4f36d7 100644 --- a/test/api-legacy/coupons.coffee +++ b/test/api-legacy/coupons.coffee @@ -34,7 +34,7 @@ describe "Coupons", -> queries = '?count=10' request .post(baseURL + '/coupons/generate/wondercon' + queries) - .end (res) -> + .end (err, res) -> expectCode res, 200 Coupon.find { event: 'wondercon' }, (err, _coupons) -> coupons = _coupons @@ -52,7 +52,7 @@ describe "Coupons", -> queries = '?count=10' request .post(baseURL + '/coupons/generate/wondercon' + queries) - .end (res) -> + .end (err, res) -> expectCode res, 401 expect(res.body.err).to.equal 'You don\'t have admin access' done() @@ -68,7 +68,7 @@ describe "Coupons", -> queries = '?_id=' + user._id + '&apiToken=' + user.apiToken request .get(baseURL + '/coupons' + queries) - .end (res) -> + .end (err, res) -> expectCode res, 200 codes = res.text expect(codes).to.contain('code') @@ -81,7 +81,7 @@ describe "Coupons", -> queries = '?_id=' + user._id + '&apiToken=' + user.apiToken + '&limit=5' request .get(baseURL + '/coupons' + queries) - .end (res) -> + .end (err, res) -> expectCode res, 200 codes = res.text sortedCoupons = _.sortBy(coupons, 'seq') @@ -98,7 +98,7 @@ describe "Coupons", -> queries = '?_id=' + user._id + '&apiToken=' + user.apiToken + '&skip=5' request .get(baseURL + '/coupons' + queries) - .end (res) -> + .end (err, res) -> expectCode res, 200 codes = res.text sortedCoupons = _.sortBy(coupons, 'seq') @@ -121,7 +121,7 @@ describe "Coupons", -> queries = '?_id=' + user._id + '&apiToken=' + user.apiToken request .get(baseURL + '/coupons' + queries) - .end (res) -> + .end (err, res) -> expectCode res, 401 expect(res.body.err).to.equal 'You don\'t have admin access' done() @@ -156,7 +156,7 @@ describe "Coupons", -> code = coupons[0]._id request .post(baseURL + '/user/coupon/' + code) - .end (res) -> + .end (err, res) -> expectCode res, 200 gear = res.body.items.gear.owned specialGear(gear, true) @@ -168,7 +168,7 @@ describe "Coupons", -> code = coupons[0]._id request .post(baseURL + '/user/coupon/' + code) - .end (res) -> + .end (err, res) -> expectCode res, 400 expect(res.body.err).to.equal "Coupon already used" User.findById user._id, (err, _user) -> @@ -182,7 +182,7 @@ describe "Coupons", -> code = "not-a-real-coupon" request .post(baseURL + '/user/coupon/' + code) - .end (res) -> + .end (err, res) -> expectCode res, 400 expect(res.body.err).to.equal "Invalid coupon code" User.findById user._id, (err, _user) -> diff --git a/test/api-legacy/groups.coffee b/test/api-legacy/groups.coffee index 4e6a92aa76..209b14e5cd 100644 --- a/test/api-legacy/groups.coffee +++ b/test/api-legacy/groups.coffee @@ -5,7 +5,7 @@ diff = require("deep-diff") Group = require("../../website/src/models/group").model app = require("../../website/src/server") -describe "Guilds", -> +describe.skip "Guilds", -> context "updating groups", -> groupToUpdate = undefined before (done) -> @@ -13,7 +13,7 @@ describe "Guilds", -> name: "TestGroup" type: "guild" description: "notUpdatedDesc" - ).end (res) -> + ).end (err, res) -> groupToUpdate = res.body done() @@ -25,7 +25,7 @@ describe "Guilds", -> ) .set("X-API-User", tmpUser._id) .set("X-API-Key", tmpUser.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 401 expect(res.body.err).to.equal "Only the group leader can update the group!" done() @@ -35,10 +35,10 @@ describe "Guilds", -> request.post(baseURL + "/groups/" + groupToUpdate._id).send( description: "updatedDesc" ) - .end (res) -> + .end (err, res) -> expectCode res, 204 request.get(baseURL + "/groups/" + groupToUpdate._id).send() - .end (res) -> + .end (err, res) -> updatedGroup = res.body expect(updatedGroup.description).to.equal "updatedDesc" done() @@ -49,11 +49,11 @@ describe "Guilds", -> request.post(baseURL + "/groups").send( name: "TestGroupToLeave" type: "guild" - ).end (res) -> + ).end (err, res) -> guildToLeave = res.body request.post(baseURL + "/groups/" + guildToLeave._id + "/leave") .send() - .end (res) -> + .end (err, res) -> expectCode res, 204 done() @@ -63,18 +63,18 @@ describe "Guilds", -> name: "TestGroupToDeleteAfteLeave" type: "guild" privacy: "private" - ).end (res) -> + ).end (err, res) -> groupToDeleteAfterLeave = res.body async.waterfall [ (cb) -> request.post(baseURL + "/groups/" + groupToDeleteAfterLeave._id + "/leave") - .end (res) -> + .end (err, res) -> expectCode res, 204 cb() (cb) -> request.post(baseURL + "/groups/" + groupToDeleteAfterLeave._id) - .end (res) -> + .end (err, res) -> expectCode res, 404 cb() ], done @@ -86,7 +86,7 @@ describe "Guilds", -> name: "TestGroupToDeleteAfterLeave" type: "guild" privacy: "private" - ).end (res) -> + ).end (err, res) -> groupToDeleteAfterLeave = res.body async.waterfall [ (cb) -> @@ -103,7 +103,7 @@ describe "Guilds", -> (cb) -> request.post(baseURL + "/groups/" + groupToDeleteAfterLeave._id + "/leave") - .end (res) -> + .end (err, res) -> expectCode res, 204 cb() @@ -119,7 +119,7 @@ describe "Guilds", -> (cb) -> request.post(baseURL + "/groups/" + groupToDeleteAfterLeave._id) - .end (res) -> + .end (err, res) -> expectCode res, 404 cb() ], done @@ -130,7 +130,7 @@ describe "Guilds", -> request.post(baseURL + "/groups").send( name: "TestPartyToDeleteAfterLeave" type: "party" - ).end (res) -> + ).end (err, res) -> partyToDeleteAfterLeave = res.body async.waterfall [ (cb) -> @@ -147,7 +147,7 @@ describe "Guilds", -> (cb) -> request.post(baseURL + "/groups/" + partyToDeleteAfterLeave._id + "/leave") - .end (res) -> + .end (err, res) -> expectCode res, 204 cb() @@ -166,7 +166,7 @@ describe "Guilds", -> (cb) -> request.post(baseURL + "/groups/" + partyToDeleteAfterLeave._id) - .end (res) -> + .end (err, res) -> expectCode res, 404 cb() ], done @@ -179,7 +179,7 @@ describe "Guilds", -> request.post(baseURL + "/groups").send( name: "TestGuildToRemoveMember" type: "guild" - ).end (res) -> + ).end (err, res) -> guildToRemoveMember = res.body #Add members to guild async.waterfall [ @@ -200,24 +200,24 @@ describe "Guilds", -> request.post(baseURL + "/groups/" + guildToRemoveMember._id + "/join") .set("X-API-User", userToRemove._id) .set("X-API-Key", userToRemove.apiToken) - .end (res) -> + .end (err, res) -> cb() (cb) -> request.post(baseURL + "/groups/" + guildToRemoveMember._id + "/removeMember?uuid=" + guildToRemoveMember.leader) - .send().end (res) -> + .send().end (err, res) -> expectCode res, 401 cb() (cb) -> request.post(baseURL + "/groups/" + guildToRemoveMember._id + "/removeMember?uuid=" + userToRemove._id) - .send().end (res) -> + .send().end (err, res) -> expectCode res, 204 cb() (cb) -> request.get(baseURL + "/groups/" + guildToRemoveMember._id) .send() - .end (res) -> + .end (err, res) -> g = res.body userInGroup = _.find g.members, (member) -> return member._id == userToRemove._id expect(userInGroup).to.not.exist @@ -232,7 +232,7 @@ describe "Guilds", -> name: "TestPrivateGroup" type: "guild" privacy: "private" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 guild = res.body expect(guild.members.length).to.equal 1 @@ -259,7 +259,7 @@ describe "Guilds", -> it "includes user in private group member list when user is a member", (done) -> request.get(baseURL + "/groups/" + guild._id) - .end (res) -> + .end (err, res) -> g = res.body userInGroup = _.find g.members, (member) -> return member._id == user._id expect(userInGroup).to.exist @@ -268,9 +268,9 @@ describe "Guilds", -> it "excludes user from viewing private group member list when user is not a member", (done) -> request.post(baseURL + "/groups/" + guild._id + "/leave") - .end (res) -> + .end (err, res) -> request.get(baseURL + "/groups/" + guild._id) - .end (res) -> + .end (err, res) -> expect res, 404 done() @@ -293,7 +293,7 @@ describe "Guilds", -> name: "TestGuildToEmptyAndAssignLeader" type: "guild", privacy: "public" - ).end (res) -> + ).end (err, res) -> guildToEmptyAndAssignLeader = res.body #Add members to guild async.waterfall [ @@ -313,7 +313,7 @@ describe "Guilds", -> (cb) -> request.post(baseURL + "/groups/" + guildToEmptyAndAssignLeader._id + "/leave") .send() - .end (res) -> + .end (err, res) -> expectCode res, 204 cb() @@ -321,7 +321,7 @@ describe "Guilds", -> request.post(baseURL + "/groups/" + guildToEmptyAndAssignLeader._id + "/join") .set("X-API-User", userToBecomeLeader._id) .set("X-API-Key", userToBecomeLeader.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -330,7 +330,7 @@ describe "Guilds", -> .set("X-API-User", userToBecomeLeader._id) .set("X-API-Key", userToBecomeLeader.apiToken) .send() - .end (res) -> + .end (err, res) -> expectCode res, 200 g = res.body expect(g.leader._id).to.equal(userToBecomeLeader._id) @@ -352,7 +352,7 @@ describe "Guilds", -> name: "TestPublicGroup" type: "guild" privacy: "public" - ).end (res) -> + ).end (err, res) -> guild = res.body expect(guild.members.length).to.equal 1 expect(guild.leader).to.equal user._id @@ -380,13 +380,13 @@ describe "Guilds", -> before (done) -> registerNewUser -> request.post(baseURL + "/groups/" + guild._id + "/join") - .end (res)-> + .end (err, res)-> done() , true it "includes user in public group member list", (done) -> request.get(baseURL + "/groups/" + guild._id) - .end (res) -> + .end (err, res) -> g = res.body expect(g.members.length).to.equal 15 userInGroup = _.find g.members, (member) -> return member._id == user._id @@ -399,7 +399,7 @@ describe "Guilds", -> it "excludes user in public group member list", (done) -> request.get(baseURL + "/groups/" + guild._id) - .end (res) -> + .end (err, res) -> g = res.body expect(g.members.length).to.equal 15 userInGroup = _.find g.members, (member) -> return member._id == user._id diff --git a/test/api-legacy/party.coffee b/test/api-legacy/party.coffee index 2a8b54801a..3e46328991 100644 --- a/test/api-legacy/party.coffee +++ b/test/api-legacy/party.coffee @@ -16,7 +16,7 @@ describe "Party", -> request.post(baseURL + "/groups").send( name: "TestGroup" type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 group = res.body expect(group.members.length).to.equal 1 @@ -28,7 +28,7 @@ describe "Party", -> request.post(baseURL + "/groups").send( name: "TestGroup" type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 400 expect(res.body.err).to.equal "Already in a party, try refreshing." done() @@ -44,7 +44,7 @@ describe "Party", -> request.post(baseURL + "/groups").send( name: "TestGroup" type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 group = res.body expect(group.members.length).to.equal 1 @@ -55,7 +55,7 @@ describe "Party", -> it "can be found by querying for group type party", (done) -> request.get(baseURL + "/groups/").send( type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 party = _.find res.body, (g) -> return g._id == group._id expect(party._id).to.equal group._id @@ -76,7 +76,7 @@ describe "Party", -> request.post(baseURL + "/groups").send( name: "TestGroup" type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 group = res.body expect(group.members.length).to.equal 1 @@ -89,7 +89,7 @@ describe "Party", -> request.post(baseURL + "/groups/" + group._id + "/join").send() .set("X-API-User", user._id) .set("X-API-Key", user.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 401 expect(res.body.err).to.equal "Can't join a group you're not invited to." done() @@ -114,7 +114,7 @@ describe "Party", -> request.post(baseURL + "/groups/" + group._id + "/join") .set("X-API-User", tmpUser._id) .set("X-API-Key", tmpUser.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -153,7 +153,7 @@ describe "Party", -> request.post(baseURL + "/groups").send( name: "TestGroup" type: "party" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 group = res.body expect(group.members.length).to.equal 1 @@ -164,13 +164,13 @@ describe "Party", -> request.post(baseURL + '/user/tasks').send({ type: 'daily' text: 'daily one' - }).end (res) -> + }).end (err, res) -> cb() (cb) -> request.post(baseURL + '/user/tasks').send({ type: 'daily' text: 'daily two' - }).end (res) -> + }).end (err, res) -> cb() (cb) -> User.findByIdAndUpdate user._id, @@ -198,7 +198,7 @@ describe "Party", -> body: "stats.lvl": 50 } - ]).end (res) -> + ]).end (err, res) -> user = res.body expect(user.party.quest.progress.up).to.be.above 0 @@ -227,7 +227,7 @@ describe "Party", -> (cb2) -> request.post(inviteURL).send( uuids: [party[2]._id] - ).end (res)-> + ).end (err, res)-> cb2() ], cb @@ -255,7 +255,7 @@ describe "Party", -> # Start the quest async.waterfall [ (cb) -> - request.post(baseURL + "/groups/" + group._id + "/questAccept?key=vice3").end (res) -> + request.post(baseURL + "/groups/" + group._id + "/questAccept?key=vice3").end (err, res) -> expectCode res, 400 User.findByIdAndUpdate user._id, $set: @@ -263,7 +263,7 @@ describe "Party", -> , cb (_user, cb) -> - request.post(baseURL + "/groups/" + group._id + "/questAccept?key=vice3").end (res) -> + request.post(baseURL + "/groups/" + group._id + "/questAccept?key=vice3").end (err, res) -> expectCode res, 200 Group.findById group._id, cb @@ -271,8 +271,8 @@ describe "Party", -> expect(_group.quest.key).to.equal "vice3" expect(_group.quest.active).to.equal false request.post(baseURL + "/groups/" + group._id + "/questAccept").set("X-API-User", party[0]._id).set("X-API-Key", party[0].apiToken).end -> - request.post(baseURL + "/groups/" + group._id + "/questAccept").set("X-API-User", party[1]._id).set("X-API-Key", party[1].apiToken).end (res) -> - request.post(baseURL + "/groups/" + group._id + "/questReject").set("X-API-User", party[2]._id).set("X-API-Key", party[2].apiToken).end (res) -> + request.post(baseURL + "/groups/" + group._id + "/questAccept").set("X-API-User", party[1]._id).set("X-API-Key", party[1].apiToken).end (err, res) -> + request.post(baseURL + "/groups/" + group._id + "/questReject").set("X-API-User", party[2]._id).set("X-API-Key", party[2].apiToken).end (err, res) -> group = res.body expect(group.quest.active).to.equal true cb() @@ -282,12 +282,12 @@ describe "Party", -> it "Casts a spell", (done) -> mp = user.stats.mp - request.get(baseURL + "/members/" + party[0]._id).end (res) -> + request.get(baseURL + "/members/" + party[0]._id).end (err, res) -> party[0] = res.body - request.post(baseURL + "/user/class/cast/snowball?targetType=user&targetId=" + party[0]._id).end (res) -> + request.post(baseURL + "/user/class/cast/snowball?targetType=user&targetId=" + party[0]._id).end (err, res) -> #expect(res.body.stats.mp).to.be.below(mp); - request.get(baseURL + "/members/" + party[0]._id).end (res) -> + request.get(baseURL + "/members/" + party[0]._id).end (err, res) -> member = res.body expect(member.achievements.snowball).to.equal 1 expect(member.stats.buffs.snowball).to.exist @@ -295,18 +295,18 @@ describe "Party", -> expect(_.size(difference)).to.equal 2 # level up user so str is > 0 - request.put(baseURL + "/user").send("stats.lvl": 5).end (res) -> + request.put(baseURL + "/user").send("stats.lvl": 5).end (err, res) -> # Refill mana so user can cast - request.put(baseURL + "/user").send("stats.mp": 100).end (res) -> - request.post(baseURL + "/user/class/cast/valorousPresence?targetType=party").end (res) -> - request.get(baseURL + "/members/" + member._id).end (res) -> + request.put(baseURL + "/user").send("stats.mp": 100).end (err, res) -> + request.post(baseURL + "/user/class/cast/valorousPresence?targetType=party").end (err, res) -> + request.get(baseURL + "/members/" + member._id).end (err, res) -> expect(res.body.stats.buffs.str).to.be.above 0 expect(diff(res.body, member).length).to.equal 1 done() it "Doesn't include people who aren't participating", (done) -> - request.get(baseURL + "/groups/" + group._id).end (res) -> + request.get(baseURL + "/groups/" + group._id).end (err, res) -> expect(_.size(res.body.quest.members)).to.equal 3 done() @@ -325,7 +325,7 @@ describe "Party", -> done() xit "Hurts the boss", (done) -> - request.post(baseURL + "/user/batch-update").end (res) -> + request.post(baseURL + "/user/batch-update").end (err, res) -> user = res.body up = user.party.quest.progress.up expect(up).to.be.above 0 @@ -344,10 +344,10 @@ describe "Party", -> body: lastCron: moment().subtract(1, "days") } - ]).end (res) -> + ]).end (err, res) -> expect(res.body.party.quest.progress.up).to.be.above up request.post(baseURL + "/user/batch-update").end -> - request.get(baseURL + "/groups/party").end (res) -> + request.get(baseURL + "/groups/party").end (err, res) -> # Check boss damage async.waterfall [ @@ -419,7 +419,7 @@ describe "Party", -> cb() (cb) -> - request.post(baseURL + "/user/batch-update").end (res) -> + request.post(baseURL + "/user/batch-update").end (err, res) -> cb null, res.body (_user, cb) -> diff --git a/test/api-legacy/pushNotifications.coffee b/test/api-legacy/pushNotifications.coffee index d7c23ce47c..803e3fee0f 100644 --- a/test/api-legacy/pushNotifications.coffee +++ b/test/api-legacy/pushNotifications.coffee @@ -15,7 +15,7 @@ describe "Push-Notifications", -> it "Registers a DeviceID", (done) -> request.post(baseURL + "/user/pushDevice").send( { regId: "123123", type: "android"} - ).end (res) -> + ).end (err, res) -> expectCode res, 200 User.findOne diff --git a/test/api-legacy/score.coffee b/test/api-legacy/score.coffee index a3b1b41826..57e455f068 100644 --- a/test/api-legacy/score.coffee +++ b/test/api-legacy/score.coffee @@ -11,9 +11,9 @@ describe "Score", -> request.post(baseURL + "/user/tasks/withUp/up").send( type: "todo" text: "withUp" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/withUp").end (res) -> + request.get(baseURL + "/user/tasks/withUp").end (err, res) -> upTodo = res.body expect(upTodo.completed).to.equal true done() @@ -22,9 +22,9 @@ describe "Score", -> request.post(baseURL + "/user/tasks/withDown/down").send( type: "todo" text: "withDown" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/withDown").end (res) -> + request.get(baseURL + "/user/tasks/withDown").end (err, res) -> downTodo = res.body expect(downTodo.completed).to.equal false done() @@ -34,9 +34,9 @@ describe "Score", -> type: "todo" text: "withUpWithComplete" completed: false - ).end (res) -> + ).end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/withUpWithComplete").end (res) -> + request.get(baseURL + "/user/tasks/withUpWithComplete").end (err, res) -> upTodo = res.body expect(upTodo.completed).to.equal true done() @@ -46,9 +46,9 @@ describe "Score", -> type: "todo" text: "withDownWithUncomplete" completed: true - ).end (res) -> + ).end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/withDownWithUncomplete").end (res) -> + request.get(baseURL + "/user/tasks/withDownWithUncomplete").end (err, res) -> downTodo = res.body expect(downTodo.completed).to.equal false done() @@ -58,13 +58,13 @@ describe "Score", -> request.post(baseURL + "/user/tasks").send( type: "todo" text: "Sample Todo" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 unCompletedTodo = res.body expect(unCompletedTodo.completed).to.equal false - request.post(baseURL + "/user/tasks/"+unCompletedTodo._id+"/up").end (res) -> + request.post(baseURL + "/user/tasks/"+unCompletedTodo._id+"/up").end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/"+unCompletedTodo._id).end (res) -> + request.get(baseURL + "/user/tasks/"+unCompletedTodo._id).end (err, res) -> unCompletedTodo = res.body expect(unCompletedTodo.completed).to.equal true done() @@ -74,13 +74,13 @@ describe "Score", -> type: "todo" text: "Sample Todo" completed: true - ).end (res) -> + ).end (err, res) -> expectCode res, 200 completedTodo = res.body expect(completedTodo.completed).to.equal true - request.post(baseURL + "/user/tasks/"+completedTodo._id+"/down").end (res) -> + request.post(baseURL + "/user/tasks/"+completedTodo._id+"/down").end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/"+completedTodo._id).end (res) -> + request.get(baseURL + "/user/tasks/"+completedTodo._id).end (err, res) -> completedTodo = res.body expect(completedTodo.completed).to.equal false done() @@ -91,9 +91,9 @@ describe "Score", -> type: "habit" text: "testTitle" completed: true - ).end (res) -> + ).end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/habitWithUp").end (res) -> + request.get(baseURL + "/user/tasks/habitWithUp").end (err, res) -> upHabit = res.body expect(upHabit.value).to.be.at.least(1) expect(upHabit.type).to.equal("habit") @@ -105,9 +105,9 @@ describe "Score", -> type: "habit" text: "testTitle" completed: true - ).end (res) -> + ).end (err, res) -> expectCode res, 200 - request.get(baseURL + "/user/tasks/habitWithDown").end (res) -> + request.get(baseURL + "/user/tasks/habitWithDown").end (err, res) -> downHabit = res.body expect(downHabit.value).to.have.at.most(-1) expect(downHabit.type).to.equal("habit") diff --git a/test/api-legacy/todos.coffee b/test/api-legacy/todos.coffee index 7b57378bf4..0485266cea 100644 --- a/test/api-legacy/todos.coffee +++ b/test/api-legacy/todos.coffee @@ -31,7 +31,7 @@ describe "Todos", -> body: type: "todo" } - ]).end (res) -> + ]).end (err, res) -> expectCode res, 200 # Expect number of todos to be 3 greater than the number the user started with expect(_.size(res.body.todos)).to.equal numTasks + 3 @@ -56,7 +56,7 @@ describe "Todos", -> direction: "up" id: res.body.todos[2].id } - ]).end (res) -> + ]).end (err, res) -> expectCode res, 200 expect(_.size(res.body.todos)).to.equal numTasks request.post(baseURL + "/user/batch-update?_v=997").send([ @@ -76,7 +76,7 @@ describe "Todos", -> body: dateCompleted: moment().subtract(4, "days") } - ]).end (res) -> + ]).end (err, res) -> # Expect todos to be 2 less than the total count expect(_.size(res.body.todos)).to.equal numTasks - 2 done() @@ -89,7 +89,7 @@ describe "Todos", -> request.post(baseURL + "/user/tasks").send( type: "todo" text: "Sample Todo" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 todo = res.body expect(todo.text).to.equal "Sample Todo" @@ -110,10 +110,10 @@ describe "Todos", -> } request.post(baseURL + "/user/tasks").send( original_todo - ).end (res) -> + ).end (err, res) -> request.post(baseURL + "/user/tasks").send( duplicate_id_todo - ).end (res) -> + ).end (err, res) -> expectCode res, 409 expect(res.body.err).to.eql('A task with that ID already exists.') done() @@ -122,7 +122,7 @@ describe "Todos", -> it "Does not update id of todo", (done) -> request.put(baseURL + "/user/tasks/" + todo.id).send( id: "a-new-id" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 updateTodo = res.body expect(updateTodo.id).to.equal todo.id @@ -131,7 +131,7 @@ describe "Todos", -> it "Does not update type of todo", (done) -> request.put(baseURL + "/user/tasks/" + todo.id).send( type: "habit" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 updateTodo = res.body expect(updateTodo.type).to.equal todo.type @@ -144,7 +144,7 @@ describe "Todos", -> priority: 1.5 value: 5 notes: "Some notes" - ).end (res) -> + ).end (err, res) -> expectCode res, 200 todo = res.body expect(todo.text).to.equal "Changed Title" @@ -157,7 +157,7 @@ describe "Todos", -> describe "Deleting todos", -> it "Does delete todo", (done) -> request.del(baseURL + "/user/tasks/" + todo.id).send( - ).end (res) -> + ).end (err, res) -> expectCode res, 200 body = res.body expect(body).to.be.empty @@ -165,7 +165,7 @@ describe "Todos", -> it "Does not delete already deleted todo", (done) -> request.del(baseURL + "/user/tasks/" + todo.id).send( - ).end (res) -> + ).end (err, res) -> expectCode res, 404 body = res.body expect(body.err).to.equal "Task not found." @@ -178,7 +178,7 @@ describe "Todos", -> priority: 1 value: 4 notes: "Other notes" - ).end (res) -> + ).end (err, res) -> expectCode res, 404 body = res.body expect(body.err).to.equal "Task not found." diff --git a/test/api-legacy/users.coffee b/test/api-legacy/users.coffee index e465d1f3d5..966a6134a2 100644 --- a/test/api-legacy/users.coffee +++ b/test/api-legacy/users.coffee @@ -22,10 +22,10 @@ describe "Users", -> request.del(baseURL + "/user") .set("X-API-User", userToDelete._id) .set("X-API-Key", userToDelete.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 request.get(baseURL + "/user/" + userToDelete._id) - .end (res) -> + .end (err, res) -> expectCode res, 404 cb() @@ -56,7 +56,7 @@ describe "Users", -> ) .set("X-API-User", userToDelete._id) .set("X-API-Key", userToDelete.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 guildToHaveNewLeader = res.body expect(guildToHaveNewLeader.leader).to.eql(userToDelete._id) @@ -66,7 +66,7 @@ describe "Users", -> inviteURL = baseURL + "/groups/" + guildToHaveNewLeader._id + "/invite" request.post(inviteURL) .send( uuids: [userToBecomeLeader._id]) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -74,7 +74,7 @@ describe "Users", -> request.post(baseURL + "/groups/" + guildToHaveNewLeader._id + "/join") .set("X-API-User", userToBecomeLeader._id) .set("X-API-Key", userToBecomeLeader.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -82,7 +82,7 @@ describe "Users", -> request.del(baseURL + "/user") .set("X-API-User", userToDelete._id) .set("X-API-Key", userToDelete.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -90,7 +90,7 @@ describe "Users", -> request.get(baseURL + "/groups/" + guildToHaveNewLeader._id) .set("X-API-User", userToBecomeLeader._id) .set("X-API-Key", userToBecomeLeader.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 g = res.body userInGroup = _.find(g.members, (member) -> return member._id == userToDelete._id; ) @@ -114,7 +114,7 @@ describe "Users", -> name: "TestPrivateGroup" type: "party" ) - .end (res) -> + .end (err, res) -> expectCode res, 200 party = res.body cb() @@ -124,7 +124,7 @@ describe "Users", -> name: "TestPrivateGroup" type: "guild" ) - .end (res) -> + .end (err, res) -> expectCode res, 200 guild = res.body cb() @@ -143,7 +143,7 @@ describe "Users", -> inviteURL = baseURL + "/groups/" + party._id + "/invite" request.post(inviteURL) .send( uuids: [userToDelete._id]) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -151,7 +151,7 @@ describe "Users", -> inviteURL = baseURL + "/groups/" + guild._id + "/invite" request.post(inviteURL) .send( uuids: [userToDelete._id]) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -159,7 +159,7 @@ describe "Users", -> request.post(baseURL + "/groups/" + party._id + "/join") .set("X-API-User", userToDelete._id) .set("X-API-Key", userToDelete.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -167,7 +167,7 @@ describe "Users", -> request.post(baseURL + "/groups/" + guild._id + "/join") .set("X-API-User", userToDelete._id) .set("X-API-Key", userToDelete.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -175,13 +175,13 @@ describe "Users", -> request.del(baseURL + "/user") .set("X-API-User", userToDelete._id) .set("X-API-Key", userToDelete.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() (cb) -> request.get(baseURL + "/groups/" + party._id) - .end (res) -> + .end (err, res) -> expectCode res, 200 g = res.body userInGroup = _.find(g.members, (member) -> return member._id == userToDelete._id; ) @@ -190,7 +190,7 @@ describe "Users", -> (cb) -> request.get(baseURL + "/groups/" + guild._id) - .end (res) -> + .end (err, res) -> expectCode res, 200 g = res.body userInGroup = _.find(g.members, (member) -> return member._id == userToDelete._id; ); @@ -211,7 +211,7 @@ describe "Users", -> inviteURL = baseURL + "/groups/" + party._id + "/invite" request.post(inviteURL) .send( uuids: [userToDeleteInvites._id]) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -219,7 +219,7 @@ describe "Users", -> inviteURL = baseURL + "/groups/" + guild._id + "/invite" request.post(inviteURL) .send( uuids: [userToDeleteInvites._id]) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() @@ -227,13 +227,13 @@ describe "Users", -> request.del(baseURL + "/user") .set("X-API-User", userToDeleteInvites._id) .set("X-API-Key", userToDeleteInvites.apiToken) - .end (res) -> + .end (err, res) -> expectCode res, 200 cb() (cb) -> request.get(baseURL + "/groups/" + party._id) - .end (res) -> + .end (err, res) -> expectCode res, 200 g = res.body userInviteForGroup = _.find(g.invites, (invite) -> return invite._id == userToDeleteInvites._id; ) @@ -242,7 +242,7 @@ describe "Users", -> (cb) -> request.get(baseURL + "/groups/" + guild._id) - .end (res) -> + .end (err, res) -> expectCode res, 200 g = res.body userInviteForGroup = _.find(g.invites, (invite) -> return invite._id == userToDeleteInvites._id; ) diff --git a/test/mocha.opts b/test/mocha.opts index 03db728cec..01d9dcfcd7 100644 --- a/test/mocha.opts +++ b/test/mocha.opts @@ -4,5 +4,7 @@ --check-leaks --growl --debug +--compilers coffee:coffee-script --globals io +--require test/api-legacy/api-helper --require ./test/helpers/globals.helper