From a0de2dab4938a315c694c236a0d784ec2b1b489f Mon Sep 17 00:00:00 2001 From: Sabe Jones Date: Thu, 12 May 2022 14:56:05 -0500 Subject: [PATCH] fix(tasks): don't send delta around as an array (#13967) Co-authored-by: SabreCat --- website/common/script/ops/scoreTask.js | 2 +- website/server/libs/tasks/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/website/common/script/ops/scoreTask.js b/website/common/script/ops/scoreTask.js index 5a46d01ada..335b3a85bf 100644 --- a/website/common/script/ops/scoreTask.js +++ b/website/common/script/ops/scoreTask.js @@ -362,5 +362,5 @@ export default function scoreTask (options = {}, req = {}, analytics) { checkOnboardingStatus(user, req, analytics); } - return [delta]; + return delta; } diff --git a/website/server/libs/tasks/index.js b/website/server/libs/tasks/index.js index 2e33d1da9a..48a97ffa15 100644 --- a/website/server/libs/tasks/index.js +++ b/website/server/libs/tasks/index.js @@ -404,7 +404,7 @@ async function scoreTask (user, task, direction, req, res) { const wasCompleted = task.completed; const firstTask = !user.achievements.completedTask; - const [delta] = shared.ops.scoreTask({ task, user, direction }, req, res.analytics); + const delta = shared.ops.scoreTask({ task, user, direction }, req, res.analytics); // Drop system (don't run on the client, // as it would only be discarded since ops are sent to the API, not the results) if (direction === 'up' && !firstTask) shared.fns.randomDrop(user, { task, delta }, req, res.analytics);