mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-19 15:48:04 +01:00
[#1676] show memberCount on challenges.list. will follow up on ticket for reasoning
This commit is contained in:
@@ -71,13 +71,14 @@ api.list = function(req, res) {
|
|||||||
{group: 'habitrpg'}
|
{group: 'habitrpg'}
|
||||||
]
|
]
|
||||||
})
|
})
|
||||||
.select('name description memberCount group members')
|
.select('name description group members')
|
||||||
.populate('group', '_id name')
|
.populate('group', '_id name')
|
||||||
.exec(function(err, challenges){
|
.exec(function(err, challenges){
|
||||||
if (err) return res.json(500,{err:err});
|
if (err) return res.json(500,{err:err});
|
||||||
_.each(challenges, function(c){
|
_.each(challenges, function(c){
|
||||||
c._isMember = !!~c.members.indexOf(user._id);
|
c._isMember = !!~c.members.indexOf(user._id);
|
||||||
c.members = [];
|
c.memberCount = _.size(c.members);
|
||||||
|
c.members = undefined;
|
||||||
})
|
})
|
||||||
res.json(challenges);
|
res.json(challenges);
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ ChallengeSchema.pre('save', function(next){
|
|||||||
|
|
||||||
ChallengeSchema.methods.toJSON = function(){
|
ChallengeSchema.methods.toJSON = function(){
|
||||||
var doc = this.toObject();
|
var doc = this.toObject();
|
||||||
doc.memberCount = _.size(doc.members); // @see pre('save') comment above
|
doc.memberCount = doc.members ? _.size(doc.members) : doc.memberCount; // @see pre('save') comment above
|
||||||
doc._isMember = this._isMember;
|
doc._isMember = this._isMember;
|
||||||
return doc;
|
return doc;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user