krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Analytics: track generic events through the server (#12735)"

Browse Source 
This reverts commit 48dbe547c0.
This commit is contained in:
Sabe Jones
2020-11-05 15:44:30 -06:00
parent b97d514c68
commit 9d6fb2ca26
16 changed files with 17 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
website/server/libs/analyticsService.js
View File

@@ -174,7 +174,7 @@ function _formatDataForAmplitude (data) {
return ampData;
}
function _sendDataToAmplitude (eventType, data, loggerOnly) {
function _sendDataToAmplitude (eventType, data) {
const amplitudeData = _formatDataForAmplitude(data);
amplitudeData.event_type = eventType;
@@ -183,8 +183,6 @@ function _sendDataToAmplitude (eventType, data, loggerOnly) {
logger.info('Amplitude Event', amplitudeData);
}
if (loggerOnly) return Promise.resolve(null);
return amplitude
.track(amplitudeData)
.catch(err => logger.error(err, 'Error while sending data to Amplitude.'));
@@ -314,9 +312,9 @@ function _setOnce (dataToSetOnce, uuid) {
}
// There's no error handling directly here because it's handled inside _sendDataTo{Amplitude|Google}
async function track (eventType, data, loggerOnly = false) {
async function track (eventType, data) {
const promises = [
_sendDataToAmplitude(eventType, data, loggerOnly),
_sendDataToAmplitude(eventType, data),
_sendDataToGoogle(eventType, data),
];
if (data.user && data.user.registeredThrough) {

2
website/server/libs/cron.js
View File

@@ -225,7 +225,7 @@ function trackCronAnalytics (analytics, user, _progress, options) {
user,
questName: user.party.quest.key,
headers: options.headers,
}, true);
});
}
}