krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 22:57:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): GET members

Browse Source
This commit is contained in:
SabreCat
2023-08-02 16:02:53 -05:00
parent 13c21139dd
commit 9d61bd724a
3 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
test/api/v3/integration/groups/GET-groups_groupId_members.test.js
View File

@@ -1,5 +1,6 @@
import { v4 as generateUUID } from 'uuid'; import { v4 as generateUUID } from 'uuid';
import { import {
createAndPopulateGroup,
generateUser, generateUser,
generateGroup, generateGroup,
translate as t, translate as t,
@@ -75,7 +76,14 @@ describe('GET /groups/:groupId/members', () => {
}); });
it('req.query.includeAllPublicFields === true works with guilds', async () => { it('req.query.includeAllPublicFields === true works with guilds', async () => {
const group = await generateGroup(user, { type: 'guild', name: generateUUID() }); const { group, groupLeader: user } = await createAndPopulateGroup({
type: 'guild',
privacy: 'private',
name: generateUUID(),
upgradeToGroupPlan: true,
members: 1,
});
const [memberRes] = await user.get(`/groups/${group._id}/members?includeAllPublicFields=true`); const [memberRes] = await user.get(`/groups/${group._id}/members?includeAllPublicFields=true`);
expect(memberRes).to.have.all.keys([ // works as: object has all and only these keys expect(memberRes).to.have.all.keys([ // works as: object has all and only these keys
@@ -206,20 +214,20 @@ describe('GET /groups/:groupId/members', () => {
it('supports using req.query.lastId to get more members', async function test () { it('supports using req.query.lastId to get more members', async function test () {
this.timeout(30000); // @TODO: times out after 8 seconds this.timeout(30000); // @TODO: times out after 8 seconds
const leader = await generateUser({ balance: 4 }); const { group, groupLeader: leader, members: generatedUsers } = await createAndPopulateGroup({
const group = await generateGroup(leader, { type: 'guild', privacy: 'public', name: generateUUID() }); type: 'guild',
privacy: 'private',
name: generateUUID(),
upgradeToGroupPlan: true,
leaderDetails: { balance: 4 },
members: 57,
});
const usersToGenerate = [];
for (let i = 0; i < 57; i += 1) {
usersToGenerate.push(generateUser({ guilds: [group._id] }));
}
// Group has 59 members (1 is the leader)
const generatedUsers = await Promise.all(usersToGenerate);
const expectedIds = [leader._id].concat(generatedUsers.map(generatedUser => generatedUser._id)); const expectedIds = [leader._id].concat(generatedUsers.map(generatedUser => generatedUser._id));
const res = await user.get(`/groups/${group._id}/members`); const res = await leader.get(`/groups/${group._id}/members`);
expect(res.length).to.equal(30); expect(res.length).to.equal(30);
const res2 = await user.get(`/groups/${group._id}/members?lastId=${res[res.length - 1]._id}`); const res2 = await leader.get(`/groups/${group._id}/members?lastId=${res[res.length - 1]._id}`);
expect(res2.length).to.equal(28); expect(res2.length).to.equal(28);
const resIds = res.concat(res2).map(member => member._id); const resIds = res.concat(res2).map(member => member._id);

2
test/api/v3/integration/groups/GET-groups_id.test.js
View File

@@ -290,7 +290,7 @@ describe('GET /groups/:id', () => {
beforeEach(async () => { beforeEach(async () => {
[admin] = members; [admin] = members;
await admin.update({ permissions: { moderator: true }}); await admin.update({ permissions: { moderator: true } });
}); });
it('includes all messages', async () => { it('includes all messages', async () => {

2
website/server/models/user/schema.js
View File

@@ -532,7 +532,7 @@ export default new Schema({
automaticAllocation: Boolean, automaticAllocation: Boolean,
allocationMode: { $type: String, enum: ['flat', 'classbased', 'taskbased'], default: 'flat' }, allocationMode: { $type: String, enum: ['flat', 'classbased', 'taskbased'], default: 'flat' },
autoEquip: { $type: Boolean, default: true }, autoEquip: { $type: Boolean, default: true },
costume: Boolean, costume: { $type: Boolean, default: false },
dateFormat: { $type: String, enum: ['MM/dd/yyyy', 'dd/MM/yyyy', 'yyyy/MM/dd'], default: 'MM/dd/yyyy' }, dateFormat: { $type: String, enum: ['MM/dd/yyyy', 'dd/MM/yyyy', 'yyyy/MM/dd'], default: 'MM/dd/yyyy' },
sleep: { $type: Boolean, default: false }, sleep: { $type: Boolean, default: false },
stickyHeader: { $type: Boolean, default: true }, stickyHeader: { $type: Boolean, default: true },