Miscellaneous lint fixes: move watch & mounted properties; apply automatic fixes (#12791)

* commit lint's automatic fixes

* move watch and mounted properties as advised in lint warnings

website/client/src/components/challenges/challengeDetail.vue

@@ -384,16 +384,6 @@ export default {
       memberResults: [],
     };
   },
-  watch: {
-    'challenge.name': {
-      handler (newVal) {
-        this.$store.dispatch('common:setTitle', {
-          section: this.$t('challenge'),
-          subSection: newVal.name,
-        });
-      },
-    },
-  },
   computed: {
     ...mapState({ user: 'user.data' }),
     isMember () {
@@ -410,6 +400,16 @@ export default {
       return !this.isMember;
     },
   },
+  watch: {
+    'challenge.name': {
+      handler (newVal) {
+        this.$store.dispatch('common:setTitle', {
+          section: this.$t('challenge'),
+          subSection: newVal.name,
+        });
+      },
+    },
+  },
   mounted () {
     if (!this.searchId) this.searchId = this.challengeId;
     if (!this.challenge._id) this.loadChallenge();

website/client/src/components/challenges/sidebar.vue

@@ -56,8 +56,9 @@
           </div>
         </div>
       </filter-group>
-      <filter-group :title="$t('membership')"
+      <filter-group
         v-if="$route.name !== 'findChallenges'"
+        :title="$t('membership')"
         class="form-group"
       >
         <div

website/client/src/components/inventory/items/index.vue

@@ -496,17 +496,17 @@ export default {
       return this.groups.some(g => g.selected);
     },
   },
+  watch: {
+    searchText: throttle(function throttleSearch () {
+      this.searchTextThrottled = this.searchText.toLowerCase();
+    }, 250),
+  },
   mounted () {
     this.$store.dispatch('common:setTitle', {
       subSection: this.$t('items'),
       section: this.$t('inventory'),
     });
   },
-  watch: {
-    searchText: throttle(function throttleSearch () {
-      this.searchTextThrottled = this.searchText.toLowerCase();
-    }, 250),
-  },
   methods: {
     userHasPet (potionKey, eggKey) {
       const animalKey = `${eggKey}-${potionKey}`;

website/client/src/components/inventory/stable/index.vue

@@ -645,12 +645,6 @@ export default {
       return Object.values(this.viewOptions).some(g => g.selected);
     },
   },
-  mounted () {
-    this.$store.dispatch('common:setTitle', {
-      subSection: this.$t('stable'),
-      section: this.$t('inventory'),
-    });
-  },
   watch: {
     searchText: _throttle(function throttleSearch () {
       const search = this.searchText.toLowerCase();
@@ -662,6 +656,12 @@ export default {
       },
     },
   },
+  mounted () {
+    this.$store.dispatch('common:setTitle', {
+      subSection: this.$t('stable'),
+      section: this.$t('inventory'),
+    });
+  },
   methods: {
     setShowMore (key) {
       this.$_openedItemRows_toggleByType(key, !this.$_openedItemRows_isToggled(key));

website/client/src/components/shops/market/filter.vue

@@ -1,37 +1,38 @@
 <template>
   <filter-sidebar>
     <filter-group>
-      <checkbox :checked.sync="viewOptionEntry.selected"
+      <checkbox
-                :id="`category-${viewOptionKey}`"
+        v-for="(viewOptionEntry, viewOptionKey) in viewOptions"
-                :key="viewOptionKey"
+        :id="`category-${viewOptionKey}`"
-                :text="viewOptionEntry.text"
+        :key="viewOptionKey"
-                v-for="(viewOptionEntry, viewOptionKey) in viewOptions"
+        :checked.sync="viewOptionEntry.selected"
+        :text="viewOptionEntry.text"
       />
     </filter-group>
     <div class="form-group clearfix">
       <h3
-          class="float-left"
+        v-once
-          v-once
+        class="float-left"
       >
         {{ $t('hideLocked') }}
       </h3>
       <toggle-switch
-          @change="$emit('update:hideLocked', $event)"
+        v-model="lockedChecked"
-          class="float-right"
+        class="float-right"
-          v-model="lockedChecked"
+        @change="$emit('update:hideLocked', $event)"
       />
     </div>
     <div class="form-group clearfix">
       <h3
-          class="float-left"
+        v-once
-          v-once
+        class="float-left"
       >
         {{ $t('hidePinned') }}
       </h3>
       <toggle-switch
-          @change="$emit('update:hidePinned', $event)"
+        v-model="pinnedChecked"
-          class="float-right"
+        class="float-right"
-          v-model="pinnedChecked"
+        @change="$emit('update:hidePinned', $event)"
       />
     </div>
   </filter-sidebar>

website/client/src/components/shops/quests/index.vue

@@ -123,12 +123,12 @@
         <div class="float-right">
           <span class="dropdown-label">{{ $t('sortBy') }}</span>
           <select-translated-array
-              :right="true"
+            :right="true"
-              :value="selectedSortItemsBy"
+            :value="selectedSortItemsBy"
-              :items="sortItemsBy"
+            :items="sortItemsBy"
-              :inline-dropdown="false"
+            :inline-dropdown="false"
-              class="inline"
+            class="inline"
-              @select="selectedSortItemsBy = $event"
+            @select="selectedSortItemsBy = $event"
           />
         </div>
       </div>

website/client/src/components/shops/timeTravelers/index.vue

@@ -74,12 +74,12 @@
         <div class="float-right">
           <span class="dropdown-label">{{ $t('sortBy') }}</span>
           <select-translated-array
-              :right="true"
+            :right="true"
-              :value="selectedSortItemsBy"
+            :value="selectedSortItemsBy"
-              :items="sortItemsBy"
+            :items="sortItemsBy"
-              :inline-dropdown="false"
+            :inline-dropdown="false"
-              class="inline"
+            class="inline"
-              @select="selectedSortItemsBy = $event"
+            @select="selectedSortItemsBy = $event"
           />
         </div>
       </div>

website/client/src/components/tasks/user.vue

@@ -491,16 +491,16 @@ export default {
       return tagsByType;
     },
   },
-  mounted () {
-    this.$store.dispatch('common:setTitle', {
-      section: this.$t('tasks'),
-    });
-  },
   watch: {
     searchText: throttle(function throttleSearch () {
       this.searchTextThrottled = this.searchText.toLowerCase();
     }, 250),
   },
+  mounted () {
+    this.$store.dispatch('common:setTitle', {
+      section: this.$t('tasks'),
+    });
+  },
   methods: {
     ...mapActions({ setUser: 'user:set' }),
     checkMouseOver: throttle(function throttleSearch () {

website/client/src/components/ui/filterDropdown.vue

@@ -1,17 +1,19 @@
 <template>
   <span>
     <span class="dropdown-label">{{ label }}</span>
-    <select-list :items="items"
+    <select-list
-                 :value="selectedItem"
+      :items="items"
-                 class="array-select inline"
+      :value="selectedItem"
-                 :right="true"
+      class="array-select inline"
-                 key-prop="id"
+      :right="true"
-                 :hide-icon="false"
+      key-prop="id"
-                 :inline-dropdown="false"
+      :hide-icon="false"
-                 @select="selectItem($event)">
+      :inline-dropdown="false"
+      @select="selectItem($event)"
+    >
       <template v-slot:item="{ item }">
         <span :class="{'dropdown-icon-item': withIcon}">
-           <slot
+          <slot
             name="item"
             :item="item"
           ></slot>