Upgrade lodash to v4 and lint more files (#8495)

* common: import lodash modules separately

* remove test/content from .eslintignore, fix with eslint --fix content/index

* lint test/content

* lint content/index except for lodash methods

* upgrade server/models

* upgrade server/middlewares and server/libs

* port server/controllers/top-level

* port server/controllers/api-v3

* port views and tests

* client old port lodash and _(, missing _.

* upgrade client-old

* port common/script (root level files only)

* port common/script/fns

* port common/libs

* port common/script/ops

* port common/script/content and common/script/libs/shops.js

* misc fixes

* misc fixes

* misc fixes

* more tests fixes

* fix payments test stubbing, down to 2 failing tests

* remove more instances of lodash wrapping

* fix bug where toObject does not clone object

* fix tests

* upgrade migration or add lodash 4 note

* update shrinkwrap

* fix linting

* upgrade eslint-config-habitrpg

* update shrinkwrap

* recompile shrinkwrap
This commit is contained in:
Matteo Pagliazzi
2017-03-01 17:10:48 +01:00
committed by GitHub
parent ef02e59590
commit 98c019a0b6
150 changed files with 4996 additions and 1533 deletions

View File

@@ -1,5 +1,5 @@
import { v4 as uuid } from 'uuid';
import _ from 'lodash';
import defaults from 'lodash/defaults';
import moment from 'moment';
// Even though Mongoose handles task defaults, we want to make sure defaults are set on the client-side before
@@ -15,7 +15,7 @@ module.exports = function taskDefaults (task = {}) {
}
let defaultId = uuid();
let defaults = {
let defaultTaskObj = {
_id: defaultId,
text: task._id || defaultId,
notes: '',
@@ -31,16 +31,16 @@ module.exports = function taskDefaults (task = {}) {
updatedAt: new Date(),
};
_.defaults(task, defaults);
defaults(task, defaultTaskObj);
if (task.type === 'habit' || task.type === 'daily') {
_.defaults(task, {
defaults(task, {
history: [],
});
}
if (task.type === 'todo' || task.type === 'daily') {
_.defaults(task, {
defaults(task, {
completed: false,
collapseChecklist: false,
checklist: [],
@@ -48,7 +48,7 @@ module.exports = function taskDefaults (task = {}) {
}
if (task.type === 'habit') {
_.defaults(task, {
defaults(task, {
up: true,
down: true,
frequency: 'daily',
@@ -58,7 +58,7 @@ module.exports = function taskDefaults (task = {}) {
}
if (task.type === 'daily') {
_.defaults(task, {
defaults(task, {
streak: 0,
repeat: {
m: true,