krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-15 05:37:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): Set platform and agent to Unknown if headers are not passed in

Browse Source
This commit is contained in:
Blade Barringer
2016-08-14 23:07:37 -05:00
parent 02545ae439
commit 977bafd2d1
2 changed files with 48 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
website/server/libs/analyticsService.js
View File

@@ -89,6 +89,10 @@ let _formatUserData = (user) => {
};
let _formatPlatformForAmplitude = (platform) => {
if (!platform) {
return 'Unknown';
}
if (platform in PLATFORM_MAP) {
return PLATFORM_MAP[platform];
}
@@ -97,6 +101,10 @@ let _formatPlatformForAmplitude = (platform) => {
};
let _formatUserAgentForAmplitude = (platform, agentString) => {
if (!agentString) {
return 'Unknown';
}
let agent = useragent.lookup(agentString).toJSON();
let formattedAgent = {};
if (platform === 'iOS' || platform === 'Android') {
@@ -115,8 +123,8 @@ let _formatUserAgentForAmplitude = (platform, agentString) => {
let _formatDataForAmplitude = (data) => {
let event_properties = omit(data, AMPLITUDE_PROPERTIES_TO_SCRUB);
let platform = _formatPlatformForAmplitude(data.headers['x-client']);
let agent = _formatUserAgentForAmplitude(platform, data.headers['user-agent']);
let platform = _formatPlatformForAmplitude(data.headers && data.headers['x-client']);
let agent = _formatUserAgentForAmplitude(platform, data.headers && data.headers['user-agent']);
let ampData = {
user_id: data.uuid || 'no-user-id-was-provided',
platform,