krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 14:17:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feature: adding hp notification for boss damage" (#8340)

Browse Source
This commit is contained in:
Alys
2016-12-31 17:31:25 +10:00
committed by GitHub
parent fe7850d10f
commit 91f5c47d9d
6 changed files with 7 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
test/api/v3/unit/models/group.test.js
View File

@@ -219,37 +219,6 @@ describe('Group Model', () => {
expect(updatedUndecidedMember.stats.hp).to.eql(50);
});
it('doesn\'t notify the user when the boss damage is 0', async () => {
progress.down = 0;
await Group.processQuestProgress(participatingMember, progress);
let updatedLeader = await User.findById(questLeader._id);
expect(updatedLeader.stats.hp).to.eql(50);
expect(updatedLeader.notifications.length).to.eql(0);
});
it('notifies user of boss damage', async () => {
await Group.processQuestProgress(participatingMember, progress);
let updatedLeader = await User.findById(questLeader._id);
expect(updatedLeader.stats.hp).to.eql(42.5);
expect(updatedLeader.notifications[0].type).to.eql('BOSS_DAMAGE');
expect(updatedLeader.notifications[0].data).to.eql({damageTaken: -7.5});
});
it('combines boss damage notifications across multiple updates', async () => {
await Group.processQuestProgress(participatingMember, progress);
await Group.processQuestProgress(participatingMember, progress);
let updatedLeader = await User.findById(participatingMember._id);
expect(updatedLeader.stats.hp).to.eql(35);
expect(updatedLeader.notifications[0].type).to.eql('BOSS_DAMAGE');
expect(updatedLeader.notifications[0].data).to.eql({damageTaken: -15});
});
it('applies damage only to participating members of party even under buggy conditions', async () => {
// stops unfair damage from mbugs like https://github.com/HabitRPG/habitrpg/issues/7653
party.quest.members = {