mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-18 23:27:26 +01:00
Made incorrect username and password show the same error, for security purposes.
This commit is contained in:
@@ -108,14 +108,14 @@ api.loginLocal = function(req, res, next) {
|
|||||||
if (!(username && password)) return res.json(401, {err:'Missing :username or :password in request body, please provide both'});
|
if (!(username && password)) return res.json(401, {err:'Missing :username or :password in request body, please provide both'});
|
||||||
User.findOne({'auth.local.username': username}, function(err, user){
|
User.findOne({'auth.local.username': username}, function(err, user){
|
||||||
if (err) return next(err);
|
if (err) return next(err);
|
||||||
if (!user) return res.json(401, {err:"Username '" + username + "' not found. Usernames are case-sensitive, click 'Forgot Password' if you can't remember the capitalization."});
|
if (!user) return res.json(401, {err:"Username or password incorrect. Click 'Forgot Password' for help with either. (Note: usernames are case-sensitive)"});
|
||||||
// We needed the whole user object first so we can get his salt to encrypt password comparison
|
// We needed the whole user object first so we can get his salt to encrypt password comparison
|
||||||
User.findOne({
|
User.findOne({
|
||||||
'auth.local.username': username,
|
'auth.local.username': username,
|
||||||
'auth.local.hashed_password': utils.encryptPassword(password, user.auth.local.salt)
|
'auth.local.hashed_password': utils.encryptPassword(password, user.auth.local.salt)
|
||||||
}, function(err, user){
|
}, function(err, user){
|
||||||
if (err) return next(err);
|
if (err) return next(err);
|
||||||
if (!user) return res.json(401,{err:'Incorrect password'});
|
if (!user) return res.json(401,{err:"Username or password incorrect. Click 'Forgot Password' for help with either. (Note: usernames are case-sensitive)"});
|
||||||
res.json({id: user._id,token: user.apiToken});
|
res.json({id: user._id,token: user.apiToken});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user