krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 23:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor clone challenges PR

Browse Source
This commit is contained in:
Blade Barringer
2015-06-19 20:49:24 -05:00
parent deff0d4da2
commit 86f18e9a5a
5 changed files with 455 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

116
test/spec/controllers/challengesCtrlSpec.js
View File

@@ -184,60 +184,78 @@ describe('Challenges Controller', function() {
});
describe('clone', function() {
it('Clones a challenge', function() {
var copyChallenge = new challenges.Challenge({
name: 'copyChallenge',
description: 'copyChallenge',
habits: [],
dailys: [],
todos: [],
rewards: [],
leader: user._id,
group: "copyGroup",
timestamp: +(new Date),
members: [user],
official: true,
_isMember: true,
prize: 1
});
var challengeToClone = {
name: 'copyChallenge',
description: 'copyChallenge',
habits: [newHabit()],
dailys: [newDaily()],
todos: [newTodo()],
rewards: [newReward()],
leader: 'unique-user-id',
group: { _id: "copyGroup" },
timestamp: new Date("October 13, 2014 11:13:00"),
members: ['id', 'another-id'],
official: true,
_isMember: true,
prize: 1
};
copyChallenge.habits = [
{
_id: "ae2aa6fd-fae4-44bc-940f-11976ee202f3",
id: "ae2aa6fd-fae4-44bc-940f-11976ee202f3",
dateCreated: "2015-06-15T00:18:59.440Z",
down: true,
notes: "",
priority: 1,
text: "test",
type: "habit",
up: true,
value: 0,
}
];
scope.clone(copyChallenge);
it('Clones the basic challenge info', function() {
expect( scope.newChallenge.name ).to.eql( copyChallenge.name );
expect( scope.newChallenge.description ).to.eql( copyChallenge.description );
for( var property in copyChallenge.habits[0] ) {
if ( property == "_id" || property == "id" || property == "dateCreated" ) {
expect( scope.newChallenge.habits[0][property] ).to.not.eql( copyChallenge.habits[0][property] );
} else {
expect( scope.newChallenge.habits[0][property] ).to.eql( copyChallenge.habits[0][property] );
}
}
expect( scope.newChallenge.dailys ).to.eql( copyChallenge.dailys );
expect( scope.newChallenge.todos ).to.eql( copyChallenge.todos );
expect( scope.newChallenge.rewards ).to.eql( copyChallenge.rewards );
expect( scope.newChallenge.leader ).to.eql( copyChallenge.leader );
expect( scope.newChallenge.timestamp ).to.not.eql( copyChallenge.timestamp );
expect( scope.newChallenge.members ).to.eql( [] );
expect( scope.newChallenge.official ).to.eql( copyChallenge.official );
expect( scope.newChallenge.prize ).to.eql( copyChallenge.prize );
scope.clone(challengeToClone);
expect(scope.newChallenge.name).to.eql(challengeToClone.name);
expect(scope.newChallenge.shortName).to.eql(challengeToClone.shortName);
expect(scope.newChallenge.description).to.eql(challengeToClone.description);
expect(scope.newChallenge.leader).to.eql(user._id);
expect(scope.newChallenge.group).to.eql(challengeToClone.group._id);
expect(scope.newChallenge.official).to.eql(challengeToClone.official);
expect(scope.newChallenge.prize).to.eql(challengeToClone.prize);
});
});
it('does not clone members', function() {
scope.clone(challengeToClone);
expect(scope.newChallenge.members).to.not.exist;
});
it('does not clone timestamp', function() {
scope.clone(challengeToClone);
expect(scope.newChallenge.timestamp).to.not.exist;
});
it('clones habits', function() {
scope.clone(challengeToClone);
expect(scope.newChallenge.habits.length).to.eql(challengeToClone.habits.length);
expect(scope.newChallenge.habits[0].text).to.eql(challengeToClone.habits[0].text);
expect(scope.newChallenge.habits[0].notes).to.eql(challengeToClone.habits[0].notes);
});
it('clones dailys', function() {
scope.clone(challengeToClone);
expect(scope.newChallenge.dailys.length).to.eql(challengeToClone.dailys.length);
expect(scope.newChallenge.dailys[0].text).to.eql(challengeToClone.dailys[0].text);
expect(scope.newChallenge.dailys[0].notes).to.eql(challengeToClone.dailys[0].notes);
});
it('clones todos', function() {
scope.clone(challengeToClone);
expect(scope.newChallenge.todos.length).to.eql(challengeToClone.todos.length);
expect(scope.newChallenge.todos[0].text).to.eql(challengeToClone.todos[0].text);
expect(scope.newChallenge.todos[0].notes).to.eql(challengeToClone.todos[0].notes);
});
it('clones rewards', function() {
scope.clone(challengeToClone);
expect(scope.newChallenge.rewards.length).to.eql(challengeToClone.rewards.length);
expect(scope.newChallenge.rewards[0].text).to.eql(challengeToClone.rewards[0].text);
expect(scope.newChallenge.rewards[0].notes).to.eql(challengeToClone.rewards[0].notes);
});
});
});