krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-16 22:27:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Handle social auth in A/B testing (#8024)

Browse Source 
* fix(AB-testing): handle social auth

* refactor(AB-testing): move to pre save hooks
This commit is contained in:
Sabe Jones
2016-09-16 12:13:21 -05:00
committed by Matteo Pagliazzi
parent 81b7eeeb71
commit 86c9bddc09
3 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/api/v3/integration/user/auth/POST-user_auth_social.test.js
View File

@@ -2,6 +2,7 @@ import {
generateUser,
requester,
translate as t,
getProperty,
} from '../../../../../helpers/api-integration/v3';
import passport from 'passport';
@@ -44,6 +45,15 @@ describe('POST /user/auth/social', () => {
expect(response.newUser).to.be.true;
});
it('enrolls a new user in an A/B test', async () => {
await api.post(endpoint, {
authResponse: {access_token: randomAccessToken}, // eslint-disable-line camelcase
network,
});
await expect(getProperty('users', user._id, '_ABtest')).to.eventually.be.a('string');
});
it('logs an existing user in', async () => {
await user.update({ 'auth.facebook.id': facebookId });

8
website/server/controllers/api-v3/auth.js
View File

@@ -130,14 +130,6 @@ api.registerLocal = {
newUser.registeredThrough = req.headers['x-client']; // Not saved, used to create the correct tasks based on the device used
}
// A/B Test 2016-09-12: Start with Sound Enabled?
if (Math.random() < 0.5) {
newUser.preferences.sound = 'rosstavoTheme';
newUser._ABtest = '20160912-soundEnabled';
} else {
newUser._ABtest = '20160912-soundDisabled';
}
// we check for partyInvite for backward compatibility
if (req.query.groupInvite || req.query.partyInvite) {
await _handleGroupInvitation(newUser, req.query.groupInvite || req.query.partyInvite);

12
website/server/models/user/hooks.js
View File

@@ -73,10 +73,18 @@ function _populateDefaultTasks (user, taskTypes) {
});
}
function _populateDefaultsForNewUser (user) {
function _setUpNewUser (user) {
let taskTypes;
let iterableFlags = user.flags.toObject();
// A/B Test 2016-09-12: Start with Sound Enabled?
if (Math.random() < 0.5) {
user.preferences.sound = 'rosstavoTheme';
user._ABtest = '20160912-soundEnabled';
} else {
user._ABtest = '20160912-soundDisabled';
}
if (user.registeredThrough === 'habitica-web' || user.registeredThrough === 'habitica-android') {
taskTypes = ['habit', 'daily', 'todo', 'reward', 'tag'];
@@ -158,7 +166,7 @@ schema.pre('save', true, function preSaveUser (next, done) {
// Populate new users with default content
if (this.isNew) {
_populateDefaultsForNewUser(this)
_setUpNewUser(this)
.then(() => done())
.catch(done);
} else {