fix test lint

test/api/v3/integration/user/auth/POST-register_local.test.js

@@ -1,3 +1,5 @@
+import { v4 as uuid } from 'uuid';
+import { each } from 'lodash';
 import {
   generateUser,
   requester,
@@ -6,8 +8,6 @@ import {
   getProperty,
 } from '../../../../../helpers/api-integration/v3';
 import { ApiUser } from '../../../../../helpers/api-integration/api-classes';
-import { v4 as uuid } from 'uuid';
-import { each } from 'lodash';
 import { encrypt } from '../../../../../../website/server/libs/encryption';
 
 function generateRandomUserName () {
@@ -23,11 +23,11 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('registers a new user', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@example.com`;
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = `${username}@example.com`;
+      const password = 'password';
 
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -42,11 +42,11 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('registers a new user and sets verifiedUsername to true', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@example.com`;
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = `${username}@example.com`;
+      const password = 'password';
 
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -60,11 +60,11 @@ describe('POST /user/auth/local/register', () => {
 
     xit('remove spaces from username', async () => {
       // TODO can probably delete this test now
-      let username = ' usernamewithspaces ';
-      let email = 'test@example.com';
-      let password = 'password';
+      const username = ' usernamewithspaces ';
+      const email = 'test@example.com';
+      const password = 'password';
 
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -125,24 +125,24 @@ describe('POST /user/auth/local/register', () => {
 
     context('provides default tags and tasks', async () => {
       it('for a generic API consumer', async () => {
-        let username = generateRandomUserName();
-        let email = `${username}@example.com`;
-        let password = 'password';
+        const username = generateRandomUserName();
+        const email = `${username}@example.com`;
+        const password = 'password';
 
-        let user = await api.post('/user/auth/local/register', {
+        const user = await api.post('/user/auth/local/register', {
           username,
           email,
           password,
           confirmPassword: password,
         });
 
-        let requests = new ApiUser(user);
+        const requests = new ApiUser(user);
 
-        let habits = await requests.get('/tasks/user?type=habits');
-        let dailys = await requests.get('/tasks/user?type=dailys');
-        let todos = await requests.get('/tasks/user?type=todos');
-        let rewards = await requests.get('/tasks/user?type=rewards');
-        let tags = await requests.get('/tags');
+        const habits = await requests.get('/tasks/user?type=habits');
+        const dailys = await requests.get('/tasks/user?type=dailys');
+        const todos = await requests.get('/tasks/user?type=todos');
+        const rewards = await requests.get('/tasks/user?type=rewards');
+        const tags = await requests.get('/tags');
 
         expect(habits).to.have.a.lengthOf(0);
         expect(dailys).to.have.a.lengthOf(0);
@@ -162,26 +162,26 @@ describe('POST /user/auth/local/register', () => {
       xit('for Web', async () => {
         api = requester(
           null,
-          {'x-client': 'habitica-web'},
+          { 'x-client': 'habitica-web' },
         );
-        let username = generateRandomUserName();
-        let email = `${username}@example.com`;
-        let password = 'password';
+        const username = generateRandomUserName();
+        const email = `${username}@example.com`;
+        const password = 'password';
 
-        let user = await api.post('/user/auth/local/register', {
+        const user = await api.post('/user/auth/local/register', {
           username,
           email,
           password,
           confirmPassword: password,
         });
 
-        let requests = new ApiUser(user);
+        const requests = new ApiUser(user);
 
-        let habits = await requests.get('/tasks/user?type=habits');
-        let dailys = await requests.get('/tasks/user?type=dailys');
-        let todos = await requests.get('/tasks/user?type=todos');
-        let rewards = await requests.get('/tasks/user?type=rewards');
-        let tags = await requests.get('/tags');
+        const habits = await requests.get('/tasks/user?type=habits');
+        const dailys = await requests.get('/tasks/user?type=dailys');
+        const todos = await requests.get('/tasks/user?type=todos');
+        const rewards = await requests.get('/tasks/user?type=rewards');
+        const tags = await requests.get('/tags');
 
         expect(habits).to.have.a.lengthOf(3);
         expect(habits[0].text).to.eql(t('defaultHabit1Text'));
@@ -216,26 +216,26 @@ describe('POST /user/auth/local/register', () => {
       it('for Android', async () => {
         api = requester(
           null,
-          {'x-client': 'habitica-android'},
+          { 'x-client': 'habitica-android' },
         );
-        let username = generateRandomUserName();
-        let email = `${username}@example.com`;
-        let password = 'password';
+        const username = generateRandomUserName();
+        const email = `${username}@example.com`;
+        const password = 'password';
 
-        let user = await api.post('/user/auth/local/register', {
+        const user = await api.post('/user/auth/local/register', {
           username,
           email,
           password,
           confirmPassword: password,
         });
 
-        let requests = new ApiUser(user);
+        const requests = new ApiUser(user);
 
-        let habits = await requests.get('/tasks/user?type=habits');
-        let dailys = await requests.get('/tasks/user?type=dailys');
-        let todos = await requests.get('/tasks/user?type=todos');
-        let rewards = await requests.get('/tasks/user?type=rewards');
-        let tags = await requests.get('/tags');
+        const habits = await requests.get('/tasks/user?type=habits');
+        const dailys = await requests.get('/tasks/user?type=dailys');
+        const todos = await requests.get('/tasks/user?type=todos');
+        const rewards = await requests.get('/tasks/user?type=rewards');
+        const tags = await requests.get('/tags');
 
         expect(habits).to.have.a.lengthOf(0);
         expect(dailys).to.have.a.lengthOf(0);
@@ -247,26 +247,26 @@ describe('POST /user/auth/local/register', () => {
       it('for iOS', async () => {
         api = requester(
           null,
-          {'x-client': 'habitica-ios'},
+          { 'x-client': 'habitica-ios' },
         );
-        let username = generateRandomUserName();
-        let email = `${username}@example.com`;
-        let password = 'password';
+        const username = generateRandomUserName();
+        const email = `${username}@example.com`;
+        const password = 'password';
 
-        let user = await api.post('/user/auth/local/register', {
+        const user = await api.post('/user/auth/local/register', {
           username,
           email,
           password,
           confirmPassword: password,
         });
 
-        let requests = new ApiUser(user);
+        const requests = new ApiUser(user);
 
-        let habits = await requests.get('/tasks/user?type=habits');
-        let dailys = await requests.get('/tasks/user?type=dailys');
-        let todos = await requests.get('/tasks/user?type=todos');
-        let rewards = await requests.get('/tasks/user?type=rewards');
-        let tags = await requests.get('/tags');
+        const habits = await requests.get('/tasks/user?type=habits');
+        const dailys = await requests.get('/tasks/user?type=dailys');
+        const todos = await requests.get('/tasks/user?type=todos');
+        const rewards = await requests.get('/tasks/user?type=rewards');
+        const tags = await requests.get('/tags');
 
         expect(habits).to.have.a.lengthOf(0);
         expect(dailys).to.have.a.lengthOf(0);
@@ -277,11 +277,11 @@ describe('POST /user/auth/local/register', () => {
     });
 
     xit('enrolls new users in an A/B test', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@example.com`;
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = `${username}@example.com`;
+      const password = 'password';
 
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -292,11 +292,11 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('includes items awarded by default when creating a new user', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@example.com`;
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = `${username}@example.com`;
+      const password = 'password';
 
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -309,10 +309,10 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('requires password and confirmPassword to match', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@example.com`;
-      let password = 'password';
-      let confirmPassword = 'not password';
+      const username = generateRandomUserName();
+      const email = `${username}@example.com`;
+      const password = 'password';
+      const confirmPassword = 'not password';
 
       await expect(api.post('/user/auth/local/register', {
         username,
@@ -327,9 +327,9 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('requires a username', async () => {
-      let email = `${generateRandomUserName()}@example.com`;
-      let password = 'password';
-      let confirmPassword = 'password';
+      const email = `${generateRandomUserName()}@example.com`;
+      const password = 'password';
+      const confirmPassword = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         email,
@@ -343,8 +343,8 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('requires an email', async () => {
-      let username = generateRandomUserName();
-      let password = 'password';
+      const username = generateRandomUserName();
+      const password = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         username,
@@ -358,9 +358,9 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('requires a valid email', async () => {
-      let username = generateRandomUserName();
-      let email = 'notanemail@sdf';
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = 'notanemail@sdf';
+      const password = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         username,
@@ -375,11 +375,11 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('sanitizes email params to a lowercase string before creating the user', async () => {
-      let username = generateRandomUserName();
-      let email = 'ISANEmAiL@ExAmPle.coM';
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = 'ISANEmAiL@ExAmPle.coM';
+      const password = 'password';
 
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -390,9 +390,9 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('fails on a habitica.com email', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@habitica.com`;
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = `${username}@habitica.com`;
+      const password = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         username,
@@ -407,9 +407,9 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('fails on a habitrpg.com email', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@habitrpg.com`;
-      let password = 'password';
+      const username = generateRandomUserName();
+      const email = `${username}@habitrpg.com`;
+      const password = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         username,
@@ -424,9 +424,9 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('requires a password', async () => {
-      let username = generateRandomUserName();
-      let email = `${username}@example.com`;
-      let confirmPassword = 'password';
+      const username = generateRandomUserName();
+      const email = `${username}@example.com`;
+      const confirmPassword = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         username,
@@ -442,9 +442,9 @@ describe('POST /user/auth/local/register', () => {
 
   context('attach to facebook user', () => {
     let user;
-    let email = 'some@email.net';
-    let username = 'some-username';
-    let password = 'some-password';
+    const email = 'some@email.net';
+    const username = 'some-username';
+    const password = 'some-password';
     beforeEach(async () => {
       user = await generateUser();
     });
@@ -475,7 +475,8 @@ describe('POST /user/auth/local/register', () => {
   });
 
   context('login is already taken', () => {
-    let username, email, api;
+    let username; let email; let
+      api;
 
     beforeEach(async () => {
       api = requester();
@@ -490,8 +491,8 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('rejects if username is already taken', async () => {
-      let uniqueEmail = `${generateRandomUserName()}@exampe.com`;
-      let password = 'password';
+      const uniqueEmail = `${generateRandomUserName()}@exampe.com`;
+      const password = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         username,
@@ -506,8 +507,8 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('rejects if email is already taken', async () => {
-      let uniqueUsername = generateRandomUserName();
-      let password = 'password';
+      const uniqueUsername = generateRandomUserName();
+      const password = 'password';
 
       await expect(api.post('/user/auth/local/register', {
         username: uniqueUsername,
@@ -523,7 +524,8 @@ describe('POST /user/auth/local/register', () => {
   });
 
   context('req.query.groupInvite', () => {
-    let api, username, email, password;
+    let api; let username; let email; let
+      password;
 
     beforeEach(() => {
       api = requester();
@@ -533,7 +535,7 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('does not crash the signup process when it\'s invalid', async () => {
-      let user = await api.post('/user/auth/local/register?groupInvite=aaaaInvalid', {
+      const user = await api.post('/user/auth/local/register?groupInvite=aaaaInvalid', {
         username,
         email,
         password,
@@ -544,17 +546,17 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('supports invite using req.query.groupInvite', async () => {
-      let { group, groupLeader } = await createAndPopulateGroup({
+      const { group, groupLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'party', privacy: 'private' },
       });
 
-      let invite = encrypt(JSON.stringify({
+      const invite = encrypt(JSON.stringify({
         id: group._id,
         inviter: groupLeader._id,
         sentAt: Date.now(), // so we can let it expire
       }));
 
-      let user = await api.post(`/user/auth/local/register?groupInvite=${invite}`, {
+      const user = await api.post(`/user/auth/local/register?groupInvite=${invite}`, {
         username,
         email,
         password,
@@ -567,11 +569,11 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('awards achievement to inviter', async () => {
-      let { group, groupLeader } = await createAndPopulateGroup({
+      const { group, groupLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'party', privacy: 'private' },
       });
 
-      let invite = encrypt(JSON.stringify({
+      const invite = encrypt(JSON.stringify({
         id: group._id,
         inviter: groupLeader._id,
         sentAt: Date.now(),
@@ -589,17 +591,17 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('user not added to a party on expired invite', async () => {
-      let { group, groupLeader } = await createAndPopulateGroup({
+      const { group, groupLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'party', privacy: 'private' },
       });
 
-      let invite = encrypt(JSON.stringify({
+      const invite = encrypt(JSON.stringify({
         id: group._id,
         inviter: groupLeader._id,
         sentAt: Date.now() - 6.912e8, // 8 days old
       }));
 
-      let user = await api.post(`/user/auth/local/register?groupInvite=${invite}`, {
+      const user = await api.post(`/user/auth/local/register?groupInvite=${invite}`, {
         username,
         email,
         password,
@@ -610,17 +612,17 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('adds a user to a guild on an invite of type other than party', async () => {
-      let { group, groupLeader } = await createAndPopulateGroup({
+      const { group, groupLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'private' },
       });
 
-      let invite = encrypt(JSON.stringify({
+      const invite = encrypt(JSON.stringify({
         id: group._id,
         inviter: groupLeader._id,
         sentAt: Date.now(),
       }));
 
-      let user = await api.post(`/user/auth/local/register?groupInvite=${invite}`, {
+      const user = await api.post(`/user/auth/local/register?groupInvite=${invite}`, {
         username,
         email,
         password,
@@ -636,7 +638,8 @@ describe('POST /user/auth/local/register', () => {
   });
 
   context('successful login via api', () => {
-    let api, username, email, password;
+    let api; let username; let email; let
+      password;
 
     beforeEach(() => {
       api = requester();
@@ -646,7 +649,7 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('sets all site tour values to -2 (already seen)', async () => {
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -655,13 +658,13 @@ describe('POST /user/auth/local/register', () => {
 
       expect(user.flags.tour).to.not.be.empty;
 
-      each(user.flags.tour, (value) => {
+      each(user.flags.tour, value => {
         expect(value).to.eql(-2);
       });
     });
 
     it('populates user with default todos, not no other task types', async () => {
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -675,7 +678,7 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('populates user with default tags', async () => {
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -687,17 +690,18 @@ describe('POST /user/auth/local/register', () => {
   });
 
   context('successful login with habitica-web header', () => {
-    let api, username, email, password;
+    let api; let username; let email; let
+      password;
 
     beforeEach(() => {
-      api = requester({}, {'x-client': 'habitica-web'});
+      api = requester({}, { 'x-client': 'habitica-web' });
       username = generateRandomUserName();
       email = `${username}@example.com`;
       password = 'password';
     });
 
     it('sets all common tutorial flags to true', async () => {
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -706,13 +710,13 @@ describe('POST /user/auth/local/register', () => {
 
       expect(user.flags.tour).to.not.be.empty;
 
-      each(user.flags.tutorial.common, (value) => {
+      each(user.flags.tutorial.common, value => {
         expect(value).to.eql(true);
       });
     });
 
     it('populates user with default todos, habits, and rewards', async () => {
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -726,7 +730,7 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('populates user with default tags', async () => {
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
@@ -737,17 +741,17 @@ describe('POST /user/auth/local/register', () => {
     });
 
     it('adds the correct tags to the correct tasks', async () => {
-      let user = await api.post('/user/auth/local/register', {
+      const user = await api.post('/user/auth/local/register', {
         username,
         email,
         password,
         confirmPassword: password,
       });
 
-      let requests = new ApiUser(user);
+      const requests = new ApiUser(user);
 
-      let habits = await requests.get('/tasks/user?type=habits');
-      let todos = await requests.get('/tasks/user?type=todos');
+      const habits = await requests.get('/tasks/user?type=habits');
+      const todos = await requests.get('/tasks/user?type=todos');
 
       expect(habits).to.have.a.lengthOf(0);
       expect(todos).to.have.a.lengthOf(0);