fix test lint

test/api/v3/integration/quests/POST-groups_groupId_quests_accept.test.js

@@ -17,7 +17,7 @@ describe('POST /groups/:groupId/quests/accept', () => {
   beforeEach(async () => {
     user = await generateUser();
 
-    let { group, groupLeader, members } = await createAndPopulateGroup({
+    const { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
       members: 2,
     });
@@ -51,7 +51,7 @@ describe('POST /groups/:groupId/quests/accept', () => {
     });
 
     it('does not accept quest for a guild', async () => {
-      let { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
+      const { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'private' },
       });
 
@@ -134,7 +134,7 @@ describe('POST /groups/:groupId/quests/accept', () => {
     });
 
     it('cleans up user quest data for non-quest members when last member accepts', async () => {
-      let rejectingMember = partyMembers[0];
+      const rejectingMember = partyMembers[0];
 
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
       await rejectingMember.post(`/groups/${questingGroup._id}/quests/reject`);
@@ -162,7 +162,7 @@ describe('POST /groups/:groupId/quests/accept', () => {
       expect(groupChat[0]._meta).to.exist;
       expect(groupChat[0]._meta).to.have.all.keys(['participatingMembers']);
 
-      let returnedGroup = await leader.get(`/groups/${questingGroup._id}`);
+      const returnedGroup = await leader.get(`/groups/${questingGroup._id}`);
       expect(returnedGroup.chat[0]._meta).to.be.undefined;
     });
   });

test/api/v3/integration/quests/POST-groups_groupId_quests_force-start.test.js

@@ -14,7 +14,7 @@ describe('POST /groups/:groupId/quests/force-start', () => {
   let partyMembers;
 
   beforeEach(async () => {
-    let { group, groupLeader, members } = await createAndPopulateGroup({
+    const { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
       members: 3,
     });
@@ -30,7 +30,7 @@ describe('POST /groups/:groupId/quests/force-start', () => {
 
   context('failure conditions', () => {
     it('does not force start a quest for a group in which user is not a member', async () => {
-      let nonMember = await generateUser();
+      const nonMember = await generateUser();
 
       await expect(nonMember.post(`/groups/${questingGroup._id}/quests/force-start`))
         .to.eventually.be.rejected.and.eql({
@@ -41,7 +41,7 @@ describe('POST /groups/:groupId/quests/force-start', () => {
     });
 
     it('does not force start quest for a guild', async () => {
-      let { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
+      const { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'private' },
       });
 
@@ -91,8 +91,8 @@ describe('POST /groups/:groupId/quests/force-start', () => {
 
   context('successfully force starting a quest', () => {
     it('allows quest leader to force start quest', async () => {
-      let questLeader = partyMembers[0];
-      await questLeader.update({[`items.quests.${PET_QUEST}`]: 1});
+      const questLeader = partyMembers[0];
+      await questLeader.update({ [`items.quests.${PET_QUEST}`]: 1 });
       await questLeader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
 
       await questLeader.post(`/groups/${questingGroup._id}/quests/force-start`);
@@ -103,8 +103,8 @@ describe('POST /groups/:groupId/quests/force-start', () => {
     });
 
     it('allows group leader to force start quest', async () => {
-      let questLeader = partyMembers[0];
-      await questLeader.update({[`items.quests.${PET_QUEST}`]: 1});
+      const questLeader = partyMembers[0];
+      await questLeader.update({ [`items.quests.${PET_QUEST}`]: 1 });
       await questLeader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
 
       await leader.post(`/groups/${questingGroup._id}/quests/force-start`);
@@ -117,7 +117,7 @@ describe('POST /groups/:groupId/quests/force-start', () => {
     it('sends back the quest object', async () => {
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
 
-      let quest = await leader.post(`/groups/${questingGroup._id}/quests/force-start`);
+      const quest = await leader.post(`/groups/${questingGroup._id}/quests/force-start`);
 
       expect(quest.active).to.eql(true);
       expect(quest.key).to.eql(PET_QUEST);
@@ -127,8 +127,8 @@ describe('POST /groups/:groupId/quests/force-start', () => {
     });
 
     it('cleans up user quest data for non-quest members', async () => {
-      let partyMemberThatRejects = partyMembers[1];
-      let partyMemberThatIgnores = partyMembers[2];
+      const partyMemberThatRejects = partyMembers[1];
+      const partyMemberThatIgnores = partyMembers[2];
 
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
       await partyMembers[0].post(`/groups/${questingGroup._id}/quests/accept`);
@@ -152,9 +152,9 @@ describe('POST /groups/:groupId/quests/force-start', () => {
     });
 
     it('removes users who have not accepted the quest from quest.members', async () => {
-      let partyMemberThatRejects = partyMembers[1];
-      let partyMemberThatIgnores = partyMembers[2];
-      let partyMemberThatAccepts = partyMembers[0];
+      const partyMemberThatRejects = partyMembers[1];
+      const partyMemberThatIgnores = partyMembers[2];
+      const partyMemberThatAccepts = partyMembers[0];
 
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
       await partyMemberThatAccepts.post(`/groups/${questingGroup._id}/quests/accept`);
@@ -174,7 +174,7 @@ describe('POST /groups/:groupId/quests/force-start', () => {
 
     it('removes users who are not in the party from quest.members', async () => {
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
-      let notInPartyUser = await generateUser();
+      const notInPartyUser = await generateUser();
 
       await questingGroup.update({
         [`quest.members.${notInPartyUser._id}`]: true,
@@ -210,8 +210,8 @@ describe('POST /groups/:groupId/quests/force-start', () => {
     });
 
     it('removes users who don\'t have true value in quest.members from quest.members', async () => {
-      let partyMemberThatRejects = partyMembers[1];
-      let partyMemberThatIgnores = partyMembers[2];
+      const partyMemberThatRejects = partyMembers[1];
+      const partyMemberThatIgnores = partyMembers[2];
 
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
       await partyMembers[0].post(`/groups/${questingGroup._id}/quests/accept`);
@@ -234,8 +234,8 @@ describe('POST /groups/:groupId/quests/force-start', () => {
     });
 
     it('allows group leader to force start quest and verifies chat', async () => {
-      let questLeader = partyMembers[0];
-      await questLeader.update({[`items.quests.${PET_QUEST}`]: 1});
+      const questLeader = partyMembers[0];
+      await questLeader.update({ [`items.quests.${PET_QUEST}`]: 1 });
       await questLeader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
 
       await leader.post(`/groups/${questingGroup._id}/quests/force-start`);

test/api/v3/integration/quests/POST-groups_groupId_quests_invite.test.js

@@ -1,9 +1,9 @@
+import { v4 as generateUUID } from 'uuid';
 import {
   createAndPopulateGroup,
   translate as t,
   sleep,
 } from '../../../../helpers/api-integration/v3';
-import { v4 as generateUUID } from 'uuid';
 import { quests as questScrolls } from '../../../../../website/common/script/content/quests';
 import { chatModel as Chat } from '../../../../../website/server/models/message';
 import apiError from '../../../../../website/server/libs/apiError';
@@ -15,14 +15,14 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
   const PET_QUEST = 'whale';
 
   beforeEach(async () => {
-    let { group, groupLeader, members } = await createAndPopulateGroup({
+    const { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
       members: 1,
     });
 
     questingGroup = group;
     leader = groupLeader;
-    member = members[0];
+    member = members[0]; // eslint-disable-line prefer-destructuring
   });
 
   context('failure conditions', () => {
@@ -35,12 +35,12 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
     });
 
     it('does not issue invites for a group in which user is not a member', async () => {
-      let { group } = await createAndPopulateGroup({
+      const { group } = await createAndPopulateGroup({
         groupDetails: { type: 'party', privacy: 'private' },
         members: 1,
       });
 
-      let alternateGroup = group;
+      const alternateGroup = group;
 
       await expect(leader.post(`/groups/${alternateGroup._id}/quests/invite/${PET_QUEST}`)).to.eventually.be.rejected.and.eql({
         code: 404,
@@ -50,12 +50,12 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
     });
 
     it('does not issue invites for Guilds', async () => {
-      let { group } = await createAndPopulateGroup({
+      const { group } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'public' },
         members: 1,
       });
 
-      let alternateGroup = group;
+      const alternateGroup = group;
 
       await expect(leader.post(`/groups/${alternateGroup._id}/quests/invite/${PET_QUEST}`)).to.eventually.be.rejected.and.eql({
         code: 401,
@@ -70,7 +70,7 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
       await expect(leader.post(`/groups/${questingGroup._id}/quests/invite/${FAKE_QUEST}`)).to.eventually.be.rejected.and.eql({
         code: 404,
         error: 'NotFound',
-        message: apiError('questNotFound', {key: FAKE_QUEST}),
+        message: apiError('questNotFound', { key: FAKE_QUEST }),
       });
     });
 
@@ -94,7 +94,7 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
       await expect(leader.post(`/groups/${questingGroup._id}/quests/invite/${LEVELED_QUEST}`)).to.eventually.be.rejected.and.eql({
         code: 401,
         error: 'NotAuthorized',
-        message: t('questLevelTooHigh', {level: LEVELED_QUEST_REQ}),
+        message: t('questLevelTooHigh', { level: LEVELED_QUEST_REQ }),
       });
     });
 
@@ -130,7 +130,7 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
 
       await questingGroup.sync();
 
-      let quest = questingGroup.quest;
+      const { quest } = questingGroup;
 
       expect(quest.key).to.eql(PET_QUEST);
       expect(quest.active).to.eql(false);
@@ -157,7 +157,7 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
     });
 
     it('sends back the quest object', async () => {
-      let inviteResponse = await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
+      const inviteResponse = await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
 
       expect(inviteResponse.key).to.eql(PET_QUEST);
       expect(inviteResponse.active).to.eql(false);
@@ -168,7 +168,7 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
     });
 
     it('allows non-party-leader party members to send invites', async () => {
-      let inviteResponse = await member.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
+      const inviteResponse = await member.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
 
       await questingGroup.sync();
 
@@ -177,9 +177,9 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
     });
 
     it('starts quest automatically if user is in a solo party', async () => {
-      let leaderDetails = { balance: 10 };
+      const leaderDetails = { balance: 10 };
       leaderDetails[`items.quests.${PET_QUEST}`] = 1;
-      let { group, groupLeader } = await createAndPopulateGroup({
+      const { group, groupLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'party', privacy: 'private' },
         leaderDetails,
       });
@@ -192,9 +192,9 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
     });
 
     it('starts quest automatically if user is in a solo party and verifies chat', async () => {
-      let leaderDetails = { balance: 10 };
+      const leaderDetails = { balance: 10 };
       leaderDetails[`items.quests.${PET_QUEST}`] = 1;
-      let { group, groupLeader } = await createAndPopulateGroup({
+      const { group, groupLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'party', privacy: 'private' },
         leaderDetails,
       });
@@ -207,7 +207,7 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
       expect(groupChat[0]._meta).to.exist;
       expect(groupChat[0]._meta).to.have.all.keys(['participatingMembers']);
 
-      let returnedGroup = await groupLeader.get(`/groups/${group._id}`);
+      const returnedGroup = await groupLeader.get(`/groups/${group._id}`);
       expect(returnedGroup.chat[0]._meta).to.be.undefined;
     });
   });

test/api/v3/integration/quests/POST-groups_groupid_quests_abort.test.js

@@ -1,9 +1,9 @@
+import { v4 as generateUUID } from 'uuid';
 import {
   createAndPopulateGroup,
   translate as t,
   generateUser,
 } from '../../../../helpers/api-integration/v3';
-import { v4 as generateUUID } from 'uuid';
 import { model as Group } from '../../../../../website/server/models/group';
 
 describe('POST /groups/:groupId/quests/abort', () => {
@@ -15,7 +15,7 @@ describe('POST /groups/:groupId/quests/abort', () => {
   const PET_QUEST = 'whale';
 
   beforeEach(async () => {
-    let { group, groupLeader, members } = await createAndPopulateGroup({
+    const { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
       members: 2,
     });
@@ -50,7 +50,7 @@ describe('POST /groups/:groupId/quests/abort', () => {
     });
 
     it('returns an error when group is a guild', async () => {
-      let { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
+      const { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'private' },
       });
 
@@ -90,9 +90,9 @@ describe('POST /groups/:groupId/quests/abort', () => {
     await partyMembers[0].post(`/groups/${questingGroup._id}/quests/accept`);
     await partyMembers[1].post(`/groups/${questingGroup._id}/quests/accept`);
 
-    let stub = sandbox.spy(Group.prototype, 'sendChat');
+    const stub = sandbox.spy(Group.prototype, 'sendChat');
 
-    let res = await leader.post(`/groups/${questingGroup._id}/quests/abort`);
+    const res = await leader.post(`/groups/${questingGroup._id}/quests/abort`);
     await Promise.all([
       leader.sync(),
       questingGroup.sync(),
@@ -100,7 +100,7 @@ describe('POST /groups/:groupId/quests/abort', () => {
       partyMembers[1].sync(),
     ]);
 
-    let cleanUserQuestObj = {
+    const cleanUserQuestObj = {
       key: null,
       progress: {
         up: 0,

test/api/v3/integration/quests/POST-groups_groupid_quests_cancel.test.js

@@ -1,9 +1,9 @@
+import { v4 as generateUUID } from 'uuid';
 import {
   createAndPopulateGroup,
   translate as t,
   generateUser,
 } from '../../../../helpers/api-integration/v3';
-import { v4 as generateUUID } from 'uuid';
 import { model as Group } from '../../../../../website/server/models/group';
 
 describe('POST /groups/:groupId/quests/cancel', () => {
@@ -15,7 +15,7 @@ describe('POST /groups/:groupId/quests/cancel', () => {
   const PET_QUEST = 'whale';
 
   beforeEach(async () => {
-    let { group, groupLeader, members } = await createAndPopulateGroup({
+    const { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
       members: 2,
     });
@@ -50,7 +50,7 @@ describe('POST /groups/:groupId/quests/cancel', () => {
     });
 
     it('returns an error when group is a guild', async () => {
-      let { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
+      const { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'private' },
       });
 
@@ -103,9 +103,9 @@ describe('POST /groups/:groupId/quests/cancel', () => {
     // partyMembers[1] hasn't accepted the invitation, because if he accepts, invitation phase ends.
     // The cancel command can be done only in the invitation phase.
 
-    let stub = sandbox.spy(Group.prototype, 'sendChat');
+    const stub = sandbox.spy(Group.prototype, 'sendChat');
 
-    let res = await leader.post(`/groups/${questingGroup._id}/quests/cancel`);
+    const res = await leader.post(`/groups/${questingGroup._id}/quests/cancel`);
 
     await Promise.all([
       leader.sync(),
@@ -114,7 +114,7 @@ describe('POST /groups/:groupId/quests/cancel', () => {
       questingGroup.sync(),
     ]);
 
-    let clean = {
+    const clean = {
       key: null,
       progress: {
         up: 0,

test/api/v3/integration/quests/POST-groups_groupid_quests_leave.test.js

@@ -1,9 +1,9 @@
+import { v4 as generateUUID } from 'uuid';
 import {
   createAndPopulateGroup,
   translate as t,
   generateUser,
 } from '../../../../helpers/api-integration/v3';
-import { v4 as generateUUID } from 'uuid';
 
 describe('POST /groups/:groupId/quests/leave', () => {
   let questingGroup;
@@ -14,7 +14,7 @@ describe('POST /groups/:groupId/quests/leave', () => {
   const PET_QUEST = 'whale';
 
   beforeEach(async () => {
-    let { group, groupLeader, members } = await createAndPopulateGroup({
+    const { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
       members: 2,
     });
@@ -49,7 +49,7 @@ describe('POST /groups/:groupId/quests/leave', () => {
     });
 
     it('returns an error when group is a guild', async () => {
-      let { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
+      const { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'private' },
       });
 
@@ -102,7 +102,7 @@ describe('POST /groups/:groupId/quests/leave', () => {
     await partyMembers[0].post(`/groups/${questingGroup._id}/quests/accept`);
     await partyMembers[1].post(`/groups/${questingGroup._id}/quests/accept`);
 
-    let leaveResult = await partyMembers[0].post(`/groups/${questingGroup._id}/quests/leave`);
+    const leaveResult = await partyMembers[0].post(`/groups/${questingGroup._id}/quests/leave`);
     await Promise.all([
       partyMembers[0].sync(),
       questingGroup.sync(),

test/api/v3/integration/quests/POST-groups_groupid_quests_reject.test.js

@@ -1,10 +1,10 @@
+import { v4 as generateUUID } from 'uuid';
 import {
   createAndPopulateGroup,
   translate as t,
   generateUser,
   sleep,
 } from '../../../../helpers/api-integration/v3';
-import { v4 as generateUUID } from 'uuid';
 import { chatModel as Chat } from '../../../../../website/server/models/message';
 
 describe('POST /groups/:groupId/quests/reject', () => {
@@ -16,7 +16,7 @@ describe('POST /groups/:groupId/quests/reject', () => {
   const PET_QUEST = 'whale';
 
   beforeEach(async () => {
-    let { group, groupLeader, members } = await createAndPopulateGroup({
+    const { group, groupLeader, members } = await createAndPopulateGroup({
       groupDetails: { type: 'party', privacy: 'private' },
       members: 2,
     });
@@ -51,7 +51,7 @@ describe('POST /groups/:groupId/quests/reject', () => {
     });
 
     it('returns an error when group is a guild', async () => {
-      let { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
+      const { group: guild, groupLeader: guildLeader } = await createAndPopulateGroup({
         groupDetails: { type: 'guild', privacy: 'private' },
       });
 
@@ -127,7 +127,7 @@ describe('POST /groups/:groupId/quests/reject', () => {
   });
 
   context('successfully quest rejection', () => {
-    let cleanUserQuestObj = {
+    const cleanUserQuestObj = {
       key: null,
       progress: {
         up: 0,
@@ -142,7 +142,7 @@ describe('POST /groups/:groupId/quests/reject', () => {
     it('rejects a quest invitation', async () => {
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
 
-      let res = await partyMembers[0].post(`/groups/${questingGroup._id}/quests/reject`);
+      const res = await partyMembers[0].post(`/groups/${questingGroup._id}/quests/reject`);
       await partyMembers[0].sync();
       await questingGroup.sync();
 
@@ -162,7 +162,7 @@ describe('POST /groups/:groupId/quests/reject', () => {
     });
 
     it('cleans up user quest data for non-quest members when last member rejects', async () => {
-      let rejectingMember = partyMembers[1];
+      const rejectingMember = partyMembers[1];
 
       await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
       await partyMembers[0].post(`/groups/${questingGroup._id}/quests/accept`);
@@ -193,7 +193,7 @@ describe('POST /groups/:groupId/quests/reject', () => {
       expect(groupChat[0]._meta).to.exist;
       expect(groupChat[0]._meta).to.have.all.keys(['participatingMembers']);
 
-      let returnedGroup = await leader.get(`/groups/${questingGroup._id}`);
+      const returnedGroup = await leader.get(`/groups/${questingGroup._id}`);
       expect(returnedGroup.chat[0]._meta).to.be.undefined;
     });
   });