fix test lint

test/api/unit/libs/payments/stripe/cancel-subscription.test.js

@@ -2,18 +2,19 @@ import stripeModule from 'stripe';
 
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import stripePayments from '../../../../../../website/server/libs/payments/stripe';
 import payments from '../../../../../../website/server/libs/payments/payments';
 import common from '../../../../../../website/common';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('cancel subscription', () => {
   const subKey = 'basic_3mo';
   const stripe = stripeModule('test');
-  let user, groupId, group;
+  let user; let groupId; let
+    group;
 
   beforeEach(async () => {
     user = new User();
@@ -62,7 +63,7 @@ describe('cancel subscription', () => {
   });
 
   it('throws an error if user is not the group leader', async () => {
-    let nonLeader = new User();
+    const nonLeader = new User();
     nonLeader.guilds.push(groupId);
     await nonLeader.save();
 
@@ -78,7 +79,9 @@ describe('cancel subscription', () => {
   });
 
   describe('success', () => {
-    let stripeDeleteCustomerStub, paymentsCancelSubStub, stripeRetrieveStub, subscriptionId, currentPeriodEndTimeStamp;
+    let stripeDeleteCustomerStub; let paymentsCancelSubStub;
+    let stripeRetrieveStub; let subscriptionId; let
+      currentPeriodEndTimeStamp;
 
     beforeEach(() => {
       subscriptionId = 'subId';
@@ -89,7 +92,10 @@ describe('cancel subscription', () => {
       stripeRetrieveStub = sinon.stub(stripe.customers, 'retrieve')
         .resolves({
           subscriptions: {
-            data: [{id: subscriptionId, current_period_end: currentPeriodEndTimeStamp}], // eslint-disable-line camelcase
+            data: [{
+              id: subscriptionId,
+              current_period_end: currentPeriodEndTimeStamp,
+            }], // eslint-disable-line camelcase
           },
         });
     });

test/api/unit/libs/payments/stripe/checkout-subscription.test.js

@@ -3,19 +3,22 @@ import cc from 'coupon-code';
 
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import { model as Coupon } from '../../../../../../website/server/models/coupon';
 import stripePayments from '../../../../../../website/server/libs/payments/stripe';
 import payments from '../../../../../../website/server/libs/payments/payments';
 import common from '../../../../../../website/common';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('checkout with subscription', () => {
   const subKey = 'basic_3mo';
   const stripe = stripeModule('test');
-  let user, group, data, gift, sub, groupId, email, headers, coupon, customerIdResponse, subscriptionId, token;
+  let user; let group; let data; let gift; let sub;
+  let groupId; let email; let headers; let coupon;
+  let customerIdResponse; let subscriptionId; let
+    token;
   let spy;
   let stripeCreateCustomerSpy;
   let stripePaymentsCreateSubSpy;
@@ -57,10 +60,10 @@ describe('checkout with subscription', () => {
     spy.resolves;
 
     stripeCreateCustomerSpy = sinon.stub(stripe.customers, 'create');
-    let stripCustomerResponse = {
+    const stripCustomerResponse = {
       id: customerIdResponse,
       subscriptions: {
-        data: [{id: subscriptionId}],
+        data: [{ id: subscriptionId }],
       },
     };
     stripeCreateCustomerSpy.resolves(stripCustomerResponse);
@@ -72,7 +75,7 @@ describe('checkout with subscription', () => {
     data.sub.quantity = 3;
   });
 
-  afterEach(function () {
+  afterEach(() => {
     stripe.subscriptions.update.restore();
     stripe.customers.create.restore();
     payments.createSubscription.restore();
@@ -120,7 +123,7 @@ describe('checkout with subscription', () => {
     sub.key = 'google_6mo';
     coupon = 'example-coupon';
 
-    let couponModel = new Coupon();
+    const couponModel = new Coupon();
     couponModel.event = 'google_6mo';
     await couponModel.save();
 
@@ -149,9 +152,9 @@ describe('checkout with subscription', () => {
     sub.key = 'google_6mo';
     coupon = 'example-coupon';
 
-    let couponModel = new Coupon();
+    const couponModel = new Coupon();
     couponModel.event = 'google_6mo';
-    let updatedCouponModel = await couponModel.save();
+    const updatedCouponModel = await couponModel.save();
 
     sinon.stub(cc, 'validate').returns(updatedCouponModel._id);
 

test/api/unit/libs/payments/stripe/checkout.test.js

@@ -5,13 +5,15 @@ import stripePayments from '../../../../../../website/server/libs/payments/strip
 import payments from '../../../../../../website/server/libs/payments/payments';
 import common from '../../../../../../website/common';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('checkout', () => {
   const subKey = 'basic_3mo';
   const stripe = stripeModule('test');
-  let stripeChargeStub, paymentBuyGemsStub, paymentCreateSubscritionStub;
-  let user, gift, groupId, email, headers, coupon, customerIdResponse, token;
+  let stripeChargeStub; let paymentBuyGemsStub; let
+    paymentCreateSubscritionStub;
+  let user; let gift; let groupId; let email; let headers; let coupon; let customerIdResponse; let
+    token;
 
   beforeEach(() => {
     user = new User();
@@ -23,7 +25,7 @@ describe('checkout', () => {
     token = 'test-token';
 
     customerIdResponse = 'example-customerIdResponse';
-    let stripCustomerResponse = {
+    const stripCustomerResponse = {
       id: customerIdResponse,
     };
     stripeChargeStub = sinon.stub(stripe.charges, 'create').resolves(stripCustomerResponse);
@@ -54,7 +56,7 @@ describe('checkout', () => {
   });
 
   it('should error if gem amount is too low', async () => {
-    let receivingUser = new User();
+    const receivingUser = new User();
     receivingUser.save();
     gift = {
       type: 'gems',
@@ -132,7 +134,7 @@ describe('checkout', () => {
   });
 
   it('should gift gems', async () => {
-    let receivingUser = new User();
+    const receivingUser = new User();
     await receivingUser.save();
     gift = {
       type: 'gems',
@@ -169,7 +171,7 @@ describe('checkout', () => {
   });
 
   it('should gift a subscription', async () => {
-    let receivingUser = new User();
+    const receivingUser = new User();
     receivingUser.save();
     gift = {
       type: 'subscription',

test/api/unit/libs/payments/stripe/edit-subscription.test.js

@@ -2,17 +2,18 @@ import stripeModule from 'stripe';
 
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import stripePayments from '../../../../../../website/server/libs/payments/stripe';
 import common from '../../../../../../website/common';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('edit subscription', () => {
   const subKey = 'basic_3mo';
   const stripe = stripeModule('test');
-  let user, groupId, group, token;
+  let user; let groupId; let group; let
+    token;
 
   beforeEach(async () => {
     user = new User();
@@ -76,7 +77,7 @@ describe('edit subscription', () => {
   });
 
   it('throws an error if user is not the group leader', async () => {
-    let nonLeader = new User();
+    const nonLeader = new User();
     nonLeader.guilds.push(groupId);
     await nonLeader.save();
 
@@ -93,13 +94,14 @@ describe('edit subscription', () => {
   });
 
   describe('success', () => {
-    let stripeListSubscriptionStub, stripeUpdateSubscriptionStub, subscriptionId;
+    let stripeListSubscriptionStub; let stripeUpdateSubscriptionStub; let
+      subscriptionId;
 
     beforeEach(() => {
       subscriptionId = 'subId';
       stripeListSubscriptionStub = sinon.stub(stripe.subscriptions, 'list')
         .resolves({
-          data: [{id: subscriptionId}],
+          data: [{ id: subscriptionId }],
         });
 
       stripeUpdateSubscriptionStub = sinon.stub(stripe.subscriptions, 'update').resolves({});
@@ -118,11 +120,13 @@ describe('edit subscription', () => {
       }, stripe);
 
       expect(stripeListSubscriptionStub).to.be.calledOnce;
-      expect(stripeListSubscriptionStub).to.be.calledWith({customer: user.purchased.plan.customerId});
+      expect(stripeListSubscriptionStub).to.be.calledWith({
+        customer: user.purchased.plan.customerId,
+      });
       expect(stripeUpdateSubscriptionStub).to.be.calledOnce;
       expect(stripeUpdateSubscriptionStub).to.be.calledWith(
         subscriptionId,
-        { card: token }
+        { card: token },
       );
     });
 
@@ -134,11 +138,13 @@ describe('edit subscription', () => {
       }, stripe);
 
       expect(stripeListSubscriptionStub).to.be.calledOnce;
-      expect(stripeListSubscriptionStub).to.be.calledWith({customer: group.purchased.plan.customerId});
+      expect(stripeListSubscriptionStub).to.be.calledWith({
+        customer: group.purchased.plan.customerId,
+      });
       expect(stripeUpdateSubscriptionStub).to.be.calledOnce;
       expect(stripeUpdateSubscriptionStub).to.be.calledWith(
         subscriptionId,
-        { card: token }
+        { card: token },
       );
     });
   });

test/api/unit/libs/payments/stripe/handle-webhook.test.js

@@ -1,25 +1,25 @@
 import stripeModule from 'stripe';
 
+import { v4 as uuid } from 'uuid';
+import moment from 'moment';
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import stripePayments from '../../../../../../website/server/libs/payments/stripe';
 import payments from '../../../../../../website/server/libs/payments/payments';
 import common from '../../../../../../website/common';
 import logger from '../../../../../../website/server/libs/logger';
-import { v4 as uuid } from 'uuid';
-import moment from 'moment';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('Stripe - Webhooks', () => {
   const stripe = stripeModule('test');
 
   describe('all events', () => {
     const eventType = 'account.updated';
-    const event = {id: 123};
-    const eventRetrieved = {type: eventType};
+    const event = { id: 123 };
+    const eventRetrieved = { type: eventType };
 
     beforeEach(() => {
       sinon.stub(stripe.events, 'retrieve').resolves(eventRetrieved);
@@ -33,7 +33,7 @@ describe('Stripe - Webhooks', () => {
 
     it('logs an error if an unsupported webhook event is passed', async () => {
       const error = new Error(`Missing handler for Stripe webhook ${eventType}`);
-      await stripePayments.handleWebhooks({requestBody: event}, stripe);
+      await stripePayments.handleWebhooks({ requestBody: event }, stripe);
       expect(logger.error).to.have.been.calledOnce;
 
       const calledWith = logger.error.getCall(0).args;
@@ -42,7 +42,7 @@ describe('Stripe - Webhooks', () => {
     });
 
     it('retrieves and validates the event from Stripe', async () => {
-      await stripePayments.handleWebhooks({requestBody: event}, stripe);
+      await stripePayments.handleWebhooks({ requestBody: event }, stripe);
       expect(stripe.events.retrieve).to.have.been.calledOnce;
       expect(stripe.events.retrieve).to.have.been.calledWith(event.id);
     });
@@ -68,7 +68,7 @@ describe('Stripe - Webhooks', () => {
         request: 123,
       });
 
-      await stripePayments.handleWebhooks({requestBody: {}}, stripe);
+      await stripePayments.handleWebhooks({ requestBody: {} }, stripe);
 
       expect(stripe.events.retrieve).to.have.been.calledOnce;
       expect(stripe.customers.del).to.not.have.been.called;
@@ -93,11 +93,12 @@ describe('Stripe - Webhooks', () => {
           request: null,
         });
 
-        await expect(stripePayments.handleWebhooks({requestBody: {}}, stripe)).to.eventually.be.rejectedWith({
-          message: i18n.t('userNotFound'),
-          httpCode: 404,
-          name: 'NotFound',
-        });
+        await expect(stripePayments.handleWebhooks({ requestBody: {} }, stripe))
+          .to.eventually.be.rejectedWith({
+            message: i18n.t('userNotFound'),
+            httpCode: 404,
+            name: 'NotFound',
+          });
 
         expect(stripe.customers.del).to.not.have.been.called;
         expect(payments.cancelSubscription).to.not.have.been.called;
@@ -108,7 +109,7 @@ describe('Stripe - Webhooks', () => {
       it('deletes the customer on Stripe and calls payments.cancelSubscription', async () => {
         const customerId = '456';
 
-        let subscriber = new User();
+        const subscriber = new User();
         subscriber.purchased.plan.customerId = customerId;
         subscriber.purchased.plan.paymentMethod = 'Stripe';
         await subscriber.save();
@@ -127,13 +128,13 @@ describe('Stripe - Webhooks', () => {
           request: null,
         });
 
-        await stripePayments.handleWebhooks({requestBody: {}}, stripe);
+        await stripePayments.handleWebhooks({ requestBody: {} }, stripe);
 
         expect(stripe.customers.del).to.have.been.calledOnce;
         expect(stripe.customers.del).to.have.been.calledWith(customerId);
         expect(payments.cancelSubscription).to.have.been.calledOnce;
 
-        let cancelSubscriptionOpts = payments.cancelSubscription.lastCall.args[0];
+        const cancelSubscriptionOpts = payments.cancelSubscription.lastCall.args[0];
         expect(cancelSubscriptionOpts.user._id).to.equal(subscriber._id);
         expect(cancelSubscriptionOpts.paymentMethod).to.equal('Stripe');
         expect(Math.round(moment(cancelSubscriptionOpts.nextBill).diff(new Date(), 'days', true))).to.equal(3);
@@ -160,11 +161,12 @@ describe('Stripe - Webhooks', () => {
           request: null,
         });
 
-        await expect(stripePayments.handleWebhooks({requestBody: {}}, stripe)).to.eventually.be.rejectedWith({
-          message: i18n.t('groupNotFound'),
-          httpCode: 404,
-          name: 'NotFound',
-        });
+        await expect(stripePayments.handleWebhooks({ requestBody: {} }, stripe))
+          .to.eventually.be.rejectedWith({
+            message: i18n.t('groupNotFound'),
+            httpCode: 404,
+            name: 'NotFound',
+          });
 
         expect(stripe.customers.del).to.not.have.been.called;
         expect(payments.cancelSubscription).to.not.have.been.called;
@@ -175,7 +177,7 @@ describe('Stripe - Webhooks', () => {
       it('throws an error if the group leader is not found', async () => {
         const customerId = 456;
 
-        let subscriber = generateGroup({
+        const subscriber = generateGroup({
           name: 'test group',
           type: 'guild',
           privacy: 'public',
@@ -199,11 +201,12 @@ describe('Stripe - Webhooks', () => {
           request: null,
         });
 
-        await expect(stripePayments.handleWebhooks({requestBody: {}}, stripe)).to.eventually.be.rejectedWith({
-          message: i18n.t('userNotFound'),
-          httpCode: 404,
-          name: 'NotFound',
-        });
+        await expect(stripePayments.handleWebhooks({ requestBody: {} }, stripe))
+          .to.eventually.be.rejectedWith({
+            message: i18n.t('userNotFound'),
+            httpCode: 404,
+            name: 'NotFound',
+          });
 
         expect(stripe.customers.del).to.not.have.been.called;
         expect(payments.cancelSubscription).to.not.have.been.called;
@@ -214,10 +217,10 @@ describe('Stripe - Webhooks', () => {
       it('deletes the customer on Stripe and calls payments.cancelSubscription', async () => {
         const customerId = '456';
 
-        let leader = new User();
+        const leader = new User();
         await leader.save();
 
-        let subscriber = generateGroup({
+        const subscriber = generateGroup({
           name: 'test group',
           type: 'guild',
           privacy: 'public',
@@ -241,13 +244,13 @@ describe('Stripe - Webhooks', () => {
           request: null,
         });
 
-        await stripePayments.handleWebhooks({requestBody: {}}, stripe);
+        await stripePayments.handleWebhooks({ requestBody: {} }, stripe);
 
         expect(stripe.customers.del).to.have.been.calledOnce;
         expect(stripe.customers.del).to.have.been.calledWith(customerId);
         expect(payments.cancelSubscription).to.have.been.calledOnce;
 
-        let cancelSubscriptionOpts = payments.cancelSubscription.lastCall.args[0];
+        const cancelSubscriptionOpts = payments.cancelSubscription.lastCall.args[0];
         expect(cancelSubscriptionOpts.user._id).to.equal(leader._id);
         expect(cancelSubscriptionOpts.paymentMethod).to.equal('Stripe');
         expect(Math.round(moment(cancelSubscriptionOpts.nextBill).diff(new Date(), 'days', true))).to.equal(3);

test/api/unit/libs/payments/stripe/upgrade-group-plan.test.js

@@ -2,7 +2,7 @@ import stripeModule from 'stripe';
 
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import { model as Group } from '../../../../../../website/server/models/group';
 import stripePayments from '../../../../../../website/server/libs/payments/stripe';
@@ -10,9 +10,10 @@ import payments from '../../../../../../website/server/libs/payments/payments';
 
 describe('Stripe - Upgrade Group Plan', () => {
   const stripe = stripeModule('test');
-  let spy, data, user, group;
+  let spy; let data; let user; let
+    group;
 
-  beforeEach(async function () {
+  beforeEach(async () => {
     user = new User();
     user.profile.name = 'sender';
 
@@ -44,7 +45,7 @@ describe('Stripe - Upgrade Group Plan', () => {
     stripePayments.setStripeApi(stripe);
   });
 
-  afterEach(function () {
+  afterEach(() => {
     stripe.subscriptions.update.restore();
   });
 
@@ -52,7 +53,7 @@ describe('Stripe - Upgrade Group Plan', () => {
     data.paymentMethod = 'Stripe';
     await payments.createSubscription(data);
 
-    let updatedGroup = await Group.findById(group._id).exec();
+    const updatedGroup = await Group.findById(group._id).exec();
     expect(updatedGroup.purchased.plan.quantity).to.eql(3);
 
     updatedGroup.memberCount += 1;