fix test lint

test/api/unit/libs/payments/amazon/cancel.test.js

@@ -2,19 +2,20 @@ import moment from 'moment';
 
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import amzLib from '../../../../../../website/server/libs/payments/amazon';
 import payments from '../../../../../../website/server/libs/payments/payments';
 import common from '../../../../../../website/common';
 import { createNonLeaderGroupMember } from '../paymentHelpers';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('Amazon Payments - Cancel Subscription', () => {
   const subKey = 'basic_3mo';
 
-  let user, group, headers, billingAgreementId, subscriptionBlock, subscriptionLength;
+  let user; let group; let headers; let billingAgreementId; let subscriptionBlock; let
+    subscriptionLength;
   let getBillingAgreementDetailsSpy;
   let paymentCancelSubscriptionSpy;
 
@@ -50,7 +51,7 @@ describe('Amazon Payments - Cancel Subscription', () => {
     getBillingAgreementDetailsSpy = sinon.stub(amzLib, 'getBillingAgreementDetails')
       .resolves({
         BillingAgreementDetails: {
-          BillingAgreementStatus: {State: 'Open'},
+          BillingAgreementStatus: { State: 'Open' },
         },
       });
   }
@@ -81,7 +82,7 @@ describe('Amazon Payments - Cancel Subscription', () => {
     getBillingAgreementDetailsSpy = sinon.stub(amzLib, 'getBillingAgreementDetails');
     getBillingAgreementDetailsSpy.resolves({
       BillingAgreementDetails: {
-        BillingAgreementStatus: {State: 'Closed'},
+        BillingAgreementStatus: { State: 'Closed' },
       },
     });
 
@@ -89,7 +90,7 @@ describe('Amazon Payments - Cancel Subscription', () => {
     paymentCancelSubscriptionSpy.resolves({});
   });
 
-  afterEach(function () {
+  afterEach(() => {
     amzLib.getBillingAgreementDetails.restore();
     payments.cancelSubscription.restore();
   });
@@ -97,7 +98,7 @@ describe('Amazon Payments - Cancel Subscription', () => {
   it('should throw an error if we are missing a subscription', async () => {
     user.purchased.plan.customerId = undefined;
 
-    await expect(amzLib.cancelSubscription({user}))
+    await expect(amzLib.cancelSubscription({ user }))
       .to.eventually.be.rejected.and.to.eql({
         httpCode: 401,
         name: 'NotAuthorized',
@@ -108,7 +109,7 @@ describe('Amazon Payments - Cancel Subscription', () => {
   it('should cancel a user subscription', async () => {
     billingAgreementId = user.purchased.plan.customerId;
 
-    await amzLib.cancelSubscription({user, headers});
+    await amzLib.cancelSubscription({ user, headers });
 
     expectAmazonCancelUserSubscriptionSpy();
     expectAmazonStubs();
@@ -117,10 +118,10 @@ describe('Amazon Payments - Cancel Subscription', () => {
   it('should close a user subscription if amazon not closed', async () => {
     amzLib.getBillingAgreementDetails.restore();
     expectBillingAggreementDetailSpy();
-    let closeBillingAgreementSpy = sinon.stub(amzLib, 'closeBillingAgreement').resolves({});
+    const closeBillingAgreementSpy = sinon.stub(amzLib, 'closeBillingAgreement').resolves({});
     billingAgreementId = user.purchased.plan.customerId;
 
-    await amzLib.cancelSubscription({user, headers});
+    await amzLib.cancelSubscription({ user, headers });
 
     expectAmazonStubs();
     expect(closeBillingAgreementSpy).to.be.calledOnce;
@@ -132,7 +133,7 @@ describe('Amazon Payments - Cancel Subscription', () => {
   });
 
   it('should throw an error if group is not found', async () => {
-    await expect(amzLib.cancelSubscription({user, groupId: 'fake-id'}))
+    await expect(amzLib.cancelSubscription({ user, groupId: 'fake-id' }))
       .to.eventually.be.rejected.and.to.eql({
         httpCode: 404,
         name: 'NotFound',
@@ -141,9 +142,9 @@ describe('Amazon Payments - Cancel Subscription', () => {
   });
 
   it('should throw an error if user is not group leader', async () => {
-    let nonLeader = await createNonLeaderGroupMember(group);
+    const nonLeader = await createNonLeaderGroupMember(group);
 
-    await expect(amzLib.cancelSubscription({user: nonLeader, groupId: group._id}))
+    await expect(amzLib.cancelSubscription({ user: nonLeader, groupId: group._id }))
       .to.eventually.be.rejected.and.to.eql({
         httpCode: 401,
         name: 'NotAuthorized',
@@ -154,7 +155,7 @@ describe('Amazon Payments - Cancel Subscription', () => {
   it('should cancel a group subscription', async () => {
     billingAgreementId = group.purchased.plan.customerId;
 
-    await amzLib.cancelSubscription({user, groupId: group._id, headers});
+    await amzLib.cancelSubscription({ user, groupId: group._id, headers });
 
     expectAmazonCancelGroupSubscriptionSpy(group._id);
     expectAmazonStubs();
@@ -163,10 +164,10 @@ describe('Amazon Payments - Cancel Subscription', () => {
   it('should close a group subscription if amazon not closed', async () => {
     amzLib.getBillingAgreementDetails.restore();
     expectBillingAggreementDetailSpy();
-    let closeBillingAgreementSpy = sinon.stub(amzLib, 'closeBillingAgreement').resolves({});
+    const closeBillingAgreementSpy = sinon.stub(amzLib, 'closeBillingAgreement').resolves({});
     billingAgreementId = group.purchased.plan.customerId;
 
-    await amzLib.cancelSubscription({user, groupId: group._id, headers});
+    await amzLib.cancelSubscription({ user, groupId: group._id, headers });
 
     expectAmazonStubs();
     expect(closeBillingAgreementSpy).to.be.calledOnce;

test/api/unit/libs/payments/amazon/checkout.test.js

@@ -3,11 +3,12 @@ import amzLib from '../../../../../../website/server/libs/payments/amazon';
 import payments from '../../../../../../website/server/libs/payments/payments';
 import common from '../../../../../../website/common';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('Amazon Payments - Checkout', () => {
   const subKey = 'basic_3mo';
-  let user, orderReferenceId, headers;
+  let user; let orderReferenceId; let
+    headers;
   let setOrderReferenceDetailsSpy;
   let confirmOrderReferenceSpy;
   let authorizeSpy;
@@ -62,7 +63,7 @@ describe('Amazon Payments - Checkout', () => {
     expect(closeOrderReferenceSpy).to.be.calledWith({ AmazonOrderReferenceId: orderReferenceId });
   }
 
-  beforeEach(function () {
+  beforeEach(() => {
     user = new User();
     headers = {};
     orderReferenceId = 'orderReferenceId';
@@ -88,7 +89,7 @@ describe('Amazon Payments - Checkout', () => {
     sinon.stub(common, 'uuid').returns('uuid-generated');
   });
 
-  afterEach(function () {
+  afterEach(() => {
     amzLib.setOrderReferenceDetails.restore();
     amzLib.confirmOrderReference.restore();
     amzLib.authorize.restore();
@@ -101,7 +102,7 @@ describe('Amazon Payments - Checkout', () => {
   function expectBuyGemsStub (paymentMethod, gift) {
     expect(paymentBuyGemsStub).to.be.calledOnce;
 
-    let expectedArgs = {
+    const expectedArgs = {
       user,
       paymentMethod,
       headers,
@@ -112,7 +113,7 @@ describe('Amazon Payments - Checkout', () => {
 
   it('should purchase gems', async () => {
     sinon.stub(user, 'canGetGems').resolves(true);
-    await amzLib.checkout({user, orderReferenceId, headers});
+    await amzLib.checkout({ user, orderReferenceId, headers });
 
     expectBuyGemsStub(amzLib.constants.PAYMENT_METHOD);
     expectAmazonStubs();
@@ -121,9 +122,9 @@ describe('Amazon Payments - Checkout', () => {
   });
 
   it('should error if gem amount is too low', async () => {
-    let receivingUser = new User();
+    const receivingUser = new User();
     receivingUser.save();
-    let gift = {
+    const gift = {
       type: 'gems',
       gems: {
         amount: 0,
@@ -131,7 +132,9 @@ describe('Amazon Payments - Checkout', () => {
       },
     };
 
-    await expect(amzLib.checkout({gift, user, orderReferenceId, headers}))
+    await expect(amzLib.checkout({
+      gift, user, orderReferenceId, headers,
+    }))
       .to.eventually.be.rejected.and.to.eql({
         httpCode: 400,
         message: 'Amount must be at least 1.',
@@ -141,18 +144,19 @@ describe('Amazon Payments - Checkout', () => {
 
   it('should error if user cannot get gems gems', async () => {
     sinon.stub(user, 'canGetGems').resolves(false);
-    await expect(amzLib.checkout({user, orderReferenceId, headers})).to.eventually.be.rejected.and.to.eql({
-      httpCode: 401,
-      message: i18n.t('groupPolicyCannotGetGems'),
-      name: 'NotAuthorized',
-    });
+    await expect(amzLib.checkout({ user, orderReferenceId, headers }))
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 401,
+        message: i18n.t('groupPolicyCannotGetGems'),
+        name: 'NotAuthorized',
+      });
     user.canGetGems.restore();
   });
 
   it('should gift gems', async () => {
-    let receivingUser = new User();
+    const receivingUser = new User();
     await receivingUser.save();
-    let gift = {
+    const gift = {
       type: 'gems',
       uuid: receivingUser._id,
       gems: {
@@ -160,16 +164,18 @@ describe('Amazon Payments - Checkout', () => {
       },
     };
     amount = 16 / 4;
-    await amzLib.checkout({gift, user, orderReferenceId, headers});
+    await amzLib.checkout({
+      gift, user, orderReferenceId, headers,
+    });
 
     expectBuyGemsStub(amzLib.constants.PAYMENT_METHOD_GIFT, gift);
     expectAmazonStubs();
   });
 
   it('should gift a subscription', async () => {
-    let receivingUser = new User();
+    const receivingUser = new User();
     receivingUser.save();
-    let gift = {
+    const gift = {
       type: 'subscription',
       subscription: {
         key: subKey,
@@ -178,7 +184,9 @@ describe('Amazon Payments - Checkout', () => {
     };
     amount = common.content.subscriptionBlocks[subKey].price;
 
-    await amzLib.checkout({user, orderReferenceId, headers, gift});
+    await amzLib.checkout({
+      user, orderReferenceId, headers, gift,
+    });
 
     gift.member = receivingUser;
     expect(paymentCreateSubscritionStub).to.be.calledOnce;

test/api/unit/libs/payments/amazon/subscribe.test.js

@@ -2,18 +2,19 @@ import cc from 'coupon-code';
 
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import { model as Coupon } from '../../../../../../website/server/models/coupon';
 import amzLib from '../../../../../../website/server/libs/payments/amazon';
 import payments from '../../../../../../website/server/libs/payments/payments';
 import common from '../../../../../../website/common';
 
-const i18n = common.i18n;
+const { i18n } = common;
 
 describe('Amazon Payments - Subscribe', () => {
   const subKey = 'basic_3mo';
-  let user, group, amount, billingAgreementId, sub, coupon, groupId, headers;
+  let user; let group; let amount; let billingAgreementId; let sub; let coupon; let groupId; let
+    headers;
   let amazonSetBillingAgreementDetailsSpy;
   let amazonConfirmBillingAgreementSpy;
   let amazonAuthorizeOnBillingAgreementSpy;
@@ -60,7 +61,7 @@ describe('Amazon Payments - Subscribe', () => {
     sinon.stub(common, 'uuid').returns('uuid-generated');
   });
 
-  afterEach(function () {
+  afterEach(() => {
     amzLib.setBillingAgreementDetails.restore();
     amzLib.confirmBillingAgreement.restore();
     amzLib.authorizeOnBillingAgreement.restore();
@@ -168,7 +169,7 @@ describe('Amazon Payments - Subscribe', () => {
     sub.key = 'google_6mo';
     coupon = 'example-coupon';
 
-    let couponModel = new Coupon();
+    const couponModel = new Coupon();
     couponModel.event = 'google_6mo';
     await couponModel.save();
 
@@ -195,9 +196,9 @@ describe('Amazon Payments - Subscribe', () => {
     sub.key = 'google_6mo';
     coupon = 'example-coupon';
 
-    let couponModel = new Coupon();
+    const couponModel = new Coupon();
     couponModel.event = 'google_6mo';
-    let updatedCouponModel = await couponModel.save();
+    const updatedCouponModel = await couponModel.save();
 
     sinon.stub(cc, 'validate').returns(updatedCouponModel._id);
 

test/api/unit/libs/payments/amazon/upgrade-groupplan.test.js

@@ -2,16 +2,17 @@ import uuid from 'uuid';
 
 import {
   generateGroup,
-} from '../../../../../helpers/api-unit.helper.js';
+} from '../../../../../helpers/api-unit.helper';
 import { model as User } from '../../../../../../website/server/models/user';
 import { model as Group } from '../../../../../../website/server/models/group';
 import amzLib from '../../../../../../website/server/libs/payments/amazon';
 import payments from '../../../../../../website/server/libs/payments/payments';
 
 describe('#upgradeGroupPlan', () => {
-  let spy, data, user, group, uuidString;
+  let spy; let data; let user; let group; let
+    uuidString;
 
-  beforeEach(async function () {
+  beforeEach(async () => {
     user = new User();
     user.profile.name = 'sender';
 
@@ -46,7 +47,7 @@ describe('#upgradeGroupPlan', () => {
     data.sub.quantity = 3;
   });
 
-  afterEach(function () {
+  afterEach(() => {
     amzLib.authorizeOnBillingAgreement.restore();
     uuid.v4.restore();
   });
@@ -55,7 +56,7 @@ describe('#upgradeGroupPlan', () => {
     data.paymentMethod = amzLib.constants.PAYMENT_METHOD;
     await payments.createSubscription(data);
 
-    let updatedGroup = await Group.findById(group._id).exec();
+    const updatedGroup = await Group.findById(group._id).exec();
 
     updatedGroup.memberCount += 1;
     await updatedGroup.save();