krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 22:57:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: Send author's email when sending flag notification to slack

Browse Source
This commit is contained in:
Blade Barringer
2016-09-30 07:42:51 -05:00
parent 461e7445c2
commit 8465dd69be
3 changed files with 35 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
test/api/v3/unit/libs/slack.js
View File

@@ -8,27 +8,30 @@ import nconf from 'nconf';
describe('slack', () => {
describe('sendFlagNotification', () => {
let flagger, group, message;
let data;
beforeEach(() => {
sandbox.stub(IncomingWebhook.prototype, 'send');
flagger = {
id: 'flagger-id',
profile: {
name: 'flagger',
data = {
authorEmail: 'author@example.com',
flagger: {
id: 'flagger-id',
profile: {
name: 'flagger',
},
},
group: {
id: 'group-id',
privacy: 'private',
name: 'Some group',
type: 'guild',
},
message: {
id: 'chat-id',
user: 'Author',
uuid: 'author-id',
text: 'some text',
},
};
group = {
id: 'group-id',
privacy: 'private',
name: 'Some group',
type: 'guild',
};
message = {
id: 'chat-id',
user: 'Author',
uuid: 'author-id',
text: 'some text',
};
});
@@ -37,11 +40,7 @@ describe('slack', () => {
});
it('sends a slack webhook', () => {
slack.sendFlagNotification({
flagger,
group,
message,
});
slack.sendFlagNotification(data);
expect(IncomingWebhook.prototype.send).to.be.calledOnce;
expect(IncomingWebhook.prototype.send).to.be.calledWith({
@@ -49,7 +48,7 @@ describe('slack', () => {
attachments: [{
fallback: 'Flag Message',
color: 'danger',
author_name: 'Author - author-id',
author_name: 'Author - author@example.com - author-id',
title: 'Flag in Some group - (private guild)',
title_link: undefined,
text: 'some text',
@@ -62,13 +61,9 @@ describe('slack', () => {
});
it('includes a title link if guild is public', () => {
group.privacy = 'public';
data.group.privacy = 'public';
slack.sendFlagNotification({
flagger,
group,
message,
});
slack.sendFlagNotification(data);
expect(IncomingWebhook.prototype.send).to.be.calledWithMatch({
attachments: [sandbox.match({
@@ -79,15 +74,11 @@ describe('slack', () => {
});
it('links to tavern', () => {
group.privacy = 'public';
group.name = 'Tavern';
group.id = TAVERN_ID;
data.group.privacy = 'public';
data.group.name = 'Tavern';
data.group.id = TAVERN_ID;
slack.sendFlagNotification({
flagger,
group,
message,
});
slack.sendFlagNotification(data);
expect(IncomingWebhook.prototype.send).to.be.calledWithMatch({
attachments: [sandbox.match({
@@ -98,14 +89,10 @@ describe('slack', () => {
});
it('provides name for system message', () => {
message.uuid = 'system';
delete message.user;
data.message.uuid = 'system';
delete data.message.user;
slack.sendFlagNotification({
flagger,
group,
message,
});
slack.sendFlagNotification(data);
expect(IncomingWebhook.prototype.send).to.be.calledWithMatch({
attachments: [sandbox.match({
@@ -121,11 +108,7 @@ describe('slack', () => {
expect(logger.error).to.be.calledOnce;
reRequiredSlack.sendFlagNotification({
flagger,
group,
message,
});
reRequiredSlack.sendFlagNotification(data);
expect(IncomingWebhook.prototype.send).to.not.be.called;
});