optimize mention highlighting

website/client/components/groups/chat.vue

@@ -186,13 +186,6 @@
         }
         this.newMessage = innerText;
       },
-      getTierIcon (member) {
-        const isNPC = Boolean(member.backer && member.backer.npc);
-        if (isNPC) {
-          return this.icons.tierNPC;
-        }
-        return this.icons[`tier${member.contributor.level}`];
-      },
     },
     beforeRouteUpdate (to, from, next) {
       // Reset chat

website/server/controllers/api-v3/chat.js

@@ -178,7 +178,7 @@ api.postChat = {
       throw new NotAuthorized(res.t('messageGroupChatSpam'));
     }
 
-    const message = await highlightMentions(req.body.message);
+    const [message, mentions] = await highlightMentions(req.body.message);
     let client = req.headers['x-client'] || '3rd Party';
     if (client) {
       client = client.replace('habitica-', '');
@@ -203,7 +203,6 @@ api.postChat = {
       headers: req.headers,
     };
 
-    const mentions = req.body.message.match(mentionRegex);
     if (mentions) {
       analyticsObject.mentionsCount = mentions.length;
     } else {

website/server/libs/highlightMentions.js

@@ -18,5 +18,5 @@ export async function highlightMentions (text) {
       text = text.replace(new RegExp(`@${username}(?![\\-\\w])`, 'g'), `[@${username}](/profile/${member._id})`);
     });
   }
-  return text;
+  return [text, mentions];
 }