krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 07:07:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(lint): why weren't we destructuring already

Browse Source
This commit is contained in:
SabreCat
2023-08-01 17:20:00 -05:00
parent d7071d6b4d
commit 81be8316a0
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/api/v3/integration/groups/POST-groups_groupId_leave.test.js
View File

@@ -28,7 +28,7 @@ describe('POST /groups/:groupId/leave', () => {
upgradeToGroupPlan: true, upgradeToGroupPlan: true,
})); }));
member = members[0]; // eslint-disable-line prefer-destructuring [member] = members;
memberCount = groupToLeave.memberCount; memberCount = groupToLeave.memberCount;
await leader.update({ 'auth.timestamps.created': new Date('2022-01-01') }); await leader.update({ 'auth.timestamps.created': new Date('2022-01-01') });
}); });
@@ -120,15 +120,20 @@ describe('POST /groups/:groupId/leave', () => {
let invitedUser; let invitedUser;
beforeEach(async () => { beforeEach(async () => {
({ group: groupToLeave, groupLeader: leader, members, invitees } = await createAndPopulateGroup({ ({
group: groupToLeave,
groupLeader: leader,
members,
invitees,
} = await createAndPopulateGroup({
type: 'party', type: 'party',
privacy: 'private', privacy: 'private',
members: 1, members: 1,
invites: 1, invites: 1,
})); }));
member = members[0]; // eslint-disable-line prefer-destructuring [member] = members;
invitedUser = invitees[0]; [invitedUser] = invitees;
memberCount = groupToLeave.memberCount; memberCount = groupToLeave.memberCount;
await leader.update({ 'auth.timestamps.created': new Date('2022-01-01') }); await leader.update({ 'auth.timestamps.created': new Date('2022-01-01') });
}); });
@@ -260,8 +265,6 @@ describe('POST /groups/:groupId/leave', () => {
each(typesOfGroups, (groupDetails, groupType) => { each(typesOfGroups, (groupDetails, groupType) => {
context(`Leaving a group plan when the group is a ${groupType}`, () => { context(`Leaving a group plan when the group is a ${groupType}`, () => {
let groupWithPlan; let groupWithPlan;
let leader;
let member;
beforeEach(async () => { beforeEach(async () => {
const { group, groupLeader, members } = await createAndPopulateGroup({ const { group, groupLeader, members } = await createAndPopulateGroup({
@@ -270,7 +273,7 @@ describe('POST /groups/:groupId/leave', () => {
upgradeToGroupPlan: true, upgradeToGroupPlan: true,
}); });
leader = groupLeader; leader = groupLeader;
member = members[0]; // eslint-disable-line prefer-destructuring [member] = members;
groupWithPlan = group; groupWithPlan = group;
const userWithFreePlan = await User.findById(leader._id).exec(); const userWithFreePlan = await User.findById(leader._id).exec();
@@ -309,7 +312,6 @@ describe('POST /groups/:groupId/leave', () => {
if (groupDetails.privacy === 'public') return; // public guilds cannot be group plans if (groupDetails.privacy === 'public') return; // public guilds cannot be group plans
const extraMonths = 12; const extraMonths = 12;
let groupWithPlan; let groupWithPlan;
let member;
beforeEach(async () => { beforeEach(async () => {
const { group, members } = await createAndPopulateGroup({ const { group, members } = await createAndPopulateGroup({