krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 07:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

add tests, move CustomError to common, fix casting

Browse Source
This commit is contained in:
Matteo Pagliazzi
2016-03-03 00:16:28 +01:00
parent 05b6e25c28
commit 80f791c86b
11 changed files with 260 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/api/v3/unit/middlewares/errorHandler.test.js
View File

@@ -9,6 +9,7 @@ import responseMiddleware from '../../../../../website/src/middlewares/api-v3/re
import getUserLanguage from '../../../../../website/src/middlewares/api-v3/getUserLanguage';
import { BadRequest } from '../../../../../website/src/libs/api-v3/errors';
import { NotAuthorized as NotAuthorizedShared } from '../../../../../common/script/api-v3/errors';
import logger from '../../../../../website/src/libs/api-v3/logger';
describe('errorHandler', () => {
@@ -86,6 +87,21 @@ describe('errorHandler', () => {
});
});
it('handle CustomError(s) from shared code', () => {
let error = new NotAuthorizedShared();
errorHandler(error, req, res, next);
expect(res.status).to.be.calledOnce;
expect(res.json).to.be.calledOnce;
expect(res.status).to.be.calledWith(400);
expect(res.json).to.be.calledWith({
error: 'NotAuthorized',
message: 'Not authorized.',
});
});
it('handle http-errors errors', () => {
let error = new Error('custom message');
error.statusCode = 422;