krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(analytics): Tweaks per code review

Browse Source
This commit is contained in:
Sabe Jones
2015-07-28 13:26:39 -05:00
parent f6bbae3beb
commit 7c56f5e7f6
3 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/server_side/analytics.test.js
View File

@@ -221,7 +221,8 @@ describe('analytics', function() {
var user = { var user = {
stats: stats, stats: stats,
contributor: { level: 1 }, contributor: { level: 1 },
purchased: { plan: { planId: 'foo-plan' } } purchased: { plan: { planId: 'foo-plan' } },
flags: {tour: {intro: -2}}
}; };
analyticsData.user = user; analyticsData.user = user;
@@ -246,7 +247,8 @@ describe('analytics', function() {
Level: 4, Level: 4,
Mana: 30, Mana: 30,
contributorLevel: 1, contributorLevel: 1,
subscription: 'foo-plan' subscription: 'foo-plan',
tutorialComplete: true
} }
}); });
}); });

3
website/public/js/services/analyticsServices.js
View File

@@ -107,8 +107,7 @@
properties.Level = user.stats.lvl; properties.Level = user.stats.lvl;
properties.Mana = Math.floor(user.stats.mp); properties.Mana = Math.floor(user.stats.mp);
} }
if (user.flags && user.flags.tour && user.flags.tour.intro === -2) {properties.tutorialComplete = true} properties.tutorialComplete = user.flags && user.flags.tour && user.flags.tour.intro === -2;
else {properties.tutorialComplete = false};
if (user.contributor && user.contributor.level) properties.contributorLevel = user.contributor.level; if (user.contributor && user.contributor.level) properties.contributorLevel = user.contributor.level;
if (user.purchased && user.purchased.plan.planId) properties.subscription = user.purchased.plan.planId; if (user.purchased && user.purchased.plan.planId) properties.subscription = user.purchased.plan.planId;
} }

2
website/src/analytics.js
View File

@@ -152,6 +152,8 @@ function _formatUserData(user) {
properties.Mana = Math.floor(user.stats.mp); properties.Mana = Math.floor(user.stats.mp);
} }
properties.tutorialComplete = user.flags && user.flags.tour && user.flags.tour.intro === -2;
if (user.contributor && user.contributor.level) { if (user.contributor && user.contributor.level) {
properties.contributorLevel = user.contributor.level; properties.contributorLevel = user.contributor.level;
} }