krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-15 13:47:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue with l4p not resetting properly (#15240)

Browse Source 
* actually clear out seeking field on user. Even when creating a party

* Add tests to ensure party.seeking is cleared

* fix(lint): don't assign unused const

---------

Co-authored-by: Sabe Jones <sabe@habitica.com>
This commit is contained in:
Phillip Thelen
2024-06-11 00:00:31 +02:00
committed by GitHub
parent 37f08c4534
commit 758b6138c2
3 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/api/v3/integration/groups/POST-groups.test.js
View File

@@ -145,6 +145,18 @@ describe('POST /group', () => {
expect(updatedUser.party._id).to.eql(party._id);
});
it('removes seeking from user', async () => {
await user.updateOne({ 'party.seeking': new Date() });
await user.post('/groups', {
name: partyName,
type: partyType,
});
const updatedUser = await user.get('/user');
expect(updatedUser.party.seeking).to.not.exist;
});
it('does not award Party Up achievement to solo partier', async () => {
await user.post('/groups', {
name: partyName,

9
test/api/v3/integration/groups/POST-groups_groupId_join.test.js
View File

@@ -178,6 +178,15 @@ describe('POST /group/:groupId/join', () => {
await expect(invitedUser.get('/user')).to.eventually.not.have.nested.property('invitations.parties[0].id');
});
it('clears party.seeking from user when joining party', async () => {
await invitedUser.updateOne({ 'party.seeking': new Date() });
await invitedUser.post(`/groups/${party._id}/join`);
const updatedUser = await invitedUser.get('/user');
await expect(updatedUser.party.seeking).to.not.exist;
});
it('increments memberCount when joining party', async () => {
const oldMemberCount = party.memberCount;

3
website/server/controllers/api-v3/groups.js
View File

@@ -136,6 +136,7 @@ api.createGroup = {
if (user.party._id) throw new NotAuthorized(res.t('messageGroupAlreadyInParty'));
user.party._id = group._id;
user.party.seeking = undefined;
}
let savedGroup;
@@ -590,7 +591,7 @@ api.joinGroup = {
// Clear all invitations of new user and reset looking for party state
user.invitations.parties = [];
user.invitations.party = {};
user.party.seeking = null;
user.party.seeking = undefined;
// invite new user to pending quest
if (group.quest.key && !group.quest.active) {