Upgrade tests tools and lint migrations and scripts (part 2) (#9998)

* upgrade gulp-babel

* upgrade babel-eslint

* upgrade eslint-friendly-formatter

* start upgrading chai

* start to upgrade eslint

* restore skipped tests

* start to upgrqde monk

* fix linting and remove unused file

* fix mocha notifications, and common tests

* fix unit tests

* start to fix initrgration tests

* more integration tests fixes

* upgrade monk to latest version

* lint /scripts

* migrations: start moving to /archive unused migrations and run eslint with --fix

* lint migrations

* fix more integration tests

* fix test

test/api/v3/unit/libs/apiMessages.js

@@ -14,7 +14,7 @@ describe('API Messages', () => {
     let vars = {a: 1};
     sandbox.stub(_, 'clone').returns({});
     apiMessages('guildsOnlyPaginate', vars);
-    expect(_.clone).to.have.been.called.once;
+    expect(_.clone).to.have.been.calledOnce;
     expect(_.clone).to.have.been.calledWith(vars);
   });
 
@@ -23,9 +23,9 @@ describe('API Messages', () => {
     let stub = sinon.stub().returns('string');
     sandbox.stub(_, 'template').returns(stub);
     apiMessages('guildsOnlyPaginate', vars);
-    expect(_.template).to.have.been.called.once;
+    expect(_.template).to.have.been.calledOnce;
     expect(_.template).to.have.been.calledWith(message);
-    expect(stub).to.have.been.called.once;
+    expect(stub).to.have.been.calledOnce;
     expect(stub).to.have.been.calledWith(vars);
   });
 });

test/api/v3/unit/libs/collectionManipulators.test.js

@@ -1,6 +1,6 @@
 import mongoose from 'mongoose';
 import {
- removeFromArray,
+  removeFromArray,
 } from '../../../../../website/server/libs/collectionManipulators';
 
 describe('Collection Manipulators', () => {

test/api/v3/unit/libs/cron.test.js

@@ -181,9 +181,9 @@ describe('cron', () => {
       cron({user, tasksByType, daysMissed, analytics});
 
       expect(user.purchased.plan.customerId).to.not.exist;
-      expect(user.purchased.plan.consecutive.gemCapExtra).to.be.empty;
-      expect(user.purchased.plan.consecutive.count).to.be.empty;
-      expect(user.purchased.plan.consecutive.offset).to.be.empty;
+      expect(user.purchased.plan.consecutive.gemCapExtra).to.equal(0);
+      expect(user.purchased.plan.consecutive.count).to.equal(0);
+      expect(user.purchased.plan.consecutive.offset).to.equal(0);
     });
   });
 
@@ -1027,7 +1027,7 @@ describe('cron', () => {
       cron({user, tasksByType, daysMissed, analytics});
       expect(user.party.quest.progress.up).to.equal(0);
       expect(user.party.quest.progress.down).to.equal(0);
-      expect(user.party.quest.progress.collectedItems).to.be.empty;
+      expect(user.party.quest.progress.collectedItems).to.equal(0);
     });
 
     it('applies the user progress', () => {

test/api/v3/unit/libs/payments/amazon/checkout.test.js

@@ -132,11 +132,11 @@ describe('Amazon Payments - Checkout', () => {
     };
 
     await expect(amzLib.checkout({gift, user, orderReferenceId, headers}))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      message: 'Amount must be at least 1.',
-      name: 'BadRequest',
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        message: 'Amount must be at least 1.',
+        name: 'BadRequest',
+      });
   });
 
   it('should error if user cannot get gems gems', async () => {

test/api/v3/unit/libs/payments/amazon/subscribe.test.js

@@ -123,11 +123,11 @@ describe('Amazon Payments - Subscribe', () => {
       groupId,
       headers,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      name: 'BadRequest',
-      message: i18n.t('missingSubscriptionCode'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        name: 'BadRequest',
+        message: i18n.t('missingSubscriptionCode'),
+      });
   });
 
   it('should throw an error if we are missing a billingAgreementId', async () => {
@@ -138,11 +138,11 @@ describe('Amazon Payments - Subscribe', () => {
       groupId,
       headers,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      name: 'BadRequest',
-      message: 'Missing req.body.billingAgreementId',
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        name: 'BadRequest',
+        message: 'Missing req.body.billingAgreementId',
+      });
   });
 
   it('should throw an error when coupon code is missing', async () => {
@@ -156,11 +156,11 @@ describe('Amazon Payments - Subscribe', () => {
       groupId,
       headers,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      name: 'BadRequest',
-      message: i18n.t('couponCodeRequired'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        name: 'BadRequest',
+        message: i18n.t('couponCodeRequired'),
+      });
   });
 
   it('should throw an error when coupon code is invalid', async () => {
@@ -182,11 +182,11 @@ describe('Amazon Payments - Subscribe', () => {
       groupId,
       headers,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 401,
-      name: 'NotAuthorized',
-      message: i18n.t('invalidCoupon'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 401,
+        name: 'NotAuthorized',
+        message: i18n.t('invalidCoupon'),
+      });
     cc.validate.restore();
   });
 

test/api/v3/unit/libs/payments/group-plans/group-payments-create.test.js

@@ -305,7 +305,7 @@ describe('Purchasing a group plan for group', () => {
 
     await api.createSubscription(data);
 
-    expect(sender.sendTxn).to.be.calledFourTimes;
+    expect(sender.sendTxn).to.have.callCount(4);
     expect(sender.sendTxn.args[0][0]._id).to.equal(TECH_ASSISTANCE_EMAIL);
     expect(sender.sendTxn.args[0][1]).to.equal('admin-user-subscription-details');
     expect(sender.sendTxn.args[1][0]._id).to.equal(recipient._id);
@@ -338,7 +338,7 @@ describe('Purchasing a group plan for group', () => {
 
     await api.createSubscription(data);
 
-    expect(sender.sendTxn).to.be.calledFourTimes;
+    expect(sender.sendTxn).to.have.callCount(4);
     expect(sender.sendTxn.args[0][0]._id).to.equal(TECH_ASSISTANCE_EMAIL);
     expect(sender.sendTxn.args[0][1]).to.equal('admin-user-subscription-details');
     expect(sender.sendTxn.args[1][0]._id).to.equal(recipient._id);

test/api/v3/unit/libs/payments/paypal/checkout.test.js

@@ -71,11 +71,11 @@ describe('checkout', () => {
     };
 
     await expect(paypalPayments.checkout({gift}))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      message: 'Amount must be at least 1.',
-      name: 'BadRequest',
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        message: 'Amount must be at least 1.',
+        name: 'BadRequest',
+      });
   });
 
   it('should error if the user cannot get gems', async () => {

test/api/v3/unit/libs/payments/stripe/cancel-subscription.test.js

@@ -42,11 +42,11 @@ describe('cancel subscription', () => {
       user,
       groupId: undefined,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 401,
-      name: 'NotAuthorized',
-      message: i18n.t('missingSubscription'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 401,
+        name: 'NotAuthorized',
+        message: i18n.t('missingSubscription'),
+      });
   });
 
   it('throws an error if the group is not found', async () => {
@@ -54,11 +54,11 @@ describe('cancel subscription', () => {
       user,
       groupId: 'fake-group',
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 404,
-      name: 'NotFound',
-      message: i18n.t('groupNotFound'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 404,
+        name: 'NotFound',
+        message: i18n.t('groupNotFound'),
+      });
   });
 
   it('throws an error if user is not the group leader', async () => {
@@ -70,11 +70,11 @@ describe('cancel subscription', () => {
       user: nonLeader,
       groupId,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 401,
-      name: 'NotAuthorized',
-      message: i18n.t('onlyGroupLeaderCanManageSubscription'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 401,
+        name: 'NotAuthorized',
+        message: i18n.t('onlyGroupLeaderCanManageSubscription'),
+      });
   });
 
   describe('success', () => {

test/api/v3/unit/libs/payments/stripe/checkout-subscription.test.js

@@ -88,11 +88,11 @@ describe('checkout with subscription', () => {
       headers,
       coupon,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      name: 'BadRequest',
-      message: 'Missing req.body.id',
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        name: 'BadRequest',
+        message: 'Missing req.body.id',
+      });
   });
 
   it('should throw an error when coupon code is missing', async () => {
@@ -108,11 +108,11 @@ describe('checkout with subscription', () => {
       headers,
       coupon,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      name: 'BadRequest',
-      message: i18n.t('couponCodeRequired'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        name: 'BadRequest',
+        message: i18n.t('couponCodeRequired'),
+      });
   });
 
   it('should throw an error when coupon code is invalid', async () => {
@@ -136,11 +136,11 @@ describe('checkout with subscription', () => {
       headers,
       coupon,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      name: 'BadRequest',
-      message: i18n.t('invalidCoupon'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        name: 'BadRequest',
+        message: i18n.t('invalidCoupon'),
+      });
     cc.validate.restore();
   });
 

test/api/v3/unit/libs/payments/stripe/checkout.test.js

@@ -57,11 +57,11 @@ describe('checkout', () => {
       headers,
       coupon,
     }, stripe))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      message: 'Amount must be at least 1.',
-      name: 'BadRequest',
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        message: 'Amount must be at least 1.',
+        name: 'BadRequest',
+      });
   });
 
 

test/api/v3/unit/libs/payments/stripe/edit-subscription.test.js

@@ -43,11 +43,11 @@ describe('edit subscription', () => {
       user,
       groupId: undefined,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 401,
-      name: 'NotAuthorized',
-      message: i18n.t('missingSubscription'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 401,
+        name: 'NotAuthorized',
+        message: i18n.t('missingSubscription'),
+      });
   });
 
   it('throws an error if a token is not provided', async () => {
@@ -55,11 +55,11 @@ describe('edit subscription', () => {
       user,
       groupId: undefined,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 400,
-      name: 'BadRequest',
-      message: 'Missing req.body.id',
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 400,
+        name: 'BadRequest',
+        message: 'Missing req.body.id',
+      });
   });
 
   it('throws an error if the group is not found', async () => {
@@ -68,11 +68,11 @@ describe('edit subscription', () => {
       user,
       groupId: 'fake-group',
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 404,
-      name: 'NotFound',
-      message: i18n.t('groupNotFound'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 404,
+        name: 'NotFound',
+        message: i18n.t('groupNotFound'),
+      });
   });
 
   it('throws an error if user is not the group leader', async () => {
@@ -85,11 +85,11 @@ describe('edit subscription', () => {
       user: nonLeader,
       groupId,
     }))
-    .to.eventually.be.rejected.and.to.eql({
-      httpCode: 401,
-      name: 'NotAuthorized',
-      message: i18n.t('onlyGroupLeaderCanManageSubscription'),
-    });
+      .to.eventually.be.rejected.and.to.eql({
+        httpCode: 401,
+        name: 'NotAuthorized',
+        message: i18n.t('onlyGroupLeaderCanManageSubscription'),
+      });
   });
 
   describe('success', () => {

test/api/v3/unit/libs/payments/stripe/handle-webhook.test.js

@@ -34,7 +34,7 @@ describe('Stripe - Webhooks', () => {
     it('logs an error if an unsupported webhook event is passed', async () => {
       const error = new Error(`Missing handler for Stripe webhook ${eventType}`);
       await stripePayments.handleWebhooks({requestBody: event}, stripe);
-      expect(logger.error).to.have.been.called.once;
+      expect(logger.error).to.have.been.calledOnce;
 
       const calledWith = logger.error.getCall(0).args;
       expect(calledWith[0].message).to.equal(error.message);
@@ -43,7 +43,7 @@ describe('Stripe - Webhooks', () => {
 
     it('retrieves and validates the event from Stripe', async () => {
       await stripePayments.handleWebhooks({requestBody: event}, stripe);
-      expect(stripe.events.retrieve).to.have.been.called.once;
+      expect(stripe.events.retrieve).to.have.been.calledOnce;
       expect(stripe.events.retrieve).to.have.been.calledWith(event.id);
     });
   });
@@ -70,7 +70,7 @@ describe('Stripe - Webhooks', () => {
 
       await stripePayments.handleWebhooks({requestBody: {}}, stripe);
 
-      expect(stripe.events.retrieve).to.have.been.called.once;
+      expect(stripe.events.retrieve).to.have.been.calledOnce;
       expect(stripe.customers.del).to.not.have.been.called;
       expect(payments.cancelSubscription).to.not.have.been.called;
       stripe.events.retrieve.restore();

test/api/v3/unit/libs/taskManager.js

@@ -54,7 +54,7 @@ describe('taskManager', () => {
     expect(newTask.type).to.equal(testHabit.type);
     expect(newTask.up).to.equal(testHabit.up);
     expect(newTask.down).to.equal(testHabit.down);
-    expect(newTask.createdAt).isNotEmtpy;
+    expect(newTask.createdAt).to.exist;
   });
 
   it('gets user tasks', async () => {
@@ -75,7 +75,7 @@ describe('taskManager', () => {
     expect(task.type).to.equal(testHabit.type);
     expect(task.up).to.equal(testHabit.up);
     expect(task.down).to.equal(testHabit.down);
-    expect(task.createdAt).isNotEmtpy;
+    expect(task.createdAt).to.exist;
   });
 
   it('creates group tasks', async () => {
@@ -89,7 +89,7 @@ describe('taskManager', () => {
     expect(newTask.type).to.equal(testHabit.type);
     expect(newTask.up).to.equal(testHabit.up);
     expect(newTask.down).to.equal(testHabit.down);
-    expect(newTask.createdAt).isNotEmtpy;
+    expect(newTask.createdAt).to.exist;
     expect(newTask.group.id).to.equal(group._id);
   });
 
@@ -111,7 +111,7 @@ describe('taskManager', () => {
     expect(task.type).to.equal(testHabit.type);
     expect(task.up).to.equal(testHabit.up);
     expect(task.down).to.equal(testHabit.down);
-    expect(task.createdAt).isNotEmtpy;
+    expect(task.createdAt).to.exist;
     expect(task.group.id).to.equal(group._id);
   });
 
@@ -126,7 +126,7 @@ describe('taskManager', () => {
     expect(newTask.type).to.equal(testHabit.type);
     expect(newTask.up).to.equal(testHabit.up);
     expect(newTask.down).to.equal(testHabit.down);
-    expect(newTask.createdAt).isNotEmtpy;
+    expect(newTask.createdAt).to.exist;
     expect(newTask.challenge.id).to.equal(challenge._id);
   });
 
@@ -148,7 +148,7 @@ describe('taskManager', () => {
     expect(task.type).to.equal(testHabit.type);
     expect(task.up).to.equal(testHabit.up);
     expect(task.down).to.equal(testHabit.down);
-    expect(task.createdAt).isNotEmtpy;
+    expect(task.createdAt).to.exist;
     expect(task.challenge.id).to.equal(challenge._id);
   });
 
@@ -171,7 +171,7 @@ describe('taskManager', () => {
     expect(syncableTask.updatedAt).to.not.exist;
   });
 
-  it('moves tasks to a specified position', async() => {
+  it('moves tasks to a specified position', async () => {
     let order = ['task-id-1', 'task-id-2'];
 
     moveTask(order, 'task-id-2', 0);

test/api/v3/unit/middlewares/cors.test.js

@@ -23,7 +23,7 @@ describe('cors middleware', () => {
       'Access-Control-Allow-Headers': 'Content-Type,Accept,Content-Encoding,X-Requested-With,x-api-user,x-api-key,x-client',
     });
     expect(res.sendStatus).to.not.have.been.called;
-    expect(next).to.have.been.called.once;
+    expect(next).to.have.been.calledOnce;
   });
 
   it('responds immediately if method is OPTIONS', () => {

test/api/v3/unit/middlewares/cronMiddleware.js

@@ -36,12 +36,12 @@ describe('cron middleware', () => {
     });
 
     user.save()
-    .then(savedUser => {
-      res.locals.user = savedUser;
-      res.analytics = analyticsService;
-      done();
-    })
-    .catch(done);
+      .then(savedUser => {
+        res.locals.user = savedUser;
+        res.analytics = analyticsService;
+        done();
+      })
+      .catch(done);
   });
 
   afterEach(() => {

test/api/v3/unit/middlewares/maintenanceMode.test.js

@@ -22,7 +22,7 @@ describe('maintenance mode middleware', () => {
 
     attachMaintenanceMode(req, res, next);
 
-    expect(next).to.have.been.called.once;
+    expect(next).to.have.been.calledOnce;
     expect(res.status).to.not.have.been.called;
   });
 

test/api/v3/unit/middlewares/redirects.js

@@ -43,7 +43,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceSSL(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
 
     it('does not redirect outside of production environments', () => {
@@ -57,7 +57,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceSSL(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
 
     it('does not redirect if base URL is not https', () => {
@@ -71,7 +71,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceSSL(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
   });
 
@@ -108,7 +108,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceHabitica(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
 
     it('does not redirect if env is set to ignore redirection', () => {
@@ -125,7 +125,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceHabitica(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
 
     it('does not redirect if request hostname matches base URL host', () => {
@@ -142,7 +142,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceHabitica(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
 
     it('does not redirect if request is an API URL', () => {
@@ -159,7 +159,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceHabitica(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
 
     it('does not redirect if request method is not GET', () => {
@@ -176,7 +176,7 @@ describe('redirects middleware', () => {
 
       attachRedirects.forceHabitica(req, res, next);
 
-      expect(res.redirect).to.be.notCalled;
+      expect(res.redirect).to.have.not.been.called;
     });
   });
 });

test/api/v3/unit/models/challenge.test.js

@@ -65,7 +65,7 @@ describe('Challenge Model', () => {
 
   each(tasksToTest, (taskValue, taskType) => {
     context(`${taskType}`, () => {
-      beforeEach(async() => {
+      beforeEach(async () => {
         task = new Tasks[`${taskType}`](Tasks.Task.sanitize(taskValue));
         task.challenge.id = challenge._id;
         await task.save();
@@ -194,7 +194,7 @@ describe('Challenge Model', () => {
         });
 
         expect(syncedTask).to.exist;
-        expect(syncedTask.challenge._id).to.be.empty;
+        expect(syncedTask.challenge._id).to.be.undefined;
       });
     });
   });

test/api/v3/unit/models/group_tasks.test.js

@@ -64,7 +64,7 @@ describe('Group Task Methods', () => {
 
   each(tasksToTest, (taskValue, taskType) => {
     context(`${taskType}`, () => {
-      beforeEach(async() => {
+      beforeEach(async () => {
         task = new Tasks[`${taskType}`](Tasks.Task.sanitize(taskValue));
         task.group.id = guild._id;
         await task.save();
@@ -127,7 +127,7 @@ describe('Group Task Methods', () => {
         expect(syncedTask.checklist[0].text).to.equal(task.checklist[0].text);
       });
 
-      describe('syncs updated info', async() => {
+      describe('syncs updated info', async () => {
         let newMember;
 
         beforeEach(async () => {
@@ -274,7 +274,7 @@ describe('Group Task Methods', () => {
 
         expect(task.group.assignedUsers).to.not.contain(leader._id);
         expect(updatedSyncedTask).to.exist;
-        expect(updatedSyncedTask.group._id).to.be.empty;
+        expect(updatedSyncedTask.group._id).to.be.undefined;
       });
     });
   });

test/api/v3/unit/models/task.test.js

@@ -54,7 +54,7 @@ describe('Task Model', () => {
 
   each(tasksToTest, (taskValue, taskType) => {
     context(`${taskType}`, () => {
-      beforeEach(async() => {
+      beforeEach(async () => {
         task = new Tasks[`${taskType}`](Tasks.Task.sanitize(taskValue));
         task.challenge.id = challenge._id;
         task.history = generateHistory(396);

test/api/v3/unit/models/user.test.js

@@ -120,7 +120,7 @@ describe('User Model', () => {
         expect(User.pushNotification({_id: user._id}, 'CRON', null, 'INVALID_SEEN')).to.eventually.be.rejected;
       });
 
-      it('adds notifications without data for all given users via static method', async() => {
+      it('adds notifications without data for all given users via static method', async () => {
         let user = new User();
         let otherUser = new User();
         await Bluebird.all([user.save(), otherUser.save()]);