Upgrade tests tools and lint migrations and scripts (part 2) (#9998)

* upgrade gulp-babel

* upgrade babel-eslint

* upgrade eslint-friendly-formatter

* start upgrading chai

* start to upgrade eslint

* restore skipped tests

* start to upgrqde monk

* fix linting and remove unused file

* fix mocha notifications, and common tests

* fix unit tests

* start to fix initrgration tests

* more integration tests fixes

* upgrade monk to latest version

* lint /scripts

* migrations: start moving to /archive unused migrations and run eslint with --fix

* lint migrations

* fix more integration tests

* fix test

test/api/v3/integration/user/auth/DELETE-user_auth_social_network.test.js

@@ -41,7 +41,7 @@ describe('DELETE social registration', () => {
       let response = await user.del('/user/auth/social/facebook');
       expect(response).to.eql({});
       await user.sync();
-      expect(user.auth.facebook).to.be.empty;
+      expect(user.auth.facebook).to.be.undefined;
     });
 
     it('succeeds if user has a google registration', async () => {
@@ -54,7 +54,7 @@ describe('DELETE social registration', () => {
       let response = await user.del('/user/auth/social/facebook');
       expect(response).to.eql({});
       await user.sync();
-      expect(user.auth.facebook).to.be.empty;
+      expect(user.auth.facebook).to.be.undefined;
     });
   });
 
@@ -79,7 +79,7 @@ describe('DELETE social registration', () => {
       let response = await user.del('/user/auth/social/google');
       expect(response).to.eql({});
       await user.sync();
-      expect(user.auth.google).to.be.empty;
+      expect(user.auth.google).to.be.undefined;
     });
 
     it('succeeds if user has a facebook registration', async () => {
@@ -92,7 +92,7 @@ describe('DELETE social registration', () => {
       let response = await user.del('/user/auth/social/google');
       expect(response).to.eql({});
       await user.sync();
-      expect(user.auth.google).to.be.empty;
+      expect(user.auth.goodl).to.be.undefined;
     });
   });
 });

test/api/v3/integration/user/auth/POST-register_local.test.js

@@ -579,7 +579,7 @@ describe('POST /user/auth/local/register', () => {
 
     it('adds a user to a guild on an invite of type other than party', async () => {
       let { group, groupLeader } = await createAndPopulateGroup({
-          groupDetails: { type: 'guild', privacy: 'private' },
+        groupDetails: { type: 'guild', privacy: 'private' },
       });
 
       let invite = encrypt(JSON.stringify({