Upgrade tests tools and lint migrations and scripts (part 2) (#9998)

* upgrade gulp-babel

* upgrade babel-eslint

* upgrade eslint-friendly-formatter

* start upgrading chai

* start to upgrade eslint

* restore skipped tests

* start to upgrqde monk

* fix linting and remove unused file

* fix mocha notifications, and common tests

* fix unit tests

* start to fix initrgration tests

* more integration tests fixes

* upgrade monk to latest version

* lint /scripts

* migrations: start moving to /archive unused migrations and run eslint with --fix

* lint migrations

* fix more integration tests

* fix test

migrations/restore-profile-data.js

@@ -1,23 +1,22 @@
-var migrationName = 'restore_profile_data.js';
-var authorName = 'ThehollidayInn'; // in case script author needs to know when their ...
-var authorUuid = ''; //... own data is done
+/* let migrationName = 'restore_profile_data.js'; */
+let authorName = 'ThehollidayInn'; // in case script author needs to know when their ...
+let authorUuid = ''; // ... own data is done
 
 /*
  * Check if users have empty profile data in new database and update it with old database info
  */
 
-var monk = require('monk');
-var connectionString = ''; // FOR TEST DATABASE
-var dbUsers = monk(connectionString).get('users', { castIds: false });
+let monk = require('monk');
+let connectionString = ''; // FOR TEST DATABASE
+let dbUsers = monk(connectionString).get('users', { castIds: false });
 
-var monk2 = require('monk');
-var oldDbConnectionString = 'mongodb://localhost:27017/habitrpg?auto_reconnect=true'; // FOR TEST DATABASE
-var olDbUsers = monk2(oldDbConnectionString).get('users', { castIds: false });
+let monk2 = require('monk');
+let oldDbConnectionString = 'mongodb://localhost:27017/habitrpg?auto_reconnect=true'; // FOR TEST DATABASE
+let olDbUsers = monk2(oldDbConnectionString).get('users', { castIds: false });
 
-function processUsers(lastId)
-{
+function processUsers (lastId) {
   // specify a query to limit the affected users (empty for all users):
-  var query = {
+  let query = {
     // 'profile.name': 'profile name not found',
     'profile.blurb': null,
     // 'auth.timestamps.loggedin': {$gt: new Date('11/30/2016')},
@@ -25,24 +24,24 @@ function processUsers(lastId)
 
   if (lastId) {
     query._id = {
-      $gt: lastId
-    }
+      $gt: lastId,
+    };
   }
 
   dbUsers.find(query, {
     sort: {_id: 1},
     limit: 250,
-    fields: ['_id', 'profile', 'auth.timestamps.loggedin'] // specify fields we are interested in to limit retrieved data (empty if we're not reading data):
+    fields: ['_id', 'profile', 'auth.timestamps.loggedin'], // specify fields we are interested in to limit retrieved data (empty if we're not reading data):
   })
-  .then(updateUsers)
-  .catch(function (err) {
-    console.log(err);
-    return exiting(1, 'ERROR! ' + err);
-  });
+    .then(updateUsers)
+    .catch((err) => {
+      console.log(err);
+      return exiting(1, `ERROR! ${  err}`);
+    });
 }
 
-var progressCount = 1000;
-var count = 0;
+let progressCount = 1000;
+let count = 0;
 
 function updateUsers (users) {
   if (!users || users.length === 0) {
@@ -51,13 +50,13 @@ function updateUsers (users) {
     return;
   }
 
-  var userPaymentPromises = users.map(updateUser);
-  var lastUser = users[users.length - 1];
+  let userPaymentPromises = users.map(updateUser);
+  let lastUser = users[users.length - 1];
 
   return Promise.all(userPaymentPromises)
-  .then(function () {
-    processUsers(lastUser._id);
-  });
+    .then(() => {
+      return processUsers(lastUser._id);
+    });
 }
 
 function updateUser (user) {
@@ -68,11 +67,11 @@ function updateUser (user) {
       .then((oldUserData) => {
         if (!oldUserData) return;
         // specify user data to change:
-        var set = {};
+        let set = {};
 
         if (oldUserData.profile.name === 'profile name not found') return;
 
-        var userNeedsProfileName = !user.profile.name || user.profile.name === 'profile name not found';
+        let userNeedsProfileName = !user.profile.name || user.profile.name === 'profile name not found';
         if (userNeedsProfileName && oldUserData.profile.name) {
           set['profile.name'] = oldUserData.profile.name;
         }
@@ -86,30 +85,35 @@ function updateUser (user) {
         }
 
         if (Object.keys(set).length !== 0 && set.constructor === Object) {
-          console.log(set)
-          return dbUsers.update({_id: user._id}, {$set:set});
+          console.log(set);
+          return dbUsers.update({_id: user._id}, {$set: set});
         }
       });
   }
 
-  if (count % progressCount == 0) console.warn(count + ' ' + user._id);
-  if (user._id == authorUuid) console.warn(authorName + ' processed');
+  if (count % progressCount === 0) console.warn(`${count  } ${  user._id}`);
+  if (user._id === authorUuid) console.warn(`${authorName  } processed`);
 }
 
-function displayData() {
-  console.warn('\n' + count + ' users processed\n');
+function displayData () {
+  console.warn(`\n${  count  } users processed\n`);
   return exiting(0);
 }
 
-function exiting(code, msg) {
+function exiting (code, msg) {
   code = code || 0; // 0 = success
-  if (code && !msg) { msg = 'ERROR!'; }
+  if (code && !msg) {
+    msg = 'ERROR!';
+  }
   if (msg) {
-    if (code) { console.error(msg); }
-    else      { console.log(  msg); }
+    if (code) {
+      console.error(msg);
+    } else      {
+      console.log(msg);
+    }
   }
   process.exit(code);
 }
 
 
-processUsers()
+processUsers();