mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-16 22:27:26 +01:00
Fix Storybook Installation and production build CI (#13465)
* Revert storybook updates - pin versions - add production build CI * test.yml wasnt added to the commit Co-authored-by: Sabe Jones <sabrecat@gmail.com>
This commit is contained in:
23
.github/workflows/test.yml
vendored
23
.github/workflows/test.yml
vendored
@@ -219,4 +219,25 @@ jobs:
|
|||||||
CI: true
|
CI: true
|
||||||
NODE_ENV: test
|
NODE_ENV: test
|
||||||
- run: npm run test:unit
|
- run: npm run test:unit
|
||||||
working-directory: ./website/client
|
working-directory: ./website/client
|
||||||
|
|
||||||
|
production-build:
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
strategy:
|
||||||
|
matrix:
|
||||||
|
node-version: [14.x]
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v1
|
||||||
|
with:
|
||||||
|
fetch-depth: 1
|
||||||
|
- name: Use Node.js ${{ matrix.node-version }}
|
||||||
|
uses: actions/setup-node@v1
|
||||||
|
with:
|
||||||
|
node-version: ${{ matrix.node-version }}
|
||||||
|
- run: cp config.json.example config.json
|
||||||
|
- name: npm install
|
||||||
|
run: |
|
||||||
|
npm install
|
||||||
|
env:
|
||||||
|
CI: true
|
||||||
|
NODE_ENV: production
|
||||||
|
|||||||
8
website/client/config/storybook/README.md
Normal file
8
website/client/config/storybook/README.md
Normal file
@@ -0,0 +1,8 @@
|
|||||||
|
# Storybook Updates
|
||||||
|
|
||||||
|
Addon-Knobs has been deprecated inorder to update to the new `addons-controls` we need to:
|
||||||
|
|
||||||
|
1. Change to the new export syntax for each story `export const StoryTemplate`
|
||||||
|
2. And use `StoryTemplate.args` and `StoryTemplate.argTypes` to have the same `knobs` as before
|
||||||
|
|
||||||
|
Maybe this can be made story by story and not all at once
|
||||||
6174
website/client/package-lock.json
generated
6174
website/client/package-lock.json
generated
File diff suppressed because it is too large
Load Diff
@@ -13,11 +13,12 @@
|
|||||||
"storybook:serve": "vue-cli-service storybook:serve -p 6006 -c config/storybook"
|
"storybook:serve": "vue-cli-service storybook:serve -p 6006 -c config/storybook"
|
||||||
},
|
},
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
"@storybook/addon-actions": "^6.3.7",
|
"@storybook/addons": "6.2.9",
|
||||||
"@storybook/addon-knobs": "^6.3.0",
|
"@storybook/addon-actions": "6.2.9",
|
||||||
"@storybook/addon-links": "^6.3.7",
|
"@storybook/addon-knobs": "6.2.9",
|
||||||
"@storybook/addon-notes": "^5.3.21",
|
"@storybook/addon-links": "6.2.9",
|
||||||
"@storybook/vue": "^6.3.7",
|
"@storybook/addon-notes": "5.3.21",
|
||||||
|
"@storybook/vue": "6.2.9",
|
||||||
"@vue/cli-plugin-babel": "^4.5.13",
|
"@vue/cli-plugin-babel": "^4.5.13",
|
||||||
"@vue/cli-plugin-eslint": "^4.5.13",
|
"@vue/cli-plugin-eslint": "^4.5.13",
|
||||||
"@vue/cli-plugin-router": "^4.5.13",
|
"@vue/cli-plugin-router": "^4.5.13",
|
||||||
@@ -54,7 +55,7 @@
|
|||||||
"uuid": "^8.3.2",
|
"uuid": "^8.3.2",
|
||||||
"validator": "^13.6.0",
|
"validator": "^13.6.0",
|
||||||
"vue": "^2.6.14",
|
"vue": "^2.6.14",
|
||||||
"vue-cli-plugin-storybook": "^2.1.0",
|
"vue-cli-plugin-storybook": "2.1.0",
|
||||||
"vue-mugen-scroll": "^0.2.6",
|
"vue-mugen-scroll": "^0.2.6",
|
||||||
"vue-router": "^3.5.2",
|
"vue-router": "^3.5.2",
|
||||||
"vue-template-compiler": "^2.6.14",
|
"vue-template-compiler": "^2.6.14",
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ if (process.env.NODE_ENV === 'production') {
|
|||||||
stdio: 'inherit',
|
stdio: 'inherit',
|
||||||
});
|
});
|
||||||
|
|
||||||
/* execSync('npm run storybook:build', {
|
execSync('npm run storybook:build', {
|
||||||
stdio: 'inherit',
|
stdio: 'inherit',
|
||||||
}); */
|
});
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user