krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-15 21:57:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix API early Stat Point allocation (#10680)

Browse Source 
* Refactor hasClass check to common so it can be used in shared & server-side code

* Check that user has selected class before allocating stat points
This commit is contained in:
Carl Vuorinen
2018-09-21 17:55:55 +03:00
committed by Matteo Pagliazzi
parent 26c8323e70
commit 71c0939a15
11 changed files with 204 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
website/common/script/ops/stats/allocate.js
View File

@@ -8,6 +8,7 @@ import {
} from '../../libs/errors';
import i18n from '../../i18n';
import errorMessage from '../../libs/errorMessage';
import hasClass from '../../libs/hasClass';
module.exports = function allocate (user, req = {}) {
let stat = get(req, 'query.stat', 'str');
@@ -16,6 +17,10 @@ module.exports = function allocate (user, req = {}) {
throw new BadRequest(errorMessage('invalidAttribute', {attr: stat}));
}
if (!hasClass(user)) {
throw new NotAuthorized(i18n.t('classNotSelected', req.language));
}
if (user.stats.points > 0) {
user.stats[stat]++;
user.stats.points--;

5
website/common/script/ops/stats/allocateBulk.js
View File

@@ -8,6 +8,7 @@ import {
} from '../../libs/errors';
import i18n from '../../i18n';
import errorMessage from '../../libs/errorMessage';
import hasClass from '../../libs/hasClass';
module.exports = function allocateBulk (user, req = {}) {
const stats = get(req, 'body.stats');
@@ -21,6 +22,10 @@ module.exports = function allocateBulk (user, req = {}) {
throw new BadRequest(errorMessage('invalidAttribute', {attr: invalidStats.join(',')}));
}
if (!hasClass(user)) {
throw new NotAuthorized(i18n.t('classNotSelected', req.language));
}
if (user.stats.points <= 0) {
throw new NotAuthorized(i18n.t('notEnoughAttrPoints', req.language));
}