Remove party joined option (#8212)

* Remove party joined option

* Make default sort sort by profile name

* Remove extraneous comment

website/client-old/js/controllers/chatCtrl.js

@@ -152,7 +152,6 @@ habitrpg.controller('ChatCtrl', ['$scope', 'Groups', 'Chat', 'User', '$http', 'A
       'random': window.env.t('sortRandom'),
       'pets': window.env.t('sortPets'),
       'habitrpg_date_joined' : window.env.t('sortHabitrpgJoined'),
-      'party_date_joined': window.env.t('sortJoined'),
       'habitrpg_last_logged_in': window.env.t('sortHabitrpgLastLoggedIn'),
       'name': window.env.t('sortName'),
       'backgrounds': window.env.t('sortBackgrounds'),

website/client-old/js/controllers/headerCtrl.js

@@ -52,8 +52,7 @@ habitrpg.controller("HeaderCtrl", ['$scope', 'Groups', 'User',
                 return member.auth.timestamps.loggedin;
                 break
               default:
-                // party date joined
-                return true;
+                return member.profile.name;
           }
         }
       )

website/common/locales/en/groups.json

@@ -83,7 +83,6 @@
     "sortLevel": "Sort by level",
     "sortRandom": "Sort randomly",
     "sortPets": "Sort by number of pets",
-    "sortJoined": "Sort by date joined the party",
     "sortName": "Sort by avatar name",
     "sortBackgrounds": "Sort by background",
     "sortHabitrpgJoined": "Sort by Habitica date joined",