krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 15:17:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix errorHandler tests, add tests for res.respond

Browse Source
This commit is contained in:
Matteo Pagliazzi
2015-11-23 13:28:25 +01:00
parent 7086fbfbd6
commit 645095e58f
3 changed files with 63 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/api/v3/unit/middlewares/errorHandler.test.js
View File

@@ -5,6 +5,8 @@ import {
} from '../../../../helpers/api-unit.helper';
import errorHandler from '../../../../../website/src/middlewares/api-v3/errorHandler';
import responseMiddleware from '../../../../../website/src/middlewares/api-v3/response';
import getUserLanguage from '../../../../../website/src/middlewares/api-v3/getUserLanguage';
import { BadRequest } from '../../../../../website/src/libs/api-v3/errors';
import logger from '../../../../../website/src/libs/api-v3/logger';
@@ -16,6 +18,8 @@ describe('errorHandler', () => {
res = generateRes();
req = generateReq();
next = generateNext();
responseMiddleware(req, res, next);
getUserLanguage(req, res, next);
sandbox.stub(logger, 'error');
});
@@ -30,6 +34,7 @@ describe('errorHandler', () => {
expect(res.status).to.be.calledWith(500);
expect(res.json).to.be.calledWith({
success: false,
error: 'InternalServerError',
message: 'An unexpected error occurred.',
});
@@ -46,6 +51,7 @@ describe('errorHandler', () => {
expect(res.status).to.be.calledWith(400);
expect(res.json).to.be.calledWith({
success: false,
error: 'Error',
message: 'Error message',
});
@@ -62,6 +68,7 @@ describe('errorHandler', () => {
expect(res.status).to.be.calledWith(500);
expect(res.json).to.be.calledWith({
success: false,
error: 'InternalServerError',
message: 'An unexpected error occurred.',
});
@@ -77,6 +84,7 @@ describe('errorHandler', () => {
expect(res.status).to.be.calledWith(400);
expect(res.json).to.be.calledWith({
success: false,
error: 'BadRequest',
message: 'Bad request.',
});
@@ -93,6 +101,7 @@ describe('errorHandler', () => {
expect(res.status).to.be.calledWith(error.statusCode);
expect(res.json).to.be.calledWith({
success: false,
error: error.name,
message: error.message,
});
@@ -108,6 +117,7 @@ describe('errorHandler', () => {
expect(res.status).to.be.calledWith(400);
expect(res.json).to.be.calledWith({
success: false,
error: 'BadRequest',
message: 'Invalid request parameters.',
errors: error,
@@ -133,6 +143,7 @@ describe('errorHandler', () => {
expect(res.status).to.be.calledWith(400);
expect(res.json).to.be.calledWith({
success: false,
error: 'BadRequest',
message: 'User validation failed.',
errors: [
@@ -154,11 +165,4 @@ describe('errorHandler', () => {
fullError: error,
});
});
it('does not send error if error is not defined', () => {
errorHandler(null, req, res, next);
expect(next).to.be.calledOnce;
expect(res.status).to.not.be.called;
});
});