mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-19 15:48:04 +01:00
Added quest leave route and initial tests
This commit is contained in:
@@ -73,5 +73,8 @@
|
||||
"questNotFound": "Quest \"<%= key %>\" not found.",
|
||||
"questNotOwned": "You don't own that quest scroll.",
|
||||
"questLevelTooHigh": "You must be Level <%= level %> to begin this quest.",
|
||||
"questAlreadyUnderway": "Your party is already on a quest. Try again when the current quest has ended."
|
||||
"questAlreadyUnderway": "Your party is already on a quest. Try again when the current quest has ended.",
|
||||
"noActiveQuestToLeave": "No active quest to leave",
|
||||
"questLeaderCannotLeaveQuest": "Quest leader cannot leave quest",
|
||||
"notPartOfQuest": "You are not part of the quest"
|
||||
}
|
||||
|
||||
@@ -0,0 +1,85 @@
|
||||
import {
|
||||
createAndPopulateGroup,
|
||||
translate as t,
|
||||
} from '../../../../helpers/api-v3-integration.helper';
|
||||
import { v4 as generateUUID } from 'uuid';
|
||||
|
||||
describe('POST /groups/:groupId/quests/leave', () => {
|
||||
let questingGroup, member, leader;
|
||||
const PET_QUEST = 'whale';
|
||||
let userQuestUpdate = {
|
||||
items: {
|
||||
quests: {},
|
||||
},
|
||||
'party.quest.RSVPNeeded': true,
|
||||
'party.quest.key': PET_QUEST,
|
||||
};
|
||||
|
||||
before(async () => {
|
||||
let { group, groupLeader, members } = await createAndPopulateGroup({
|
||||
groupDetails: { type: 'party', privacy: 'private' },
|
||||
members: 1,
|
||||
});
|
||||
|
||||
leader = groupLeader;
|
||||
questingGroup = group;
|
||||
member = members[0];
|
||||
|
||||
userQuestUpdate.items.quests[PET_QUEST] = 1;
|
||||
});
|
||||
|
||||
it('returns an error when group is not found', async () => {
|
||||
await expect(member.post(`/groups/${generateUUID()}/quests/leave`))
|
||||
.to.eventually.be.rejected.and.eql({
|
||||
code: 404,
|
||||
error: 'NotFound',
|
||||
message: t('groupNotFound'),
|
||||
});
|
||||
});
|
||||
|
||||
it('returns an error when quest is not active', async () => {
|
||||
await expect(member.post(`/groups/${questingGroup._id}/quests/leave`))
|
||||
.to.eventually.be.rejected.and.eql({
|
||||
code: 404,
|
||||
error: 'NotFound',
|
||||
message: t('noActiveQuestToLeave'),
|
||||
});
|
||||
});
|
||||
|
||||
it('returns an error when quest leader attempts to leave', async () => {
|
||||
await questingGroup.update({quest: {key: PET_QUEST, active: true, leader: leader._id}});
|
||||
|
||||
await expect(leader.post(`/groups/${questingGroup._id}/quests/leave`))
|
||||
.to.eventually.be.rejected.and.eql({
|
||||
code: 401,
|
||||
error: 'NotAuthorized',
|
||||
message: t('questLeaderCannotLeaveQuest'),
|
||||
});
|
||||
});
|
||||
|
||||
it('returns an error when non quest member attempts to leave', async () => {
|
||||
await expect(member.post(`/groups/${questingGroup._id}/quests/leave`))
|
||||
.to.eventually.be.rejected.and.eql({
|
||||
code: 401,
|
||||
error: 'NotAuthorized',
|
||||
message: t('notPartOfQuest'),
|
||||
});
|
||||
});
|
||||
|
||||
it('leaves a quest', async () => {
|
||||
await member.update(userQuestUpdate);
|
||||
|
||||
let questMembers = {};
|
||||
questMembers[member._id] = true;
|
||||
await questingGroup.update({'quest.members': questMembers});
|
||||
|
||||
let leaveResult = await member.post(`/groups/${questingGroup._id}/quests/leave`);
|
||||
let userThatLeft = await member.get('/user');
|
||||
let updatedGroup = await member.get(`/groups/${questingGroup._id}`);
|
||||
|
||||
expect(userThatLeft.party.quest.key).to.be.null;
|
||||
expect(userThatLeft.party.quest.RSVPNeeded).to.be.false;
|
||||
expect(updatedGroup.quest.members[member._id]).to.be.false;
|
||||
expect(updatedGroup.quest).to.deep.equal(leaveResult);
|
||||
});
|
||||
});
|
||||
@@ -8,6 +8,7 @@ import {
|
||||
NotAuthorized,
|
||||
} from '../../libs/api-v3/errors';
|
||||
import { quests as questScrolls } from '../../../../common/script/content';
|
||||
import Q from 'q';
|
||||
|
||||
let api = {};
|
||||
|
||||
@@ -65,4 +66,57 @@ api.inviteToQuest = {
|
||||
},
|
||||
};
|
||||
|
||||
/**
|
||||
* @api {post} /groups/:groupId/quests/leave Leaves a quest
|
||||
* @apiVersion 3.0.0
|
||||
* @apiName LeaveQuest
|
||||
* @apiGroup Group
|
||||
*
|
||||
* @apiParam {string} groupId The group _id (or 'party')
|
||||
*
|
||||
* @apiSuccess {Object} Empty Object
|
||||
*/
|
||||
api.leaveQuest = {
|
||||
method: 'POST',
|
||||
url: '/groups/:groupId/quests/leave',
|
||||
middlewares: [authWithHeaders(), cron],
|
||||
async handler (req, res) {
|
||||
let user = res.locals.user;
|
||||
let groupId = req.params.groupId;
|
||||
|
||||
req.checkParams('groupId', res.t('groupIdRequired')).notEmpty();
|
||||
|
||||
let validationErrors = req.validationErrors();
|
||||
if (validationErrors) throw validationErrors;
|
||||
|
||||
let group = await Group.getGroup({user, groupId, fields: 'type quest'});
|
||||
if (!group) throw new NotFound(res.t('groupNotFound'));
|
||||
|
||||
if (!(group.quest && group.quest.active)) {
|
||||
throw new NotFound(res.t('noActiveQuestToLeave'));
|
||||
}
|
||||
|
||||
if (group.quest.leader === user._id) {
|
||||
throw new NotAuthorized(res.t('questLeaderCannotLeaveQuest'));
|
||||
}
|
||||
|
||||
if (!(group.quest.members && group.quest.members[user._id])) {
|
||||
throw new NotAuthorized(res.t('notPartOfQuest'));
|
||||
}
|
||||
|
||||
group.quest.members[user._id] = false;
|
||||
group.markModified('quest.members');
|
||||
|
||||
user.party.quest = Group.cleanQuestProgress();
|
||||
user.markModified('party.quest');
|
||||
|
||||
let [savedGroup] = await Q.all([
|
||||
group.save(),
|
||||
user.save(),
|
||||
]);
|
||||
|
||||
res.respond(200, savedGroup.quest);
|
||||
},
|
||||
};
|
||||
|
||||
export default api;
|
||||
|
||||
Reference in New Issue
Block a user