krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 15:17:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Optimize database access for some use cases (#15444)

Browse Source 
* optimize query when listing challenge tasks

* Optimize query for checking if user is party leader
This commit is contained in:
Phillip Thelen
2025-05-29 04:52:07 +02:00
committed by GitHub
parent 972f23e235
commit 5ba7d2395e
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
website/server/controllers/api-v3/groups.js
View File

@@ -1316,13 +1316,13 @@ api.getLookingForParty = {
const PAGE = req.query.page || 0; const PAGE = req.query.page || 0;
const PAGE_START = USERS_PER_PAGE * PAGE; const PAGE_START = USERS_PER_PAGE * PAGE;
const partyLed = await Group let partyLed = false;
.findOne({ if (user.party._id) {
type: 'party', const party = await Group.getGroup({ user, groupId: user.party._id });
leader: user._id, if (party && party.leader === user._id) {
}) partyLed = true;
.select('_id') }
.exec(); }
if (!partyLed) { if (!partyLed) {
throw new BadRequest(apiError('notPartyLeader')); throw new BadRequest(apiError('notPartyLeader'));

2
website/server/libs/tasks/index.js
View File

@@ -233,7 +233,7 @@ async function getTasks (req, res, options = {}) {
} else { } else {
query.type = type.slice(0, -1); // removing the final "s" query.type = type.slice(0, -1); // removing the final "s"
} }
} else { } else if (!challenge) {
query.$and = [{ query.$and = [{
$or: [ // Exclude completed todos $or: [ // Exclude completed todos
{ type: 'todo', completed: false }, { type: 'todo', completed: false },