mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-19 07:37:25 +01:00
[#1476] re-order "you already have this combo" message to bail early
This commit is contained in:
@@ -16,18 +16,18 @@ habitrpg.controller("InventoryCtrl", ['$scope', 'User',
|
||||
}
|
||||
|
||||
$scope.pour = function(){
|
||||
var pet = $scope.selectedEgg.name + '-' + $scope.selectedPotion;
|
||||
|
||||
if(User.user.items.pets && ~User.user.items.pets.indexOf(pet)) {
|
||||
return alert("You already have that pet, hatch a different combo.")
|
||||
}
|
||||
|
||||
var i = _.indexOf($scope.userEggs, $scope.selectedEgg);
|
||||
$scope.userEggs.splice(i, 1);
|
||||
|
||||
i = _.indexOf($scope.userHatchingPotions, $scope.selectedPotion);
|
||||
$scope.userHatchingPotions.splice(i, 1);
|
||||
|
||||
var pet = $scope.selectedEgg.name + '-' + $scope.selectedPotion;
|
||||
|
||||
if(User.user.items.pets && User.user.items.pets.indexOf(pet) != -1) {
|
||||
return alert("You already have that pet, hatch a different combo.")
|
||||
}
|
||||
|
||||
if(!User.user.items.pets) User.user.items.pets = [];
|
||||
User.user.items.pets.push(pet);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user