prevent sync from clearing selected tags (#7631)

* prevent sync from clearing selected tags

* improved tag selection bugfix

website/client/js/services/userServices.js

@@ -80,6 +80,10 @@ angular.module('habitrpg')
 
           _.extend(user, response.data.data);
 
+          if (!user.filters) {
+            user.filters = {};
+          }
+          
           if (!user._wrapped) {
             // This wraps user with `ops`, which are functions shared both on client and mobile. When performed on client,
             // they update the user in the browser and then send the request to the server, where the same operation is

website/server/models/user/hooks.js

@@ -13,6 +13,7 @@ schema.plugin(baseModel, {
   private: ['auth.local.hashed_password', 'auth.local.salt', '_cronSignature'],
   toJSONTransform: function userToJSON (plainObj, originalDoc) {
     plainObj._tmp = originalDoc._tmp; // be sure to send down drop notifs
+    delete plainObj.filters;
 
     return plainObj;
   },

website/server/models/user/schema.js

@@ -107,10 +107,6 @@ let schema = new Schema({
   },
 
   balance: {type: Number, default: 0},
-  // Not saved on the user right now
-  filters: {type: Schema.Types.Mixed, default: () => {
-    return {};
-  }},
 
   purchased: {
     ads: {type: Boolean, default: false},