krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-18 15:17:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Replaced magic numbers with variables

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2015-11-17 14:07:35 +01:00
parent e811693752
commit 53417adda1
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
website/public/js/controllers/settingsCtrl.js
View File

@@ -204,12 +204,13 @@ habitrpg.controller('SettingsCtrl',
$scope.gemGoldCap = function(subscription) { $scope.gemGoldCap = function(subscription) {
var baseCap = 25; var baseCap = 25;
var gemCapIncrement = 5;
var capIncrementThreshold = 3;
var gemCapExtra = User.user.purchased.plan.consecutive.gemCapExtra; var gemCapExtra = User.user.purchased.plan.consecutive.gemCapExtra;
// @TODO: What are these magic numbers? 3? 5? var blocks = Content.subscriptionBlocks[subscription.key].months / capIncrementThreshold;
var blocks = Content.subscriptionBlocks[subscription.key].months / 3;
var flooredBlocks = Math.floor(blocks); var flooredBlocks = Math.floor(blocks);
var userTotalDropCap = baseCap + gemCapExtra + flooredBlocks * 5; var userTotalDropCap = baseCap + gemCapExtra + flooredBlocks * gemCapIncrement;
var maxDropCap = 50; var maxDropCap = 50;
return [userTotalDropCap, maxDropCap]; return [userTotalDropCap, maxDropCap];