krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 14:47:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Removed display of users personal checklist on challenge tasks (#9837)

Browse Source
This commit is contained in:
Keith Holliday
2018-01-23 10:55:55 -07:00
committed by GitHub
parent f5d7777b2c
commit 51aebb540c
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/api/v3/integration/challenges/GET-challenges_challengeId_members_memberId.test.js
View File

@@ -95,13 +95,23 @@ describe('GET /challenges/:challengeId/members/:memberId', () => {
expect(memberProgress.tasks[0].challenge.taskId).to.equal(chalTasks[0]._id); expect(memberProgress.tasks[0].challenge.taskId).to.equal(chalTasks[0]._id);
}); });
it('returns the tasks without the tags', async () => { it('returns the tasks without the tags and checklist', async () => {
let group = await generateGroup(user, {type: 'party', name: generateUUID()}); let group = await generateGroup(user, {type: 'party', name: generateUUID()});
let challenge = await generateChallenge(user, group); let challenge = await generateChallenge(user, group);
let taskText = 'Test Text'; let taskText = 'Test Text';
await user.post(`/tasks/challenge/${challenge._id}`, [{type: 'habit', text: taskText}]); await user.post(`/tasks/challenge/${challenge._id}`, [{
type: 'todo',
text: taskText,
checklist: [
{
_id: 123,
text: 'test',
},
],
}]);
let memberProgress = await user.get(`/challenges/${challenge._id}/members/${user._id}`); let memberProgress = await user.get(`/challenges/${challenge._id}/members/${user._id}`);
expect(memberProgress.tasks[0]).not.to.have.key('tags'); expect(memberProgress.tasks[0]).not.to.have.key('tags');
expect(memberProgress.tasks[0].checklist).to.eql([]);
}); });
}); });

5
website/server/controllers/api-v3/members.js
View File

@@ -413,7 +413,10 @@ api.getChallengeMemberProgress = {
// manually call toJSON with minimize: true so empty paths aren't returned // manually call toJSON with minimize: true so empty paths aren't returned
let response = member.toJSON({minimize: true}); let response = member.toJSON({minimize: true});
delete response.challenges; delete response.challenges;
response.tasks = chalTasks.map(chalTask => chalTask.toJSON({minimize: true})); response.tasks = chalTasks.map(chalTask => {
chalTask.checklist = []; // Clear checklists as they are private
return chalTask.toJSON({minimize: true});
});
res.respond(200, response); res.respond(200, response);
}, },
}; };