krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 14:47:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Optional feedback on account deletion (#8750)

Browse Source 
* Fixed rebase.

* Removed commented out mail sending to pass linting. Styles from settings.styl still not propagating to app.css

* fix(feedback): address PR comments

* fix(style): linting errors
This commit is contained in:
Sabe Jones
2017-05-30 11:54:42 -05:00
committed by GitHub
parent 05ea2c1ce6
commit 46ed1813c6
7 changed files with 92 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
website/server/controllers/api-v3/user.js
View File

@@ -14,6 +14,13 @@ import { model as User } from '../../models/user';
import Bluebird from 'bluebird';
import _ from 'lodash';
import * as passwordUtils from '../../libs/password';
import {
getUserInfo,
sendTxn as txnEmail,
} from '../../libs/email';
import nconf from 'nconf';
const TECH_ASSISTANCE_EMAIL = nconf.get('EMAILS:TECH_ASSISTANCE_EMAIL');
/**
* @apiDefine UserNotFound
@@ -252,6 +259,7 @@ api.updateUser = {
* @apiGroup User
*
* @apiParam {String} password The user's password if the account uses local authentication
* @apiParam {String} feedback User's optional feedback explaining reasons for deletion
*
* @apiSuccess {Object} data An empty Object
*
@@ -262,6 +270,7 @@ api.updateUser = {
* }
*
* @apiError {BadRequest} MissingPassword The password was not included in the request
* @apiError {BadRequest} LengthExceeded The feedback provided is longer than 10K
* @apiError {BadRequest} NotAuthorized There is no account that uses those credentials.
*
* @apiErrorExample {json}
@@ -286,16 +295,15 @@ api.deleteUser = {
let user = res.locals.user;
let plan = user.purchased.plan;
req.checkBody({
password: {
notEmpty: {errorMessage: res.t('missingPassword')},
},
});
let password = req.body.password;
if (!password) throw new BadRequest(res.t('missingPassword'));
let feedback = req.body.feedback;
if (feedback && feedback.length > 10000) throw new BadRequest(`Account deletion feedback is limited to 10,000 characters. For lengthy feedback, email ${TECH_ASSISTANCE_EMAIL}.`);
let validationErrors = req.validationErrors();
if (validationErrors) throw validationErrors;
let password = req.body.password;
let isValidPassword = await passwordUtils.compare(user, password);
if (!isValidPassword) throw new NotAuthorized(res.t('wrongPassword'));
@@ -320,6 +328,16 @@ api.deleteUser = {
await user.remove();
if (feedback) {
txnEmail(TECH_ASSISTANCE_EMAIL, 'admin-feedback', [
{name: 'PROFILE_NAME', content: user.profile.name},
{name: 'UUID', content: user._id},
{name: 'EMAIL', content: getUserInfo(user, ['email']).email},
{name: 'FEEDBACK_SOURCE', content: 'from deletion form'},
{name: 'FEEDBACK', content: feedback},
]);
}
res.respond(200, {});
},
};