krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 15:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

cleanup of previous server crashing workaround, i think i figured it out

Browse Source
This commit is contained in:
Tyler Renelle
2012-10-28 15:26:43 -04:00
parent 198987dfa0
commit 45b7c906c6
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/server/serverRoutes.js
View File

@@ -40,7 +40,7 @@ module.exports = function(expressApp, root, derby) {
return res.send(500, err); return res.send(500, err);
} }
userObj = user.get(); userObj = user.get();
if (!(userObj && userObj.stats && userObj.stats.money && !_.isEmpty(userObj.tasks))) { if (!(userObj && !_.isEmpty(userObj.stats))) {
console.log({ console.log({
taskId: taskId, taskId: taskId,
direction: direction, direction: direction,

4
src/server/serverRoutes.coffee
View File

@@ -32,8 +32,8 @@ module.exports = (expressApp, root, derby) ->
model.fetch "users.#{uid}", (err, user) -> model.fetch "users.#{uid}", (err, user) ->
return res.send(500, err) if err return res.send(500, err) if err
userObj = user.get() userObj = user.get()
#FIXME The server keeps crashing. I think it's because some users are entering non-guids as their userId, test that here # Server crashes without this, I think some users are entering non-guid userIds and/or trying to use the API without having an account
unless userObj && userObj.stats && userObj.stats.money && !_.isEmpty(userObj.tasks) unless userObj && !_.isEmpty(userObj.stats)
console.log {taskId:taskId, direction:direction, user:userObj, error: 'non-user attempted to score'} console.log {taskId:taskId, direction:direction, user:userObj, error: 'non-user attempted to score'}
return res.send(500, "User #{uid} not found") return res.send(500, "User #{uid} not found")