krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-19 07:37:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix tests for /members/transfer-gems

Browse Source
This commit is contained in:
Alys
2016-05-14 07:18:00 -04:00
parent 2e078f4776
commit 44e9d8b09e
2 changed files with 25 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
test/api/v3/integration/members/POST-transfer_gems.test.js
View File

@@ -9,14 +9,13 @@ describe('POST /members/transfer-gems', () => {
let receiver;
let message = 'Test Private Message';
let gemAmount = 20;
let giftType = 'gems';
beforeEach(async () => {
userToSendMessage = await generateUser({balance: 5});
receiver = await generateUser();
});
it('returns error when giftType is not provided', async () => {
it('returns error when no parameters are provided', async () => {
await expect(userToSendMessage.post('/members/transfer-gems'))
.to.eventually.be.rejected.and.eql({
code: 400,
@@ -26,10 +25,10 @@ describe('POST /members/transfer-gems', () => {
});
it('returns error when message is not provided', async () => {
await expect(userToSendMessage.post('/members/transfer-gems'), {
giftType,
message,
}).to.eventually.be.rejected.and.eql({
await expect(userToSendMessage.post('/members/transfer-gems', {
gemAmount,
toUserId: receiver._id,
})).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
message: 'Invalid request parameters.',
@@ -38,8 +37,8 @@ describe('POST /members/transfer-gems', () => {
it('returns error when toUserId is not provided', async () => {
await expect(userToSendMessage.post('/members/transfer-gems', {
giftType,
message,
gemAmount,
})).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
@@ -49,8 +48,8 @@ describe('POST /members/transfer-gems', () => {
it('returns error when to user is not found', async () => {
await expect(userToSendMessage.post('/members/transfer-gems', {
giftType,
message,
gemAmount,
toUserId: generateUUID(),
})).to.eventually.be.rejected.and.eql({
code: 404,
@@ -61,8 +60,8 @@ describe('POST /members/transfer-gems', () => {
it('returns error when to user attempts to send gems to themselves', async () => {
await expect(userToSendMessage.post('/members/transfer-gems', {
giftType,
message,
gemAmount,
toUserId: userToSendMessage._id,
})).to.eventually.be.rejected.and.eql({
code: 401,
@@ -71,21 +70,31 @@ describe('POST /members/transfer-gems', () => {
});
});
it('returns error when there is no amount', async () => {
it('returns error when there is no gemAmount', async () => {
await expect(userToSendMessage.post('/members/transfer-gems', {
giftType,
message,
toUserId: receiver._id,
})).to.eventually.be.rejected.and.eql({
code: 401,
error: 'NotAuthorized',
message: t('badAmountOfGemsToSend'),
code: 400,
error: 'BadRequest',
message: 'Invalid request parameters.',
});
});
it('returns error when gemAmount is not an integer', async () => {
await expect(userToSendMessage.post('/members/transfer-gems', {
message,
gemAmount: 1.5,
toUserId: receiver._id,
})).to.eventually.be.rejected.and.eql({
code: 400,
error: 'BadRequest',
message: 'Invalid request parameters.',
});
});
it('returns error when gemAmount is negative', async () => {
await expect(userToSendMessage.post('/members/transfer-gems', {
giftType,
message,
gemAmount: -5,
toUserId: receiver._id,
@@ -98,7 +107,6 @@ describe('POST /members/transfer-gems', () => {
it('returns error when gemAmount is more than the sender\'s balance', async () => {
await expect(userToSendMessage.post('/members/transfer-gems', {
giftType,
message,
gemAmount: gemAmount + 4,
toUserId: receiver._id,
@@ -111,7 +119,6 @@ describe('POST /members/transfer-gems', () => {
it('sends a private message about gems to a user', async () => {
await userToSendMessage.post('/members/transfer-gems', {
giftType,
message,
gemAmount,
toUserId: receiver._id,

2
website/server/controllers/api-v3/members.js
View File

@@ -325,7 +325,7 @@ api.transferGems = {
let gemAmount = req.body.gemAmount;
let amount = gemAmount / 4;
if (!amount || amount <= 0 || sender.balance < amount) {
if (amount <= 0 || sender.balance < amount) {
throw new NotAuthorized(res.t('badAmountOfGemsToSend'));
}