From 4108a22d7822027c29a1b5ed9843cc3844caae63 Mon Sep 17 00:00:00 2001 From: negue Date: Wed, 8 Nov 2017 18:40:37 +0100 Subject: [PATCH] [WIP] bootstrap-vue upgrade (#9178) * update bootstrap-vue to 1.0.0-beta.9 - remove all individual bootstrap components and use BootstrapVue into Vue * change modal action names from show::modal to bv::show::modal * check if drops are undefined * fix modal widths - sellModal now using input instead of dropbox * upgrade to bootstrap 4.0beta * include package-lock changes * fix app menu dropdown position * upgrade bootstrap to beta2 (was missing grid offset and other fixes) - refix header menu position * fix tags popup (auto width to max not working) - fix filter panel width (adding width: 100% works until max-width) * show hide logo on different screensize (new css breakpoints - http://getbootstrap.com/docs/4.0/utilities/display/ ) * fix package-lock? * fix active button style / app header toggle button * fix package-lock ! * update package lock after merge - new mixin "openedItemRows" to save the "show more/show less" in stable * mixin naming style * fix buyQuestModal marginTop * fix customMenuDropdown position * fix userDropdown items --- package-lock.json | 121 +++++++----------- package.json | 4 +- website/client/app.vue | 16 +-- website/client/assets/scss/button.scss | 4 +- website/client/assets/scss/modal.scss | 3 +- .../components/achievements/armoireEmpty.vue | 7 +- .../components/achievements/chooseClass.vue | 7 +- .../components/achievements/contributor.vue | 4 +- .../client/components/achievements/death.vue | 5 +- .../components/achievements/dropsEnabled.vue | 7 +- .../components/achievements/invitedFriend.vue | 4 +- .../achievements/joinedChallenge.vue | 4 +- .../components/achievements/joinedGuild.vue | 4 +- .../components/achievements/levelUp.vue | 5 +- .../achievements/login-incentives.vue | 4 +- .../components/achievements/lowHealth.vue | 5 +- .../components/achievements/newStuff.vue | 9 +- .../achievements/questCompleted.vue | 4 +- .../achievements/questInvitation.vue | 7 +- .../components/achievements/rebirth.vue | 4 +- .../achievements/rebirthEnabled.vue | 7 +- .../client/components/achievements/streak.vue | 4 +- .../components/achievements/testing.vue | 7 +- .../achievements/testingletiant.vue | 7 +- .../components/achievements/ultimateGear.vue | 4 +- .../components/achievements/welcome.vue | 7 +- .../components/achievements/wonChallenge.vue | 4 +- website/client/components/appFooter.vue | 4 +- .../components/challenges/challengeDetail.vue | 18 +-- .../challengeMemberProgressModal.vue | 2 - .../components/challenges/challengeModal.vue | 14 +- .../challenges/closeChallengeModal.vue | 8 -- .../components/challenges/findChallenges.vue | 6 +- .../components/challenges/groupChallenges.vue | 2 +- .../components/challenges/myChallenges.vue | 6 +- .../client/components/chat/chatMessages.vue | 6 +- .../components/chat/copyAsTodoModal.vue | 8 +- .../components/chat/reportFlagModal.vue | 6 +- website/client/components/creatorIntro.vue | 5 +- .../group-plans/taskInformation.vue | 8 +- .../components/groups/createPartyModal.vue | 7 +- .../client/components/groups/discovery.vue | 8 +- website/client/components/groups/group.vue | 27 ++-- .../components/groups/groupFormModal.vue | 15 +-- .../components/groups/groupGemsModal.vue | 7 +- .../client/components/groups/groupPlan.vue | 4 +- .../client/components/groups/inviteModal.vue | 6 +- .../client/components/groups/membersModal.vue | 19 +-- website/client/components/groups/myGuilds.vue | 7 +- .../components/groups/newPartyModal.jade | 40 +++--- .../components/groups/questDetailsModal.vue | 5 +- .../components/groups/startQuestModal.vue | 4 +- website/client/components/hall/heroes.vue | 2 +- website/client/components/header/index.vue | 4 +- website/client/components/header/menu.vue | 66 ++++++---- .../client/components/header/userDropdown.vue | 12 +- .../inventory/equipment/equipGearModal.vue | 8 +- .../components/inventory/equipment/index.vue | 6 - website/client/components/inventory/item.vue | 4 - .../inventory/items/cards-modal.vue | 6 +- .../components/inventory/items/index.vue | 8 +- .../components/inventory/stable/foodItem.vue | 2 - .../inventory/stable/hatchedPetDialog.vue | 8 +- .../components/inventory/stable/index.vue | 31 ++--- .../components/inventory/stable/mountItem.vue | 4 - .../components/inventory/stable/petItem.vue | 4 - website/client/components/memberDetails.vue | 2 +- .../components/members/removeMemberModal.vue | 7 +- website/client/components/modifyInventory.vue | 6 +- website/client/components/notifications.vue | 54 ++++---- .../components/payments/amazonModal.vue | 4 - .../components/payments/buyGemsModal.vue | 4 +- .../components/payments/sendGemsModal.vue | 6 +- .../components/private-message-modal.vue | 0 .../client/components/selectMembersModal.vue | 8 +- .../components/settings/deleteModal.vue | 9 +- .../client/components/settings/resetModal.vue | 9 +- .../components/settings/restoreModal.vue | 9 +- website/client/components/settings/site.vue | 12 +- website/client/components/shops/buyModal.vue | 14 +- .../client/components/shops/market/index.vue | 8 -- .../components/shops/market/sellModal.vue | 40 ++---- .../components/shops/quests/buyQuestModal.vue | 10 +- .../client/components/shops/quests/index.vue | 9 +- .../components/shops/seasonal/index.vue | 8 -- website/client/components/shops/shopItem.vue | 2 - .../components/shops/timeTravelers/index.vue | 7 - .../components/tasks/approvalFooter.vue | 2 +- .../client/components/tasks/approvalModal.vue | 7 +- .../components/tasks/brokenTaskModal.vue | 6 +- website/client/components/tasks/column.vue | 3 - website/client/components/tasks/spells.vue | 3 - website/client/components/tasks/tagsPopup.vue | 2 +- website/client/components/tasks/task.vue | 4 - website/client/components/tasks/taskModal.vue | 12 +- website/client/components/tasks/user.vue | 18 +-- .../components/ui/customMenuDropdown.vue | 4 +- website/client/components/ui/itemRows.vue | 19 +-- website/client/components/userMenu/inbox.vue | 9 +- .../client/components/userMenu/profile.vue | 6 +- .../components/userMenu/profilePage.vue | 2 +- .../client/components/yesterdailyModal.vue | 4 +- website/client/main.js | 3 + website/client/mixins/openedItemRows.js | 29 +++++ website/client/mixins/payments.js | 2 +- 105 files changed, 354 insertions(+), 684 deletions(-) create mode 100644 website/client/components/private-message-modal.vue create mode 100644 website/client/mixins/openedItemRows.js diff --git a/package-lock.json b/package-lock.json index b798ac4f54..24e836a7d2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -32,6 +32,15 @@ "ws": "1.1.4" } }, + "JSONStream": { + "version": "1.3.1", + "resolved": "https://registry.npmjs.org/JSONStream/-/JSONStream-1.3.1.tgz", + "integrity": "sha1-cH92HgHa6eFvG8+TcDt4xwlmV5o=", + "requires": { + "jsonparse": "1.3.1", + "through": "2.3.8" + } + }, "abbrev": { "version": "1.1.1", "resolved": "https://registry.npmjs.org/abbrev/-/abbrev-1.1.1.tgz", @@ -1643,31 +1652,16 @@ } }, "bootstrap": { - "version": "4.0.0-alpha.6", - "resolved": "https://registry.npmjs.org/bootstrap/-/bootstrap-4.0.0-alpha.6.tgz", - "integrity": "sha1-T1TdM6wN6sOyhAe8LffsYIhpycg=", - "requires": { - "jquery": "3.2.1", - "tether": "1.4.0" - } + "version": "4.0.0-beta.2", + "resolved": "https://registry.npmjs.org/bootstrap/-/bootstrap-4.0.0-beta.2.tgz", + "integrity": "sha512-DzGtdTlKbrMoGMpz0LigKSqJ+MgtFKxA791PU/q062OlRG0HybNZcTLH7rpDAmLS66Y3esN9yzKHLLbqa5UR3w==" }, "bootstrap-vue": { - "version": "1.0.0-beta.7", - "resolved": "https://registry.npmjs.org/bootstrap-vue/-/bootstrap-vue-1.0.0-beta.7.tgz", - "integrity": "sha512-m9MOvv7Okl03JoZx+J1crEw24Qenn6MdXCKHCivcx1iVRj1wUUs6ZfLO5xJ1W2xd4aW8Gv8LOy+CUtP5DnuCiA==", + "version": "1.0.0-beta.9", + "resolved": "https://registry.npmjs.org/bootstrap-vue/-/bootstrap-vue-1.0.0-beta.9.tgz", + "integrity": "sha512-0wYWRebZROB+IXpatXgr/pUsiZ7ZUl/uJmc3bpIKlsi9sciE7wIdjV9PhdHnqoipU0kYylHfdcHimOHl5aIbjA==", "requires": { - "bootstrap": "4.0.0-beta.2", - "jquery": "3.2.1", - "popper.js": "1.12.6", - "vue": "2.5.3", - "vue-functional-data-merge": "1.0.6" - }, - "dependencies": { - "bootstrap": { - "version": "4.0.0-beta.2", - "resolved": "https://registry.npmjs.org/bootstrap/-/bootstrap-4.0.0-beta.2.tgz", - "integrity": "sha512-DzGtdTlKbrMoGMpz0LigKSqJ+MgtFKxA791PU/q062OlRG0HybNZcTLH7rpDAmLS66Y3esN9yzKHLLbqa5UR3w==" - } + "bootstrap": "4.0.0-beta.2" } }, "boxen": { @@ -1778,9 +1772,9 @@ "resolved": "https://registry.npmjs.org/browser-pack/-/browser-pack-6.0.2.tgz", "integrity": "sha1-+GzWzvT1MAyOY+B6TVEvZfv/RTE=", "requires": { + "JSONStream": "1.3.1", "combine-source-map": "0.7.2", "defined": "1.0.0", - "JSONStream": "1.3.1", "through2": "2.0.3", "umd": "3.0.1" } @@ -1810,6 +1804,7 @@ "resolved": "https://registry.npmjs.org/browserify/-/browserify-12.0.2.tgz", "integrity": "sha1-V/IeXm4wj/WYfE2v1EhAsrmPehk=", "requires": { + "JSONStream": "1.3.1", "assert": "1.3.0", "browser-pack": "6.0.2", "browser-resolve": "1.11.2", @@ -1831,7 +1826,6 @@ "inherits": "2.0.3", "insert-module-globals": "7.0.1", "isarray": "0.0.1", - "JSONStream": "1.3.1", "labeled-stream-splicer": "2.0.0", "module-deps": "4.1.1", "os-browserify": "0.1.2", @@ -6605,13 +6599,6 @@ } } }, - "string_decoder": { - "version": "1.0.1", - "bundled": true, - "requires": { - "safe-buffer": "5.0.1" - } - }, "string-width": { "version": "1.0.2", "bundled": true, @@ -6621,6 +6608,13 @@ "strip-ansi": "3.0.1" } }, + "string_decoder": { + "version": "1.0.1", + "bundled": true, + "requires": { + "safe-buffer": "5.0.1" + } + }, "stringstream": { "version": "0.0.5", "bundled": true, @@ -8779,10 +8773,10 @@ "resolved": "https://registry.npmjs.org/insert-module-globals/-/insert-module-globals-7.0.1.tgz", "integrity": "sha1-wDv04BywhtW15azorQr+eInWOMM=", "requires": { + "JSONStream": "1.3.1", "combine-source-map": "0.7.2", "concat-stream": "1.5.2", "is-buffer": "1.1.6", - "JSONStream": "1.3.1", "lexical-scope": "1.2.0", "process": "0.11.10", "through2": "2.0.3", @@ -9618,15 +9612,6 @@ "resolved": "https://registry.npmjs.org/jsonpointer/-/jsonpointer-4.0.1.tgz", "integrity": "sha1-T9kss04OnbPInIYi7PUfm5eMbLk=" }, - "JSONStream": { - "version": "1.3.1", - "resolved": "https://registry.npmjs.org/JSONStream/-/JSONStream-1.3.1.tgz", - "integrity": "sha1-cH92HgHa6eFvG8+TcDt4xwlmV5o=", - "requires": { - "jsonparse": "1.3.1", - "through": "2.3.8" - } - }, "jsprim": { "version": "1.4.1", "resolved": "https://registry.npmjs.org/jsprim/-/jsprim-1.4.1.tgz", @@ -11424,6 +11409,7 @@ "resolved": "https://registry.npmjs.org/module-deps/-/module-deps-4.1.1.tgz", "integrity": "sha1-IyFYM/HaE/1gbMuAh7RIUty4If0=", "requires": { + "JSONStream": "1.3.1", "browser-resolve": "1.11.2", "cached-path-relative": "1.0.1", "concat-stream": "1.5.2", @@ -11431,7 +11417,6 @@ "detective": "4.5.0", "duplexer2": "0.1.4", "inherits": "2.0.3", - "JSONStream": "1.3.1", "parents": "1.0.1", "readable-stream": "2.0.6", "resolve": "1.5.0", @@ -15299,22 +15284,6 @@ "throttleit": "1.0.0" } }, - "require_optional": { - "version": "1.0.1", - "resolved": "https://registry.npmjs.org/require_optional/-/require_optional-1.0.1.tgz", - "integrity": "sha512-qhM/y57enGWHAe3v/NcwML6a3/vfESLe/sGM2dII+gEO0BpKRUkWZow/tyloNqJyN6kXSl3RyyM8Ll5D/sJP8g==", - "requires": { - "resolve-from": "2.0.0", - "semver": "5.4.1" - }, - "dependencies": { - "semver": { - "version": "5.4.1", - "resolved": "https://registry.npmjs.org/semver/-/semver-5.4.1.tgz", - "integrity": "sha512-WfG/X9+oATh81XtllIo/I8gOiY9EXRdv1cQdyykeXK17YcUW3EXUAi2To4pcH6nZtJPr7ZOpM5OMyWJZm+8Rsg==" - } - } - }, "require-again": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/require-again/-/require-again-2.0.0.tgz", @@ -15354,6 +15323,22 @@ } } }, + "require_optional": { + "version": "1.0.1", + "resolved": "https://registry.npmjs.org/require_optional/-/require_optional-1.0.1.tgz", + "integrity": "sha512-qhM/y57enGWHAe3v/NcwML6a3/vfESLe/sGM2dII+gEO0BpKRUkWZow/tyloNqJyN6kXSl3RyyM8Ll5D/sJP8g==", + "requires": { + "resolve-from": "2.0.0", + "semver": "5.4.1" + }, + "dependencies": { + "semver": { + "version": "5.4.1", + "resolved": "https://registry.npmjs.org/semver/-/semver-5.4.1.tgz", + "integrity": "sha512-WfG/X9+oATh81XtllIo/I8gOiY9EXRdv1cQdyykeXK17YcUW3EXUAi2To4pcH6nZtJPr7ZOpM5OMyWJZm+8Rsg==" + } + } + }, "requires-port": { "version": "1.0.0", "resolved": "https://registry.npmjs.org/requires-port/-/requires-port-1.0.0.tgz", @@ -16663,11 +16648,6 @@ "resolved": "https://registry.npmjs.org/strict-uri-encode/-/strict-uri-encode-1.1.0.tgz", "integrity": "sha1-J5siXfHVgrH1TmWt3UNS4Y+qBxM=" }, - "string_decoder": { - "version": "0.10.31", - "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-0.10.31.tgz", - "integrity": "sha1-YuIDvEF2bGwoyfyEMB2rHFMQ+pQ=" - }, "string-width": { "version": "1.0.2", "resolved": "https://registry.npmjs.org/string-width/-/string-width-1.0.2.tgz", @@ -16678,6 +16658,11 @@ "strip-ansi": "3.0.1" } }, + "string_decoder": { + "version": "0.10.31", + "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-0.10.31.tgz", + "integrity": "sha1-YuIDvEF2bGwoyfyEMB2rHFMQ+pQ=" + }, "stringstream": { "version": "0.0.5", "resolved": "https://registry.npmjs.org/stringstream/-/stringstream-0.0.5.tgz", @@ -17208,11 +17193,6 @@ "require-main-filename": "1.0.1" } }, - "tether": { - "version": "1.4.0", - "resolved": "https://registry.npmjs.org/tether/-/tether-1.4.0.tgz", - "integrity": "sha1-D5+hcfdb9YSF2BSelHmdeudNHBo=" - }, "text-table": { "version": "0.2.0", "resolved": "https://registry.npmjs.org/text-table/-/text-table-0.2.0.tgz", @@ -18209,11 +18189,6 @@ "resolved": "https://registry.npmjs.org/vue/-/vue-2.5.3.tgz", "integrity": "sha512-C8O5ZtR9jpwm6sCre3k42/WvuAcil5hH1+c3mJks8kNCYKh57sQh6I5U7m9L0fD89OKkIofmebUORngZkLedNA==" }, - "vue-functional-data-merge": { - "version": "1.0.6", - "resolved": "https://registry.npmjs.org/vue-functional-data-merge/-/vue-functional-data-merge-1.0.6.tgz", - "integrity": "sha512-wzUHcvLBiVJcDais1HdmFObi2VagMB5jd/dZuacDO0GCdHURxkvPrReaAyAhW/+g29j5gRu0QKP1DH7CaBRwmQ==" - }, "vue-hot-reload-api": { "version": "2.2.0", "resolved": "https://registry.npmjs.org/vue-hot-reload-api/-/vue-hot-reload-api-2.2.0.tgz", diff --git a/package.json b/package.json index 676ce0e92e..67794ca94e 100644 --- a/package.json +++ b/package.json @@ -31,8 +31,8 @@ "bcrypt": "^1.0.2", "bluebird": "^3.3.5", "body-parser": "^1.15.0", - "bootstrap": "4.0.0-alpha.6", - "bootstrap-vue": "1.0.0-beta.7", + "bootstrap": "4.0.0-beta.2", + "bootstrap-vue": "1.0.0-beta.9", "browserify": "~12.0.1", "compression": "^1.6.1", "connect-ratelimit": "0.0.7", diff --git a/website/client/app.vue b/website/client/app.vue index 552ebe2364..d6953d7663 100644 --- a/website/client/app.vue +++ b/website/client/app.vue @@ -135,12 +135,12 @@ export default { // @TODO: I'm not sure these should be at the app level. Can we move these back into shop/inventory or maybe they need a lateral move? this.$root.$on('buyModal::showItem', (item) => { this.selectedItemToBuy = item; - this.$root.$emit('show::modal', 'buy-modal'); + this.$root.$emit('bv::show::modal', 'buy-modal'); }); this.$root.$on('selectMembersModal::showItem', (item) => { this.selectedSpellToBuy = item; - this.$root.$emit('show::modal', 'select-member-modal'); + this.$root.$emit('bv::show::modal', 'select-member-modal'); }); // @TODO split up this file, it's too big @@ -264,7 +264,7 @@ export default { } // Manage modals - this.$root.$on('show::modal', (modalId, data = {}) => { + this.$root.$on('bv::show::modal', (modalId, data = {}) => { if (data.fromRoot) return; // Track opening of gems modal unless it's been already tracked @@ -286,7 +286,7 @@ export default { this.$store.state.modalStack.push(modalId); // Hide the previous top modal - if (modalOnTop) this.$root.$emit('hide::modal', modalOnTop, {fromRoot: true}); + if (modalOnTop) this.$root.$emit('bv::hide::modal', modalOnTop, {fromRoot: true}); }); // @TODO: This part is hacky and could be solved with two options: @@ -307,7 +307,7 @@ export default { // Recalculate and show the last modal if there is one modalStackLength = this.$store.state.modalStack.length; modalOnTop = this.$store.state.modalStack[modalStackLength - 1]; - if (modalOnTop) this.$root.$emit('show::modal', modalOnTop, {fromRoot: true}); + if (modalOnTop) this.$root.$emit('bv::show::modal', modalOnTop, {fromRoot: true}); }); }, methods: { @@ -333,8 +333,8 @@ export default { if (this.user.party._id) { this.selectedSpellToBuy = item; - this.$root.$emit('hide::modal', 'buy-modal'); - this.$root.$emit('show::modal', 'select-member-modal'); + this.$root.$emit('bv::hide::modal', 'buy-modal'); + this.$root.$emit('bv::show::modal', 'select-member-modal'); } else { this.error(this.$t('errorNotInParty')); } @@ -346,7 +346,7 @@ export default { this.$store.dispatch('party:getMembers', {forceLoad: true}); - this.$root.$emit('hide::modal', 'select-member-modal'); + this.$root.$emit('bv::hide::modal', 'select-member-modal'); }, hideLoadingScreen () { const loadingScreen = document.getElementById('loading-screen'); diff --git a/website/client/assets/scss/button.scss b/website/client/assets/scss/button.scss index 1f77b30ff5..533f83f096 100644 --- a/website/client/assets/scss/button.scss +++ b/website/client/assets/scss/button.scss @@ -26,7 +26,7 @@ } &:active:not(.btn-flat), &.active:not(.btn-flat) { - box-shadow: none; + box-shadow: none !important; border: 1px solid transparent; } } @@ -45,7 +45,7 @@ } &:hover:not(:disabled), &:active, &.active, &:focus { - background: #5d3b9c; + background: #5d3b9c !important; color: $white; } } diff --git a/website/client/assets/scss/modal.scss b/website/client/assets/scss/modal.scss index 7f85a2cb9b..b19075aeef 100644 --- a/website/client/assets/scss/modal.scss +++ b/website/client/assets/scss/modal.scss @@ -1,7 +1,6 @@ @import '~client/assets/scss/colors.scss'; - @mixin centeredModal() { display: flex; justify-content: center; @@ -13,6 +12,8 @@ } .modal-dialog { + width: auto; + .title { min-height: 24px; margin-top: 24px; diff --git a/website/client/components/achievements/armoireEmpty.vue b/website/client/components/achievements/armoireEmpty.vue index e3fc3b26f7..dca69af311 100644 --- a/website/client/components/achievements/armoireEmpty.vue +++ b/website/client/components/achievements/armoireEmpty.vue @@ -18,15 +18,10 @@ diff --git a/website/client/components/userMenu/inbox.vue b/website/client/components/userMenu/inbox.vue index cbdacfe976..f32bb05af5 100644 --- a/website/client/components/userMenu/inbox.vue +++ b/website/client/components/userMenu/inbox.vue @@ -163,9 +163,6 @@ import sortBy from 'lodash/sortBy'; import { mapState } from 'client/libs/store'; import styleHelper from 'client/mixins/styleHelper'; -import bModal from 'bootstrap-vue/lib/components/modal'; -import bFormInput from 'bootstrap-vue/lib/components/form-input'; - import messageIcon from 'assets/svg/message.svg'; import chatMessage from '../chat/chatMessages'; import svgClose from 'assets/svg/close.svg'; @@ -173,13 +170,11 @@ import svgClose from 'assets/svg/close.svg'; export default { mixins: [styleHelper], components: { - bModal, - bFormInput, chatMessage, }, mounted () { this.$root.$on('habitica::new-inbox-message', (data) => { - this.$root.$emit('show::modal', 'inbox-modal'); + this.$root.$emit('bv::show::modal', 'inbox-modal'); const conversation = this.conversations.find(convo => { return convo.key === data.userIdToMessage; @@ -325,7 +320,7 @@ export default { }); }, close () { - this.$root.$emit('hide::modal', 'inbox-modal'); + this.$root.$emit('bv::hide::modal', 'inbox-modal'); }, }, }; diff --git a/website/client/components/userMenu/profile.vue b/website/client/components/userMenu/profile.vue index 731a2c3465..7b14a4f3ef 100644 --- a/website/client/components/userMenu/profile.vue +++ b/website/client/components/userMenu/profile.vue @@ -551,7 +551,6 @@ div diff --git a/website/client/components/yesterdailyModal.vue b/website/client/components/yesterdailyModal.vue index 42c1a11f34..4e3f675978 100644 --- a/website/client/components/yesterdailyModal.vue +++ b/website/client/components/yesterdailyModal.vue @@ -53,13 +53,11 @@