mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-18 07:07:35 +01:00
Merge branch 'develop' into phillip/chat-skill-merge
This commit is contained in:
@@ -12,7 +12,7 @@ import {
|
||||
} from '../models/group';
|
||||
import apiError from './apiError';
|
||||
|
||||
const partyMembersFields = 'profile.name stats achievements items.special notifications flags pinnedItems';
|
||||
const partyMembersFields = 'profile.name stats achievements items.special pinnedItems notifications flags';
|
||||
// Excluding notifications and flags from the list of public fields to return.
|
||||
const partyMembersPublicFields = 'profile.name stats achievements items.special';
|
||||
|
||||
@@ -75,12 +75,13 @@ async function castSelfSpell (req, user, spell, quantity = 1) {
|
||||
await user.save();
|
||||
}
|
||||
|
||||
async function castPartySpell (req, party, partyMembers, user, spell, quantity = 1) {
|
||||
async function getPartyMembers (user, party) {
|
||||
let partyMembers;
|
||||
if (!party) {
|
||||
// Act as solo party
|
||||
partyMembers = [user]; // eslint-disable-line no-param-reassign
|
||||
partyMembers = [user];
|
||||
} else {
|
||||
partyMembers = await User // eslint-disable-line no-param-reassign
|
||||
partyMembers = await User
|
||||
.find({
|
||||
'party._id': party._id,
|
||||
_id: { $ne: user._id }, // add separately
|
||||
@@ -90,22 +91,40 @@ async function castPartySpell (req, party, partyMembers, user, spell, quantity =
|
||||
|
||||
partyMembers.unshift(user);
|
||||
}
|
||||
|
||||
for (let i = 0; i < quantity; i += 1) {
|
||||
spell.cast(user, partyMembers, req);
|
||||
}
|
||||
await Promise.all(partyMembers.map(m => m.save()));
|
||||
|
||||
return partyMembers;
|
||||
}
|
||||
|
||||
async function castUserSpell (res, req, party, partyMembers, targetId, user, spell, quantity = 1) {
|
||||
async function castPartySpell (req, party, user, spell, quantity = 1) {
|
||||
let partyMembers;
|
||||
if (spell.bulk) {
|
||||
const data = { };
|
||||
if (party) {
|
||||
data.query = { 'party._id': party._id };
|
||||
} else {
|
||||
data.query = { _id: user._id };
|
||||
}
|
||||
spell.cast(user, data);
|
||||
await User.updateMany(data.query, data.update);
|
||||
await user.save();
|
||||
partyMembers = await getPartyMembers(user, party);
|
||||
} else {
|
||||
partyMembers = await getPartyMembers(user, party);
|
||||
for (let i = 0; i < quantity; i += 1) {
|
||||
spell.cast(user, partyMembers, req);
|
||||
}
|
||||
await Promise.all(partyMembers.map(m => m.save()));
|
||||
}
|
||||
return partyMembers;
|
||||
}
|
||||
|
||||
async function castUserSpell (res, req, party, targetId, user, spell, quantity = 1) {
|
||||
let partyMembers;
|
||||
if (!party && (!targetId || user._id === targetId)) {
|
||||
partyMembers = user; // eslint-disable-line no-param-reassign
|
||||
partyMembers = user;
|
||||
} else {
|
||||
if (!targetId) throw new BadRequest(res.t('targetIdUUID'));
|
||||
if (!party) throw new NotFound(res.t('partyNotFound'));
|
||||
partyMembers = await User // eslint-disable-line no-param-reassign
|
||||
partyMembers = await User
|
||||
.findOne({ _id: targetId, 'party._id': party._id })
|
||||
.select(partyMembersFields)
|
||||
.exec();
|
||||
@@ -196,10 +215,10 @@ async function castSpell (req, res, { isV3 = false }) {
|
||||
let partyMembers;
|
||||
|
||||
if (targetType === 'party') {
|
||||
partyMembers = await castPartySpell(req, party, partyMembers, user, spell, quantity);
|
||||
partyMembers = await castPartySpell(req, party, user, spell, quantity);
|
||||
} else {
|
||||
partyMembers = await castUserSpell(
|
||||
res, req, party, partyMembers,
|
||||
res, req, party,
|
||||
targetId, user, spell, quantity,
|
||||
);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user