mirror of
https://github.com/HabitRPG/habitica.git
synced 2025-12-19 15:48:04 +01:00
feat(api-v3): First iteration of quest invite
This commit is contained in:
@@ -1,6 +1,7 @@
|
|||||||
import {
|
import {
|
||||||
createAndPopulateGroup,
|
createAndPopulateGroup,
|
||||||
translate as t,
|
translate as t,
|
||||||
|
sleep,
|
||||||
} from '../../../../helpers/api-v3-integration.helper';
|
} from '../../../../helpers/api-v3-integration.helper';
|
||||||
import { v4 as generateUUID } from 'uuid';
|
import { v4 as generateUUID } from 'uuid';
|
||||||
import { quests as questScrolls } from '../../../../../common/script/content';
|
import { quests as questScrolls } from '../../../../../common/script/content';
|
||||||
@@ -122,8 +123,8 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
|
|||||||
]);
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
xit('adds quest details to group object', async () => {
|
it('adds quest details to group object', async () => {
|
||||||
await leader.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
||||||
|
|
||||||
await questingGroup.sync();
|
await questingGroup.sync();
|
||||||
|
|
||||||
@@ -131,47 +132,61 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => {
|
|||||||
|
|
||||||
expect(quest.key).to.eql(PET_QUEST);
|
expect(quest.key).to.eql(PET_QUEST);
|
||||||
expect(quest.active).to.eql(false);
|
expect(quest.active).to.eql(false);
|
||||||
expect(quest.leader).to.eql(false);
|
expect(quest.leader).to.eql(leader._id);
|
||||||
expect(quest.members).to.have.property(leader._id, null);
|
expect(quest.members).to.have.property(leader._id, true);
|
||||||
expect(quest.members).to.have.property(member._id, null);
|
expect(quest.members).to.have.property(member._id, null);
|
||||||
expect(quest).to.have.property('progress');
|
expect(quest).to.have.property('progress');
|
||||||
});
|
});
|
||||||
|
|
||||||
xit('adds quest details to user objects', async () => {
|
it('adds quest details to user objects', async () => {
|
||||||
await leader.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
||||||
|
|
||||||
|
await sleep(0.1); // member updates happen in the background
|
||||||
|
|
||||||
await Promise.all([
|
await Promise.all([
|
||||||
leader.sync(),
|
leader.sync(),
|
||||||
member.sync(),
|
member.sync(),
|
||||||
]);
|
]);
|
||||||
|
|
||||||
[leader, member].forEach((user) => {
|
expect(leader.party.quest.key).to.eql(PET_QUEST);
|
||||||
let quest = user.party.quest;
|
expect(member.party.quest.key).to.eql(PET_QUEST);
|
||||||
|
expect(leader.party.quest.RSVPNeeded).to.eql(false);
|
||||||
expect(quest.key).to.eql(PET_QUEST);
|
expect(member.party.quest.RSVPNeeded).to.eql(true);
|
||||||
expect(quest.active).to.eql(false);
|
|
||||||
expect(quest.leader).to.eql(false);
|
|
||||||
expect(quest.members).to.have.property(leader._id, null);
|
|
||||||
expect(quest.members).to.have.property(member._id, null);
|
|
||||||
expect(quest).to.have.property('progress');
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
|
|
||||||
xit('sends back the quest object', async () => {
|
it('sends back the quest object', async () => {
|
||||||
let inviteResponse = await leader.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
let inviteResponse = await leader.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
||||||
|
|
||||||
expect(inviteResponse.key).to.eql(PET_QUEST);
|
expect(inviteResponse.key).to.eql(PET_QUEST);
|
||||||
expect(inviteResponse.active).to.eql(false);
|
expect(inviteResponse.active).to.eql(false);
|
||||||
expect(inviteResponse.leader).to.eql(false);
|
expect(inviteResponse.leader).to.eql(leader._id);
|
||||||
expect(inviteResponse.members).to.have.property(leader._id, null);
|
expect(inviteResponse.members).to.have.property(leader._id, true);
|
||||||
expect(inviteResponse.members).to.have.property(member._id, null);
|
expect(inviteResponse.members).to.have.property(member._id, null);
|
||||||
expect(inviteResponse).to.have.property('progress');
|
expect(inviteResponse).to.have.property('progress');
|
||||||
});
|
});
|
||||||
|
|
||||||
xit('allows non-leader party members to send invites', async () => {
|
it('allows non-party-leader party members to send invites', async () => {
|
||||||
let inviteResponse = await member.post(`groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
let inviteResponse = await member.post(`/groups/${questingGroup._id}/quests/invite/${PET_QUEST}`);
|
||||||
|
|
||||||
|
await questingGroup.sync();
|
||||||
|
|
||||||
expect(inviteResponse.key).to.eql(PET_QUEST);
|
expect(inviteResponse.key).to.eql(PET_QUEST);
|
||||||
|
expect(questingGroup.quest.key).to.eql(PET_QUEST);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('starts quest automatically if user is in a solo party', async () => {
|
||||||
|
let leaderDetails = { balance: 10 };
|
||||||
|
leaderDetails[`items.quests.${PET_QUEST}`] = 1;
|
||||||
|
let { group, groupLeader } = await createAndPopulateGroup({
|
||||||
|
groupDetails: { type: 'party', privacy: 'private' },
|
||||||
|
leaderDetails,
|
||||||
|
});
|
||||||
|
|
||||||
|
await groupLeader.post(`/groups/${group._id}/quests/invite/${PET_QUEST}`);
|
||||||
|
|
||||||
|
await group.sync();
|
||||||
|
|
||||||
|
expect(group.quest.active).to.eql(true);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,14 +1,25 @@
|
|||||||
|
import _ from 'lodash';
|
||||||
|
import Q from 'q';
|
||||||
import { authWithHeaders } from '../../middlewares/api-v3/auth';
|
import { authWithHeaders } from '../../middlewares/api-v3/auth';
|
||||||
import cron from '../../middlewares/api-v3/cron';
|
import cron from '../../middlewares/api-v3/cron';
|
||||||
import {
|
import {
|
||||||
model as Group,
|
model as Group,
|
||||||
} from '../../models/group';
|
} from '../../models/group';
|
||||||
|
import {
|
||||||
|
model as User,
|
||||||
|
} from '../../models/user';
|
||||||
import {
|
import {
|
||||||
NotFound,
|
NotFound,
|
||||||
NotAuthorized,
|
NotAuthorized,
|
||||||
} from '../../libs/api-v3/errors';
|
} from '../../libs/api-v3/errors';
|
||||||
import { quests as questScrolls } from '../../../../common/script/content';
|
import { quests as questScrolls } from '../../../../common/script/content';
|
||||||
|
|
||||||
|
function canStartQuestAutomatically (group) {
|
||||||
|
// If all members are either true (accepted) or false (rejected) return true
|
||||||
|
// If any member is null/undefined (undecided) return false
|
||||||
|
return _.every(group.quest.members, Boolean);
|
||||||
|
}
|
||||||
|
|
||||||
let api = {};
|
let api = {};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -44,24 +55,43 @@ api.inviteToQuest = {
|
|||||||
if (user.stats.lvl < quest.lvl) throw new NotAuthorized(res.t('questLevelTooHigh', { level: quest.lvl }));
|
if (user.stats.lvl < quest.lvl) throw new NotAuthorized(res.t('questLevelTooHigh', { level: quest.lvl }));
|
||||||
if (group.quest.key) throw new NotAuthorized(res.t('questAlreadyUnderway'));
|
if (group.quest.key) throw new NotAuthorized(res.t('questAlreadyUnderway'));
|
||||||
|
|
||||||
|
let members = await User.find({ 'party._id': group._id }, 'auth.facebook auth.local preferences.emailNotifications').exec();
|
||||||
|
let backgroundOperations = [];
|
||||||
|
|
||||||
group.markModified('quest');
|
group.markModified('quest');
|
||||||
group.quest.key = questKey;
|
group.quest.key = questKey;
|
||||||
group.quest.leader = user._id;
|
group.quest.leader = user._id;
|
||||||
group.quest.members = {};
|
group.quest.members = {};
|
||||||
|
group.quest.members[user._id] = true;
|
||||||
|
|
||||||
// let memberUpdate = {
|
user.party.quest.RSVPNeeded = false;
|
||||||
// '$set': {
|
user.party.quest.key = questKey;
|
||||||
// 'party.quest.key': questKey,
|
|
||||||
// 'party.quest.progress.down': 0,
|
|
||||||
// 'party.quest.completed': null,
|
|
||||||
// },
|
|
||||||
// };
|
|
||||||
|
|
||||||
// TODO collect members of party
|
_.each(members, (member) => {
|
||||||
// TODO Logic for quest invite and send back quest object
|
if (member._id !== user._id) {
|
||||||
|
group.quest.members[member._id] = null;
|
||||||
|
member.party.quest.RSVPNeeded = true;
|
||||||
|
member.party.quest.key = questKey;
|
||||||
|
// TODO: Send Quest invite email
|
||||||
|
backgroundOperations.push(member.save());
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
await group.save();
|
if (canStartQuestAutomatically(group)) {
|
||||||
res.respond(200, {});
|
group.startQuest(user);
|
||||||
|
}
|
||||||
|
|
||||||
|
let [savedGroup] = await Q.all([
|
||||||
|
group.save(),
|
||||||
|
user.save(),
|
||||||
|
]);
|
||||||
|
|
||||||
|
res.respond(200, savedGroup.quest);
|
||||||
|
|
||||||
|
Q.allSettled(backgroundOperations).catch(err => {
|
||||||
|
// TODO what to do about errors in background ops
|
||||||
|
throw err;
|
||||||
|
});
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user