krikkert/habitica
1
0
Fork 0
mirror of https://github.com/HabitRPG/habitica.git synced 2025-12-17 14:47:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(ABtest): important parens

Browse Source
This commit is contained in:
Sabe Jones
2020-06-25 15:06:06 -05:00
parent 73844335de
commit 398b3c1f0d
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/common/fns/randomDrop.test.js
View File

@@ -17,6 +17,7 @@ describe('common.fns.randomDrop', () => {
user._tmp = user._tmp ? user._tmp : {}; user._tmp = user._tmp ? user._tmp : {};
user.items.eggs.Wolf = 0; user.items.eggs.Wolf = 0;
user.items.food.Meat = 0; user.items.food.Meat = 0;
user._id = `a${user._id.slice(1)}`;
task = generateTodo({ userId: user._id }); task = generateTodo({ userId: user._id });
predictableRandom = sandbox.stub().returns(0.5); predictableRandom = sandbox.stub().returns(0.5);
}); });

2
website/common/script/fns/randomDrop.js
View File

@@ -47,7 +47,7 @@ export default function randomDrop (user, options, req = {}, analytics) {
let chance = min([Math.abs(task.value - 21.27), 37.5]) / 150 + 0.02; let chance = min([Math.abs(task.value - 21.27), 37.5]) / 150 + 0.02;
chance *= task.priority // Task priority: +50% for Medium, +100% for Hard chance *= task.priority // Task priority: +50% for Medium, +100% for Hard
// A/B test experiment: start users with +75% drops, diminishing by 5% per level gained // A/B test experiment: start users with +75% drops, diminishing by 5% per level gained
* '12345678'.indexOf(user._id.slice(0, 1)) !== -1 ? (1 + Math.max(0, 80 - (5 * user.stats.lvl)) / 100) : 1 * ('12345678'.indexOf(user._id.slice(0, 1)) !== -1 ? (1 + Math.max(0, 80 - (5 * user.stats.lvl)) / 100) : 1)
* (1 + (task.streak / 100 || 0)) // Streak bonus: +1% per streak * (1 + (task.streak / 100 || 0)) // Streak bonus: +1% per streak
* (1 + statsComputed(user).per / 100) // PERception: +1% per point * (1 + statsComputed(user).per / 100) // PERception: +1% per point
* (1 + (user.contributor.level / 40 || 0)) // Contrib levels: +2.5% per level * (1 + (user.contributor.level / 40 || 0)) // Contrib levels: +2.5% per level